Commit Graph

5282 Commits (8b24fba095df7e39c79e29f410e654885e8ad466)

Author SHA1 Message Date
Matthew Chen 9b6d2be370 "Bump build to 2.31.0.2." 7 years ago
Matthew Chen b44a5e9d2a "Bump build to 2.31.0.1." 7 years ago
Matthew Chen c9922cda3e Respond to CR. 7 years ago
Matthew Chen 8fdf6009f9 Sync contacts after rotating profile key. 7 years ago
Matthew Chen eb7abdfc64 Account attributes updates. 7 years ago
Matthew Chen f1d93d4472 Merge remote-tracking branch 'origin/release/2.30.2' 7 years ago
Matthew Chen c995c838d2 "Bump build to 2.30.2.14." 7 years ago
Matthew Chen ebd3560547 "Bump build to 2.30.2.13." 7 years ago
Michael Kirk 43884af191 remove redundant "failed to download" method 7 years ago
Michael Kirk efe07e1ddb Secret sender icon in message details 7 years ago
Michael Kirk 54b184bc97 Whitelist cds domain 7 years ago
Matthew Chen 2054bdc690 "Bump build to 2.31.0.0." 7 years ago
Matthew Chen 51699ebc04 "Bump build to 2.30.2.12." 7 years ago
Michael Kirk 4435d16f9c dark theme toggle in app settings 7 years ago
Matthew Chen c907721a18 Rotate profile key if blocklist intersects profile whitelist. 7 years ago
Michael Kirk 1544f8db46 Optionally show UD status in message details 7 years ago
Michael Kirk 221ce513f1 extract dependencies, no change in behavior 7 years ago
Michael Kirk c680908646 add toggle for unrestricted access 7 years ago
Matthew Chen f24ccb3ce6 Hang more singletons on SSKEnv. 7 years ago
Matthew Chen a6eed30127 Add 'is ud' property to outgoing messages. 7 years ago
Matthew Chen cba8c67983 Add 'is ud' property to incoming messages. 7 years ago
Matthew Chen 501f4641a9 "Bump build to 2.30.2.11." 7 years ago
Matthew Chen 17541a8888 Change conversation bubble colors. 7 years ago
Matthew Chen 5344766ef2 "Bump build to 2.30.2.10." 7 years ago
Michael Kirk ac12169627 Keep home view controller in the navigation stack when entering an archived conversation. 7 years ago
Matthew Chen acdd7f2805 Fix settings button glitch on iOS 10. 7 years ago
Matthew Chen 21b383f4e2 Remove server GUID from TSIncomingMessage. 7 years ago
Matthew Chen 3b06434d4f Split out second web socket. 7 years ago
Matthew Chen c137e95ae5 Move socket manager to hang on SSKEnvironment. 7 years ago
Matthew Chen f9e90215b3 Respond to CR. 7 years ago
Michael Kirk 0cb6a57656 "Bump build to 2.30.2.9." 7 years ago
Michael Kirk 2b805e4eae Constantize ConversationColorName, map previous incorrect values 7 years ago
Michael Kirk b612533d46 "Bump build to 2.30.2.8." 7 years ago
Michael Kirk b02f3eec1b update translations 7 years ago
Matthew Chen ccb67f49a3 Fix issues in UD send & receive. 7 years ago
Matthew Chen 0b41e5e240 Rework profile fetch to reflect UD changes. 7 years ago
Matthew Chen 2eeba2d79f Fix spurious assert in orphan data clenaer. 7 years ago
Matthew Chen 6b21849b88 "Bump build to 2.30.2.7." 7 years ago
Michael Kirk e18af5a475 sync translations 7 years ago
Michael Kirk f243914fe5 NSTemporaryDirectory -> OWSTemporaryDirectory/AccessibleAfterFirstAuth
Remove redundant move - AFNetworking alread moves the CFNetwork tmp file for
us.
7 years ago
Michael Kirk e1e355bfec fixup filebrowser 7 years ago
Matthew Chen 3eb84ed0e0 Move message processing singletons to SSKEnvironment. 7 years ago
Matthew Chen 580d0486b6 Respond to CR. 7 years ago
Matthew Chen 9f2a15925a Add new envelope properties for UD. 7 years ago
Matthew Chen 4ab281346a Respond to CR. 7 years ago
Matthew Chen 39f1be65f3 Respond to CR. 7 years ago
Matthew Chen 1b1312c455 Clean up ahead of CR. 7 years ago
Matthew Chen 1d40cbfb41 Rework account attributes; persist manual message fetch; add "unrestricted UD" setting. 7 years ago
Michael Kirk 2d3bd87de9 sync translations 7 years ago
Michael Kirk 9f7cdc3f85 "Bump build to 2.30.2.6." 7 years ago
Michael Kirk a065c391d7 "Bump build to 2.30.2.5." 7 years ago
Michael Kirk 6560358375 Fix failed attachment downloads in beta 7 years ago
Matthew Chen d4fab97a7b Fix build breakage. 7 years ago
Matthew Chen f7379deb69 Add setup method to UD manager. Try to verify server certificate expiration. 7 years ago
Matthew Chen 21177e84db Fix or disable tests broken by recent merges. 7 years ago
Matthew Chen 71da312336 Post-SMK ud changes. 7 years ago
Matthew Chen db487705c3 Fix breakage in the tests. 7 years ago
Michael Kirk dcb65854eb More scaleable across device sizes. 7 years ago
Michael Kirk bdb5bd5596 minimize diff 7 years ago
Michael Kirk 375c8bee04 Use stand accessoryView mechanics 7 years ago
Michael Kirk 5127352f7a update color picker cell per design 7 years ago
Michael Kirk bbbc5bbb83 update copy per myles 7 years ago
Michael Kirk 7805e00441 work around multiple review's appearing 7 years ago
Michael Kirk 006021ea41 Fix: group color change doesn't immediately apply
Because we were fetching a new thread instance, instead of updating the
existing thread instance, classes which were bound to the old thread instance
weren't updating. This affected the HeaderView.AvatarView.thread and the
ConversationStyle.thread.
7 years ago
Matthew Chen a224401879 Respond to CR. 7 years ago
Matthew Chen 24d7a97616 Fix rebase breakage. 7 years ago
Matthew Chen 7d727b7ac9 Modify proto wrapper builders to require required fields. 7 years ago
Matthew Chen 74e456f90e Modify proto wrapper builders to require required fields. 7 years ago
Matthew Chen 3738155c81 Fix build breakage from SMK. 7 years ago
Matthew Chen 8ae200ac21 Fix build breakage around SignalCoreKit. 7 years ago
Matthew Chen b77528ca0a Fix asserts & logging. 7 years ago
Matthew Chen 0125535d4d Pull out SignalCoreKit. 7 years ago
Matthew Chen 5fc21bce96 "Bump build to 2.30.2.4." 7 years ago
Matthew Chen 9474a1bfcb Fix "broken settings button layout in iOS 9" issue. 7 years ago
Matthew Chen 908d6dfd78 Ensure unread badges in home view are always at least a circle. 7 years ago
Matthew Chen b07de266c6 "Bump build to 2.30.2.3." 7 years ago
Michael Kirk 56387f3574 demo conversation colors when selecting 7 years ago
Michael Kirk 06eae47e09 ConversationViewItem -> protocol 7 years ago
Matthew Chen f56ac96d31 "Bump build to 2.30.2.2." 7 years ago
Matthew Chen ebae75af00 Revert 'new sort id'. 7 years ago
Matthew Chen 673dae83d9 Bump build to 2.30.2.1. 7 years ago
Matthew Chen 69b805c390 "Bump build to 2.30.1.1." 7 years ago
Matthew Chen b076f14964 Swift exit(). 7 years ago
Matthew Chen 1e82caed03 Remove dark theme feature flag. 7 years ago
Matthew Chen 99766fe07b Update l10n strings. 7 years ago
Michael Kirk 4765ed9a06 Color picker
TODO

-[x] tap to select/deselect
-[x] initially selected
-[x] integrate into conversation settings
-[x] colorPickerDelegate
-[x] translate strings
-[] reorder colors
-[x] SheetView: add top handle

Nice to have:

-[] SheetView: interactively swipe/unswipe to dismiss?
-[] preview color in bubbles
7 years ago
Joshua Lund 97d0543cef String cleanup:
* Made our Title Case usage a little more consistent.
* Standardized on the ellipses special character.
* Rephrased a few buttons and descriptions.
7 years ago
Michael Kirk 79add78d51 Merge branch 'release/2.30.1' 7 years ago
Matthew Chen 2ef878bfc9 Add crash gesture to about view. 7 years ago
Matthew Chen 5a99cd347f Pull out OWSConversationColor to its own file. 7 years ago
Matthew Chen 0e5f42defe Use new asset for default contact avatars. 7 years ago
Matthew Chen 1c1d305a71 Respond to CR. 7 years ago
Matthew Chen 27488f078a Replace old "default profile avatar" icon with default avatar for local user. 7 years ago
Matthew Chen b5c5d1c3ef Use local avatar as app settings button. 7 years ago
Matthew Chen cbaf40d4ce Respond to CR. 7 years ago
Matthew Chen d161e5ff3d Add inner shadows to media thumbnails. 7 years ago
Matthew Chen 6715e3d1ad Respond to CR. 7 years ago
Matthew Chen b20cd57383 Rename OWSConversationColor. 7 years ago
Matthew Chen b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 7 years ago
Matthew Chen 26a2d568de Add "conversation color mode" enum. 7 years ago
Matthew Chen e5150267c2 Rework the conversation color constants. 7 years ago
Matthew Chen da63731447 Respond to CR. 7 years ago
Matthew Chen 8db4595bdc Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen 25d56b30c1 Rework group avatars to reflect conversation colors. 7 years ago
Michael Kirk c21020d7e7 Use received date for footer-collapse supression 7 years ago
Michael Kirk 6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
7 years ago
Michael Kirk 3240e0d9d0 Be explicit about receivedAt time
We were often using `timestampForLegacySorting`, which is convoluted for when
we actually just want received time.

In some sense this is a superficial change, but it's part of auditing that
we've completed moved away from timestampForLegacySorting.
7 years ago
Michael Kirk b281b37637 replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId
Update migration accordingly

Date shown on home view cell is message.receivedAt
7 years ago
Michael Kirk 1459fad01a sort media gallery by sortId 7 years ago
Michael Kirk 90aa593dcd sortId vs. Read status 7 years ago
Michael Kirk d6d6c4fca4 ConversationVC - lastSeenSortId 7 years ago
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
7 years ago
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 7 years ago
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
7 years ago
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
7 years ago
Michael Kirk ae668ceca9 include sequence number in fake messages 7 years ago
Matthew Chen 72562920ed Fix author conversation colors. 7 years ago
Michael Kirk 306c6ade71 "Bump build to 2.30.1.0." 7 years ago
Matthew Chen 4186ce9a72 Respond to CR. 7 years ago
Matthew Chen 7b2dd19fb8 Respond to CR. 7 years ago
Matthew Chen 8910f1f65a Enable conversation colors. 7 years ago
Matthew Chen ae84528dc3 Update avatar colors; add shaded conversation color constants, modify color picker to be color-name-based, not color-based, use shaded conversation colors, remove JSQ. 7 years ago
Matthew Chen a5628c4204 Rework layout of message status in home view. 7 years ago
Matthew Chen 0701d2465b Replace shadow with stroke. 7 years ago
Matthew Chen 8106158780 Move unread badge on home view; propose shadow. 7 years ago
Matthew Chen d13624897d Fix reminder changes in home view. 7 years ago
Matthew Chen 0eb13dd827 Fix nag reminder v. dark theme. 7 years ago
Matthew Chen b30bfec21f Fix contact offer button margins. 7 years ago
Matthew Chen 0b7d269017 Rename DebugContactsUtils. 7 years ago
Matthew Chen bcee59f5e5 Add contact utils class. 7 years ago
Matthew Chen 98630cca50 Respond to CR; add db utility methods to test base classes. 7 years ago
Matthew Chen 66fc389fba Get SSK tests building and running. 7 years ago
Matthew Chen 87836f506b Move more singletons to SSKEnvironment. 7 years ago
Matthew Chen b881bb467c Fix proto stream test. 7 years ago
Matthew Chen 8cf5f3e58f New grayscale palette. 7 years ago
Matthew Chen 29bb69032a DRY up the debounce of db extension version increment. 7 years ago
Matthew Chen 20de087441 Repair corrupt thread view. 7 years ago
Matthew Chen e8186a7005 Fix rebase breakage. Make environment properties mutable in tests. 7 years ago
Matthew Chen a7a05e9bbf Respond to CR. Rework how CallNotificationsAdapter adaptee is populated. 7 years ago
Matthew Chen e1db60c1c0 Rework creation of singletons. 7 years ago
Matthew Chen 0c6f6cdafd Fix compilation errors in Signal tests. 7 years ago
Matthew Chen b883209f91 Refine logging. 7 years ago
Michael Kirk 13856acb02 remove wrong import 7 years ago
Michael Kirk 966db1bd49 Get tests compiling by any means necessary
comment out and fail tests which don't compile
7 years ago
Michael Kirk fdc846cb55 remove test for deleted method 7 years ago
Michael Kirk 170eb63772 update old non-existant API usage 7 years ago
Michael Kirk 7a832e85ec remove wrong import 7 years ago
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Michael Kirk 2ffca98075 "Bump build to 2.29.3.3." 7 years ago
Matthew Chen 9b94580dae Update assertions.
* Streamline precompiled headers.
* Remove obsolete assertions in Constraints.h.
7 years ago
Matthew Chen 6c8af5b541 Update cocoapods. 7 years ago
Matthew Chen 62c55c9cfb Fix broken tests. 7 years ago
Michael Kirk 770c19ea06 sync translations 7 years ago
Michael Kirk 7b709666b9 "Bump build to 2.29.3.2." 7 years ago
Michael Kirk df67e883f3 BlockList vs. "zero length" group names 7 years ago
Michael Kirk b447e68597 clarify post-unblock-group copy 7 years ago
Michael Kirk 24ea8262d5 consolidate blocked-group state tracking 7 years ago
Michael Kirk 0f9b0936df Use cached group details when rendering blocklist 7 years ago
Michael Kirk 8d51839a2a sync translations 7 years ago
Michael Kirk 7b664ee21b update translation comment 7 years ago
Michael Kirk e53766d809 "Bump build to 2.29.3.1." 7 years ago
Michael Kirk b09831d8d0 copy updates 7 years ago
Michael Kirk fd492f379a Use BlockListCache where possible 7 years ago
Michael Kirk 2eca462efc can view conversation settings for left group 7 years ago
Michael Kirk 2c49232db0 remove barely used getters
Lock contention on these methods is less important because we're not iterating
over their access, e.g. per tableViewCell
7 years ago
Michael Kirk 448936d156 BlockListCache
block manager synchronizes on self for coherent read/writes to blocking state
across threads, but we want to be able to have performant reads on the main
thread.
7 years ago
Michael Kirk 28d28cf2b6 remove unused code 7 years ago
Michael Kirk b6eb1476cb Leave group when blocking it 7 years ago
Michael Kirk 13cf9eab31 copy fixups 7 years ago
Michael Kirk 8aba5725cf BlockListViewController v. group blocking 7 years ago
Michael Kirk 809b3766c1 Home view cell v. group blocking 7 years ago
Michael Kirk c6de8c579c WIP: Localizations 7 years ago
Michael Kirk b1da5e93d9 group blocking v. conversation view 7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Michael Kirk b282d51da0 SyncMessages for blocked groups 7 years ago
Michael Kirk 236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Matthew Chen 3935b019f4 Add base class for tests. 7 years ago
Matthew Chen 3fe7d7f9be Remove more usage of logTag. 7 years ago
Michael Kirk 99b2564994 "Bump build to 2.29.3.0." 7 years ago
Michael Kirk 17da53257f "Bump build to 2.29.2.4." 7 years ago
Matthew Chen df7acfeed3 Simplify OWSPreferences access. 7 years ago
Matthew Chen cc117b385c Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen bd05cdc031 Rename TextSecureKitEnv to SSKEnvironment. 7 years ago
Matthew Chen b642a5fabe Update log. 7 years ago
Matthew Chen bcceda1861 Respond to CR. 7 years ago
Matthew Chen cfb511aa57 Respond to CR. 7 years ago
Matthew Chen eb616a3411 Respond to CR. 7 years ago
Matthew Chen 399dd13cee Add test app context; use mock "document" and "shared data container" directories in tests, use mock keychain storage in tests. 7 years ago
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 7 years ago
Michael Kirk 01a6a3d98e avoid overflow in debug logging 7 years ago
Michael Kirk 503cb046e4 remove unused FunctionalUtil code 7 years ago
Michael Kirk 48a85aab1b remove unused files
These were ported to SignalMessaging
7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen 654c98d805 "Bump build to 2.29.2.3." 7 years ago
Matthew Chen 1c325cd210 Respond to CR. 7 years ago
Matthew Chen b1f2b9e75c Clean up thumbnail-related logic. 7 years ago
Matthew Chen dc3467dcda Tidy up attachment usage. 7 years ago
Matthew Chen 0be12da3dd Use thumbnails in media views. 7 years ago
Matthew Chen 5d96af98bc Use large thumbnail in media views. 7 years ago
Matthew Chen 30ed6caf06 Use thumbnails as video stills in conversation view. 7 years ago
Matthew Chen a2fad57964 Load GIFs from disk in media view; don't cache GIF data in memory. 7 years ago
Matthew Chen 12307aeeed Load GIFs from disk in media view; don't cache GIF data in memory. 7 years ago
Matthew Chen ad0d094831 Fix build breakage. 7 years ago
Matthew Chen 748b243156 Restore full-screen thumbnails. 7 years ago
Matthew Chen 8748dc9b2e Modify new thumbnail system to include video and GIF thumbnails. 7 years ago
Matthew Chen 206432fdf0 Add failure methods to thumbnail service. 7 years ago
Matthew Chen cf469da943 Use new thumbnails in conversation cells. 7 years ago
Matthew Chen 3437361d70 Use new thumbnails in media gallery thumbnails. 7 years ago
Matthew Chen 446ceb2b9c Rename AttachmentStream methods. 7 years ago
Matthew Chen 498828f93c Rename AttachmentStream methods. 7 years ago
Michael Kirk 17f1ba3b9e "Bump build to 2.29.2.2." 7 years ago
Michael Kirk a92be0811b "Bump build to 2.29.2.1." 7 years ago
Matthew Chen 44a3a81469 Update logging and asserts in hotfix changes. 7 years ago
Matthew Chen 9ab4da5c81 cherry-pick Merge branch 'charlesmchen/logSdp' 7 years ago
Michael Kirk d57c2f5157 enable sw decoders 7 years ago
Michael Kirk c0b9639aac "Bump build to 2.29.2.0." 7 years ago
Michael Kirk 5d9cd86d13 size toolbar WRT draft 7 years ago
Matthew Chen fac7f6932f Rename TSGroupMetaMessage enum values. 7 years ago
Matthew Chen f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 7 years ago
Michael Kirk d37827de1d "Bump build to 2.29.2.1." 7 years ago
Michael Kirk c81e0a58be "Bump build to 2.29.2.0." 7 years ago
Michael Kirk 055fe76c91 "Bump build to 2.29.1.1." 7 years ago
Michael Kirk 2cdca0299c show generic file icon for invalid GIF 7 years ago
Michael Kirk d1dead0580 sync translations 7 years ago
Michael Kirk c709fe220c "Bump build to 2.29.1.0." 7 years ago
Michael Kirk e715bf9ea2 image sizing
Validate image sizing
7 years ago
Matthew Chen 7df8976559 Fix breakage in production builds. 7 years ago
Matthew Chen 1cc0fbcb12 Elaborate logging around 'perform updates' crash. 7 years ago
Matthew Chen 9477606732 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen f473f60111 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 03829779cc Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 0b5b74a901 Respond to CR. 7 years ago
Matthew Chen 490ac5dd76 Redact ice-pwd from SDP. 7 years ago
Matthew Chen 02daca11af Redact ice-pwd from SDP. 7 years ago
Matthew Chen 2d06c05a4f Log call session description. 7 years ago
Matthew Chen 329f8d6f45 Log call session description. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Matthew Chen d4f7b5d45b Respond to CR. 7 years ago
Matthew Chen f34bdd34bc Respond to CR. 7 years ago
Matthew Chen e1049fdfcc Respond to CR. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Michael Kirk 1d2590fa12 Merge tag '2.29.0.17' 7 years ago
Michael Kirk 65c323440b update translation location 7 years ago
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
7 years ago
Michael Kirk 464b854eb1 CR: follow naming conventions 7 years ago
Michael Kirk 9c9f3875a7 Link styling 7 years ago
Michael Kirk 5148747c12 clean up long text VC 7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Michael Kirk 781c535327 weak capture self 7 years ago
Michael Kirk fc7dc03cee don't block main thread during search
// FREEBIE
7 years ago
Michael Kirk 2fc3a211f1 restrict debug methods 7 years ago
Matthew Chen b75bc27d55 Respond to CR. 7 years ago
Matthew Chen c6132249e6 Respond to CR. 7 years ago
Matthew Chen cb827169fb Respond to CR. 7 years ago
Matthew Chen 2c8cec183c "Bump build to 2.29.0.17." 7 years ago
Michael Kirk eaf8d789fb Darken message actions overlay in dark theme 7 years ago
Michael Kirk e4b7d253a3 Theme "no results" cell 7 years ago
Michael Kirk 3022f92925 Tweak tint for search bar icons in dark theme 7 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
7 years ago
Matthew Chen bc7efaf4ad "Bump build to 2.29.0.16." 7 years ago
Matthew Chen 10ab97bb6c "Bump build to 2.29.0.15." 7 years ago
Michael Kirk 32f8795342 media tile toolbar respects theme by using UIAppearance defaults 7 years ago
Michael Kirk 93cb378f7a constantize toast inset 7 years ago
Michael Kirk 06a8bffa66 Never show more than one toast view 7 years ago
Michael Kirk 75ead2ac09 quoted reply: distinguish "not found" vs. "no longer available" 7 years ago
Matthew Chen fb9958b1da "Bump build to 2.29.0.14." 7 years ago
Michael Kirk c6f77ec6ea "Tap to retry" retries, rather than maybe deletes.
Attachment downloads can fail on slow networks or if the app crashes.
It's unlikely that the users response to this would be to delete the
attachment pointer, so it doesn't make sense to surface that as a
primary action.

If a user does want to delete the attachment, as always they can
long-press to delete.

// FREEBIE
7 years ago
Michael Kirk 8cd290ba2b fix section headers not appearing on iOS11/iPhoneX
// FREEBIE
7 years ago
Michael Kirk 92de745528 theme gallery section headers
// FREEBIE
7 years ago
Michael Kirk c1df969a22 remove overzealous assert
// FREEBIE
7 years ago
Matthew Chen 7020798e3f "Bump build to 2.29.0.13." 7 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 7 years ago
Matthew Chen 6e4414f477 "Bump build to 2.29.0.12." 7 years ago
Matthew Chen decb0c54ca Theme review. 7 years ago
Matthew Chen d62e07d6f1 Theme review. 7 years ago
Matthew Chen 4ea5d9b849 Theme review. 7 years ago
Matthew Chen b4b4cd61d9 Improve message timestamp formatting. 7 years ago
Matthew Chen be7482eb60 Tap to copy sender timestamp to clipboard. 7 years ago
Matthew Chen f89fa8359b Revert "Add logging around 'SAE to same thread' crash."
This reverts commit eee2f7c8c6.
7 years ago
Matthew Chen e3378dec65 Revert "Add logging around 'share from SAE to same conversation' crash."
This reverts commit f62bf7d18e.
7 years ago
Matthew Chen 87d51aaa82 "Bump build to 2.29.0.11." 7 years ago
Matthew Chen f62bf7d18e Add logging around 'share from SAE to same conversation' crash. 7 years ago
Matthew Chen a712a20da0 "Bump build to 2.29.0.10." 7 years ago
Matthew Chen eee2f7c8c6 Add logging around 'SAE to same thread' crash. 7 years ago
Matthew Chen b347c40c66 Clean up ahead of PR. 7 years ago
Matthew Chen d9d73ba70c "Bump build to 2.29.0.9." 7 years ago
Matthew Chen 0a7b3537b5 Recreate message database view when message mappings are corrupt. 7 years ago
Matthew Chen 1e75b6518b "Bump build to 2.29.0.8." 7 years ago
Matthew Chen db2f5bf3b0 Add temporary logging around conversation view crashes. 7 years ago
Matthew Chen 30ce675236 "Bump build to 2.29.0.7." 7 years ago
Matthew Chen 420f5f88ff Add logging, error checking and recovery around corrupt message mappings. 7 years ago
Matthew Chen f261a47bd3 Hide home view search by default. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Matthew Chen 22dda476bb Fix QA issues in theme. 7 years ago