Redact ice-pwd from SDP.

pull/1/head
Matthew Chen 7 years ago
parent b4539328e1
commit 02daca11af

@ -407,7 +407,7 @@ private class SignalCallData: NSObject {
throw CallError.obsoleteCall(description: "Missing peerConnectionClient")
}
Logger.info("session description for outgoing call: \(call.identifiersForLogs), sdp: \(sessionDescription.sdp).")
Logger.info("session description for outgoing call: \(call.identifiersForLogs), sdp: \(sessionDescription.logSafeDescription).")
return peerConnectionClient.setLocalSessionDescription(sessionDescription).then {
do {
@ -714,7 +714,7 @@ private class SignalCallData: NSObject {
throw CallError.obsoleteCall(description: "negotiateSessionDescription() response for obsolete call")
}
Logger.info("session description for incoming call: \(newCall.identifiersForLogs), sdp: \(negotiatedSessionDescription.sdp).")
Logger.info("session description for incoming call: \(newCall.identifiersForLogs), sdp: \(negotiatedSessionDescription.logSafeDescription).")
do {
let answerBuilder = SSKProtoCallMessageAnswer.SSKProtoCallMessageAnswerBuilder(id: newCall.signalingId,

@ -1109,6 +1109,21 @@ class HardenedRTCSessionDescription {
return RTCSessionDescription.init(type: rtcSessionDescription.type, sdp: description)
}
var logSafeDescription: String {
var text = sdp
text = text.replacingOccurrences(of: "\r", with: "\n")
text = text.replacingOccurrences(of: "\n\n", with: "\n")
let lines = text.components(separatedBy: "\n")
let filteredLines: [String] = lines.map { line in
guard !line.contains("ice-pwd") else {
return "[ REDACTED ice-pwd ]"
}
return line
}
let filteredText = filteredLines.joined(separator: "\n")
return filteredText
}
}
protocol VideoCaptureSettingsDelegate: class {

Loading…
Cancel
Save