remove barely used getters

Lock contention on these methods is less important because we're not iterating
over their access, e.g. per tableViewCell

Signal/src/ViewControllers/AppSettings/BlockListViewController.m

@@ -30,6 +30,11 @@ NS_ASSUME_NONNULL_BEGIN
 
 @implementation BlockListViewController
 
+- (OWSBlockingManager *)blockingManager
+{
+    return OWSBlockingManager.sharedManager;
+}
+
 - (void)loadView
 {
     [super loadView];
@@ -77,7 +82,7 @@ NS_ASSUME_NONNULL_BEGIN
     // "Blocklist" section
 
     NSArray<NSString *> *blockedPhoneNumbers =
-        [helper.blockedPhoneNumbers sortedArrayUsingSelector:@selector(compare:)];
+        [self.blockingManager.blockedPhoneNumbers sortedArrayUsingSelector:@selector(compare:)];
 
     if (blockedPhoneNumbers.count > 0) {
         OWSTableSection *blockedContactsSection = [OWSTableSection new];
@@ -104,7 +109,7 @@ NS_ASSUME_NONNULL_BEGIN
         [contents addSection:blockedContactsSection];
     }
 
-    NSArray<NSData *> *blockedGroupIds = helper.blockedGroupIds;
+    NSArray<NSData *> *blockedGroupIds = self.blockingManager.blockedGroupIds;
     if (blockedGroupIds.count > 0) {
         OWSTableSection *blockedGroupsSection = [OWSTableSection new];
         blockedGroupsSection.headerTitle = NSLocalizedString(

SignalMessaging/Views/ContactsViewHelper.h

@@ -46,9 +46,6 @@ NS_ASSUME_NONNULL_BEGIN
 // Useful to differentiate between having no signal accounts vs. haven't checked yet
 @property (nonatomic, readonly) BOOL hasUpdatedContactsAtLeastOnce;
 
-@property (nonatomic, readonly) NSArray<NSString *> *blockedPhoneNumbers;
-@property (nonatomic, readonly) NSArray<NSData *> *blockedGroupIds;
-
 // Suitable when the user tries to perform an action which is not possible due to the user having
 // previously denied contact access.
 - (void)presentMissingContactAccessAlertControllerFromViewController:(UIViewController *)viewController;
@@ -60,7 +57,6 @@ NS_ASSUME_NONNULL_BEGIN
 - (nullable SignalAccount *)fetchSignalAccountForRecipientId:(NSString *)recipientId;
 - (SignalAccount *)fetchOrBuildSignalAccountForRecipientId:(NSString *)recipientId;
 
-// MJK TODO Can we remove?
 // This method is faster than OWSBlockingManager but
 // is only safe to be called on the main thread.
 - (BOOL)isRecipientIdBlocked:(NSString *)recipientId;