Respond to CR.

Signal/src/util/MainAppContext.m

@@ -283,9 +283,9 @@ NS_ASSUME_NONNULL_BEGIN
     backgroundTask = nil;
 }
 
-- (id<KeychainStorage>)keychainStorage
+- (id<SSKKeychainStorage>)keychainStorage
 {
-    return [SSKKeychainStorage shared];
+    return [SSKDefaultKeychainStorage shared];
 }
 
 - (NSString *)appDocumentDirectoryPath

SignalServiceKit/src/Storage/KeychainStorage.swift

@@ -11,7 +11,7 @@ public enum KeychainStorageError: Error {
 
 // MARK: -
 
-@objc public protocol KeychainStorage: class {
+@objc public protocol SSKKeychainStorage: class {
 
     @objc func string(forService service: String, key: String) throws -> String
 
@@ -27,9 +27,9 @@ public enum KeychainStorageError: Error {
 // MARK: -
 
 @objc
-public class SSKKeychainStorage: NSObject, KeychainStorage {
+public class SSKDefaultKeychainStorage: NSObject, SSKKeychainStorage {
 
-    @objc public static let shared = SSKKeychainStorage()
+    @objc public static let shared = SSKDefaultKeychainStorage()
 
     // Force usage as a singleton
     override private init() {

SignalServiceKit/src/Storage/TestKeychainStorage.swift

@@ -5,7 +5,7 @@
 import Foundation
 
 @objc
-public class TestKeychainStorage: NSObject, KeychainStorage {
+public class SSKTestKeychainStorage: NSObject, SSKKeychainStorage {
 
     private var dataMap = [String: Data]()
 

SignalServiceKit/src/Tests/TestAppContext.m

@@ -9,7 +9,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 @interface TestAppContext ()
 
-@property (nonatomic) TestKeychainStorage *testKeychainStorage;
+@property (nonatomic) SSKTestKeychainStorage *testKeychainStorage;
 @property (nonatomic) NSString *mockAppDocumentDirectoryPath;
 @property (nonatomic) NSString *mockAppSharedDataDirectoryPath;
 
@@ -29,7 +29,7 @@ NS_ASSUME_NONNULL_BEGIN
         return self;
     }
 
-    self.testKeychainStorage = [TestKeychainStorage new];
+    self.testKeychainStorage = [SSKTestKeychainStorage new];
 
     NSString *temporaryDirectory = NSTemporaryDirectory();
     self.mockAppDocumentDirectoryPath = [temporaryDirectory stringByAppendingPathComponent:NSUUID.UUID.UUIDString];
@@ -133,7 +133,7 @@ NS_ASSUME_NONNULL_BEGIN
 {
 }
 
-- (id<KeychainStorage>)keychainStorage
+- (id<SSKKeychainStorage>)keychainStorage
 {
     return self.testKeychainStorage;
 }

SignalServiceKit/src/Util/AppContext.h

@@ -22,7 +22,7 @@ NSString *NSStringForUIApplicationState(UIApplicationState value);
 
 @class OWSAES256Key;
 
-@protocol KeychainStorage;
+@protocol SSKKeychainStorage;
 
 @protocol AppContext <NSObject>
 
@@ -98,7 +98,7 @@ NSString *NSStringForUIApplicationState(UIApplicationState value);
 
 @property (atomic, readonly) NSDate *appLaunchTime;
 
-- (id<KeychainStorage>)keychainStorage;
+- (id<SSKKeychainStorage>)keychainStorage;
 
 - (NSString *)appDocumentDirectoryPath;
 

SignalShareExtension/utils/ShareAppExtensionContext.m

@@ -214,9 +214,9 @@ NS_ASSUME_NONNULL_BEGIN
     OWSFailDebug(@"cannot run main app active blocks in share extension.");
 }
 
-- (id<KeychainStorage>)keychainStorage
+- (id<SSKKeychainStorage>)keychainStorage
 {
-    return [SSKKeychainStorage shared];
+    return [SSKDefaultKeychainStorage shared];
 }
 
 - (NSString *)appDocumentDirectoryPath