Commit Graph

6072 Commits (db410becb7f1eafab53465d177715bcdb2d75c16)

Author SHA1 Message Date
Michael Kirk a8caae73cf remove redundant state 7 years ago
Michael Kirk fa2d5b422b maintain body text navigating to/from approval view 7 years ago
Michael Kirk 0a32448470 cancel flow per design 7 years ago
Michael Kirk 1a4062dd89 Nav buttons: batch, camera/library switch, done 7 years ago
Michael Kirk 7dbb9517af Centralize attachment state in nav controller 7 years ago
Michael Kirk 6502d7d4a5 remove `isMultiSendEnabled` feature flag 7 years ago
Matthew Chen 987726df6c Temp files. 7 years ago
Matthew Chen bb1921afe6 Simplify link preview cache. 7 years ago
Matthew Chen 04b60677a6 Simplify link preview cache. 7 years ago
Matthew Chen ae5cee2167 Clean up the link preview cache. 7 years ago
Matthew Chen 0d9b780f75 Remove scroll up button. 7 years ago
Michael Kirk 3ed2e76eb4 "Bump build to 2.38.0.9." 7 years ago
Michael Kirk d02152cf14 fix release build 7 years ago
Michael Kirk dc87ae821d "Bump build to 2.38.0.8." 7 years ago
Michael Kirk ab91fedc3e sync translations 7 years ago
Michael Kirk 58d99a480f Notify iOS9 users occasionally that iOS10 will soon be required 7 years ago
Matthew Chen 3ce3f9faaa Add accessibilityIdentifiers to conversation settings view. 7 years ago
Matthew Chen f073dd9a52 Add accessibilityIdentifiers to conversation settings view. 7 years ago
Matthew Chen d253c5aa91 Add accessibilityIdentifiers to conversation view. 7 years ago
Matthew Chen 50888b20d2 Add accessibilityIdentifiers to 'new group thread' view. 7 years ago
Matthew Chen 4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 7 years ago
Matthew Chen 95e125d55e Simplify usage of accessibilityIdentifiers. 7 years ago
Matthew Chen 2d854406a1 Add accessibilityIdentifiers to home view. 7 years ago
Michael Kirk 2464fe230d sync translations 7 years ago
Michael Kirk ed6b461662 search icon 7 years ago
Michael Kirk c37fb42c7a "Bump build to 2.38.0.7." 7 years ago
Matthew Chen a6e00c8fec Respond to CR. 7 years ago
Matthew Chen a7ae79aaad Ignore keyboard notifications while the view is disappearing or has disappeared. 7 years ago
Matthew Chen 8c345d0878 "Bump build to 2.38.0.6." 7 years ago
Matthew Chen 85d58d3396 Improve handling of call intents. 7 years ago
Michael Kirk e3cc8bb101 Keep results bar visible when dismissing keyboard or returning to view. 7 years ago
Michael Kirk 3850ca29b0 Bigger hack to fix problem with lesser hack.
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
7 years ago
Matthew Chen 1b9eb3c572 Ensure Callkit is enabled for locale. 7 years ago
Matthew Chen 40c9c196aa Fix memory leaks. 7 years ago
Matthew Chen 882dd16d7c Apply presentAlert() throughout codebase. 7 years ago
Matthew Chen c9d62f47cc Respond to CR. 7 years ago
Matthew Chen 1a80f0c293 Add accessibility identifiers to privacy popups and subviews. 7 years ago
Matthew Chen cb5ce42e76 Add accessibility identifiers to privacy popups and subviews. 7 years ago
Matthew Chen f37a3059fa Add accessibility identifiers to debug log popups. 7 years ago
Matthew Chen 81508e9d02 Add accessibility identifiers to settings popups. 7 years ago
Matthew Chen f1520d760e Add accessibility identifiers to other settings views. 7 years ago
Matthew Chen b48e204b90 Add accessibility identifiers to notification settings views. 7 years ago
Matthew Chen 02340864f8 Add accessibility identifiers to blocklist view. 7 years ago
Matthew Chen f7d86028da Add accessibility identifiers to profile view. 7 years ago
Matthew Chen c619f815b5 Add accessibility identifiers to app settings view. 7 years ago
Matthew Chen 6ee4317590 Add "track" to attachment download progress indicator. 7 years ago
Matthew Chen c2c08d0712 Remove overzealous valid media asserts. 7 years ago
Matthew Chen 31b4612746 Rework attachment download progress for generic attachments. 7 years ago
Matthew Chen 5df4a0bc17 Rework attachment download progress for audio files. 7 years ago
Michael Kirk 93c9c83ac5 Haptic feedback when remote enables video 7 years ago
Michael Kirk 179dec299f Show hint when other party enables video 7 years ago
Michael Kirk 6ccd73837c rename haptic classes, no change in functionality 7 years ago
Michael Kirk 7d72244315 autogenstrings 7 years ago
Michael Kirk 96dda0cacf "Bump build to 2.38.0.5." 7 years ago
Matthew Chen 9fe3aa06ed Respond to CR. 7 years ago
Matthew Chen 6ab8ea9b6e Respond to CR. 7 years ago
Matthew Chen a8e9b87f03 Rework menu actions focus item layout. 7 years ago
Matthew Chen 4f06e6dd6e Conversation view always observes view model. 7 years ago
Michael Kirk 0b638f4831 link checks 7 years ago
Michael Kirk 134cade52c fix longtext layout: though text content should be inset from the edges, the
scrollbar should abut the edge of the screen.
7 years ago
Michael Kirk 78ce3583ed fix rotation issue 7 years ago
Matthew Chen 6cc28bdf8f Redraw message bubbles when corner state changes. 7 years ago
Matthew Chen e66b45f6ce Fix spurious 'now' labels in date formatting. 7 years ago
Matthew Chen df4cf5c09e Respond to CR. 7 years ago
Matthew Chen b6724ee181 Clean up ahead of PR. 7 years ago
Matthew Chen 936aa5842d Clean up ahead of PR. 7 years ago
Matthew Chen 4bfa251321 Ensure constant bubble sizes for oversize text. 7 years ago
Matthew Chen 67c89cb4e3 Ensure constant bubble sizes for oversize text. 7 years ago
Matthew Chen dc168270c2 Ensure constant bubble sizes for generic attachments. 7 years ago
Matthew Chen 3702dfa198 Rework "upload progress", "download progress" and "tap to retry" states. 7 years ago
Matthew Chen d1447d0730 Ensure constant bubble sizes for audio media. 7 years ago
Matthew Chen 14e7274c3d Ensure constant bubble sizes for visual media. 7 years ago
Matthew Chen c180d20dcd Store media size from attachment pointer protos. 7 years ago
Matthew Chen 991974ee35 Add accessibility identifiers in the onboarding views. 7 years ago
Matthew Chen 79d6384bc9 Add accessibility identifiers to privacy settings view. 7 years ago
Matthew Chen 99cd3f9b26 Use accessibility identifier macros in UIUtil.h. 7 years ago
Nancy Mast 189bbb9f16 added accessibility ids to HomeViewController and ProfileViewController 7 years ago
Matthew Chen d76fac1096 Add accessibility identifiers in the onboarding views. 7 years ago
Matthew Chen c37f425d5f Reduce logging. 7 years ago
Matthew Chen 6c6e516a3a "Bump build to 2.38.0.4." 7 years ago
Michael Kirk 89dce94986 "Bump build to 2.38.0.3." 7 years ago
Michael Kirk 9d5d120e69 recording button design changes 7 years ago
Michael Kirk d26c47ceba grow button as recording starts 7 years ago
Matthew Chen 3b008ad963 Fix conversation view content offset and scroll down button layout. 7 years ago
Michael Kirk 284357137f Photo/Movie Capture 7 years ago
Michael Kirk 95b11ddf8c Merge tag '2.37.2.0' 7 years ago
Matthew Chen b7d3a99f39 Update "crop lock" assets. 7 years ago
Matthew Chen d80f086f31 Rework attachment captioning. 7 years ago
Michael Kirk 256d308e30 pull latest translations 7 years ago
Michael Kirk a342660943 fix "none" notification tone 7 years ago
Michael Kirk d5664dae4b Change to non-crashing assert 7 years ago
Michael Kirk 72ab6507ea fix crash when presenting alerts on iOS9 7 years ago
Michael Kirk 6d6d1de782 "Bump build to 2.37.2.0." 7 years ago
Michael Kirk 268dd33e7d Change to non-crashing assert 7 years ago
Matthew Chen 745ec2adb8 Remove top gradient from attachment approval. 7 years ago
Matthew Chen 66efcb4639 Update rail icons. 7 years ago
Matthew Chen 7521b3a145 Update "attachment has caption" indicator. 7 years ago
Matthew Chen cea361705e Update asset for "add more images to album" button. 7 years ago
Matthew Chen 7a67a7b6b5 Hide the status bar in the image picker / attachment approval. 7 years ago
Matthew Chen 6e492927d1 Prevent users from selecting additional images while processing images in the image picker. 7 years ago