Commit Graph

1574 Commits (823ce7cb6b5f883ab1a597cdc2c77c0699e2f082)

Author SHA1 Message Date
Michael Kirk da79a53d96 cleanup compiler warnings 6 years ago
Michael Kirk fa45339f83 move to public category 6 years ago
Michael Kirk cfebb53719 more concise constants post translation 6 years ago
Michael Kirk 57b1aaa3dc inline enum converters 6 years ago
Michael Kirk 30266bf65e autoformatted 6 years ago
Michael Kirk 64a0c4bfaa auto-migrate to Swift5 6 years ago
Michael Kirk 501e2c761f Merge tag '2.38.1.2' 6 years ago
Michael Kirk 1fae83a777 respect any CDN headers (eg Host for front) 6 years ago
Michael Kirk 07e88009e4 Merge tag '2.38.0.11' 6 years ago
Matthew Chen a3efb58d15 Respond to CR. 6 years ago
Matthew Chen 517a550593 Further improve "first responder" behavior in the image editor. 6 years ago
Matthew Chen eb5cf3978c Fix first responder issue in image editor. 6 years ago
Michael Kirk fa2d5b422b maintain body text navigating to/from approval view 6 years ago
Michael Kirk 1a4062dd89 Nav buttons: batch, camera/library switch, done 6 years ago
Michael Kirk 7dbb9517af Centralize attachment state in nav controller 6 years ago
Michael Kirk 6502d7d4a5 remove `isMultiSendEnabled` feature flag 6 years ago
Michael Kirk 1357449dcc Make OrderedDictionary keys generic 6 years ago
Matthew Chen db958f4a01 Preserve caption text of edited images. 6 years ago
Matthew Chen d9760b6bbc Fix bug around layer ordering when rendering image editor output. 6 years ago
Matthew Chen 5973c326de Ensure new text items are on the canvas. 6 years ago
Michael Kirk f8244eeefe Fix SAE crash for iOS9 6 years ago
Michael Kirk 58d99a480f Notify iOS9 users occasionally that iOS10 will soon be required 6 years ago
Matthew Chen 3ce3f9faaa Add accessibilityIdentifiers to conversation settings view. 6 years ago
Matthew Chen f073dd9a52 Add accessibilityIdentifiers to conversation settings view. 6 years ago
Matthew Chen 4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 6 years ago
Matthew Chen 95e125d55e Simplify usage of accessibilityIdentifiers. 6 years ago
Matthew Chen 2d854406a1 Add accessibilityIdentifiers to home view. 6 years ago
Michael Kirk ed6b461662 search icon 6 years ago
Matthew Chen a7ae79aaad Ignore keyboard notifications while the view is disappearing or has disappeared. 6 years ago
Matthew Chen 558b5f5816 Tap to dismiss caption editor. 6 years ago
Matthew Chen 4ea608cd45 Ensure status bar is hidden in image editor subviews. 6 years ago
Michael Kirk e3cc8bb101 Keep results bar visible when dismissing keyboard or returning to view. 6 years ago
Michael Kirk 3850ca29b0 Bigger hack to fix problem with lesser hack.
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
6 years ago
Matthew Chen 908fe1d0c9 Apply presentAlert() throughout codebase. 6 years ago
Matthew Chen 882dd16d7c Apply presentAlert() throughout codebase. 6 years ago
Matthew Chen c9d62f47cc Respond to CR. 6 years ago
Matthew Chen 1a80f0c293 Add accessibility identifiers to privacy popups and subviews. 6 years ago
Matthew Chen cb5ce42e76 Add accessibility identifiers to privacy popups and subviews. 6 years ago
Matthew Chen f37a3059fa Add accessibility identifiers to debug log popups. 6 years ago
Matthew Chen 81508e9d02 Add accessibility identifiers to settings popups. 6 years ago
Matthew Chen d7b1e65a71 Add accessibility identifiers to blocklist popups. 6 years ago
Matthew Chen f1520d760e Add accessibility identifiers to other settings views. 6 years ago
Matthew Chen b48e204b90 Add accessibility identifiers to notification settings views. 6 years ago
Matthew Chen 931d249677 Modify OWSFlatButton to propagate the accessibility identifier to wrapper button. 6 years ago
Matthew Chen 41a3c95831 Add missing accessibility ids in block list view. 6 years ago
Matthew Chen 8bcc19e36c Add missing accessibility ids in block list view. 6 years ago
Matthew Chen 52d6aa69b8 Improve measurement of image editor text layers. 6 years ago
Michael Kirk 0b638f4831 link checks 6 years ago
Michael Kirk 78ce3583ed fix rotation issue 6 years ago
Matthew Chen 050a9676f6 Add accessibility identifiers to select recipient views. 6 years ago
Matthew Chen c3857e5dff Add accessibility identifiers to select recipient views. 6 years ago
Matthew Chen 79d6384bc9 Add accessibility identifiers to privacy settings view. 6 years ago
Matthew Chen c37f425d5f Reduce logging. 6 years ago
Matthew Chen 3795fd1381 Enable image editor in production. 6 years ago
Matthew Chen 441c784146 Add preview view to the color palette control. 6 years ago
Michael Kirk 284357137f Photo/Movie Capture 6 years ago
Matthew Chen 684cebf2df Respond to CR. 6 years ago
Matthew Chen a48c3d8d20 Ensure attachment approval becomes first responder if app returns from background. 6 years ago
Matthew Chen f9445359d9 Fix layout glitch related to attachment approval input accessory background. 6 years ago
Matthew Chen a559b61056 Fix keyboard return behavior in attachment approval. 6 years ago
Matthew Chen 660f35147f Hide status bar in image editor modals. 6 years ago
Matthew Chen 25e7818f56 Ensure proper z-ordering of item layers. 6 years ago
Matthew Chen d824c49c07 Respond to CR. 6 years ago
Matthew Chen d80f086f31 Rework attachment captioning. 6 years ago
Matthew Chen 625656deb9 Pull out attachment text toolbar and text view classes. 6 years ago
Matthew Chen 581d0a7bff Respond to CR. 6 years ago
Matthew Chen 4fd16a7614 Remove top gradient from attachment approval. 6 years ago
Matthew Chen 745ec2adb8 Remove top gradient from attachment approval. 6 years ago
Matthew Chen 0826864525 Decompose attachment approval into multiple source files. 6 years ago
Matthew Chen c315c1c9ef Fix translation normalization of the image editor transform. 6 years ago
Matthew Chen 88c07fc534 Pinch to change text size in image editor text tool. 6 years ago
Matthew Chen d6c91c2753 Respond to CR. 6 years ago
Matthew Chen fedbe3a5d0 Fix shadow on palette view. 6 years ago
Matthew Chen 75cfd979ba Modify brush stroke width to reflect current scale. 6 years ago
Matthew Chen c0ca55b1e0 Fix shadow on palette view. 6 years ago
Matthew Chen 337e32a909 Fix a shadow. 6 years ago
Matthew Chen 66efcb4639 Update rail icons. 6 years ago
Matthew Chen 2f7880af8e Fix hit testing of text layers. 6 years ago
Matthew Chen 7521b3a145 Update "attachment has caption" indicator. 6 years ago
Matthew Chen dd16986d79 Avoid layout changes due to selection changes in media rail. 6 years ago
Matthew Chen e63b1169a3 Hide controls while moving text items. 6 years ago
Matthew Chen 9e636b0fc9 Hide controls during stroke. 6 years ago
Matthew Chen c77835926d Tap to create new text item. 6 years ago
Matthew Chen fb6631df5f Remove cancel button from attachment caption view. 6 years ago
Matthew Chen 5aaa667927 Modify the image editor's crop tool to render the cropped and uncropped content. 6 years ago
Matthew Chen 0a6ad365d4 Refine the image editor crop tool's gestures. 6 years ago
Matthew Chen e9a4ae7add Fix image editor navigation bar button shadows. 6 years ago
Matthew Chen eff929dd1a Add border and shadow to image editor's palette view. 6 years ago
Matthew Chen 6f44167e5c Tweak navigation bar button spacing. 6 years ago
Matthew Chen e2d54d082e Modify attachment approval back button to not have "back" text. 6 years ago
Matthew Chen 7a67a7b6b5 Hide the status bar in the image picker / attachment approval. 6 years ago
Matthew Chen ff08919206 Respond to CR. 6 years ago
Matthew Chen 6fe3ce6d87 Deconflict "bottom view" layout and keyboard animations. 6 years ago
Matthew Chen 6e7c135348 Ensure onboarding views never reclaim layout space from dismissed keyboard. 6 years ago
Matthew Chen d72c26796d Ensure onboarding views never reclaim layout space from dismissed keyboard. 6 years ago
Matthew Chen 53802d1a48 Deconflict "bottom view" layout and keyboard animations. 6 years ago
Matthew Chen 97603e64cc Deconflict "bottom view" layout and keyboard animations. 6 years ago
Michael Kirk be523d5fe9 Merge branch 'release/2.37.0' 6 years ago
Matthew Chen 6cae61bf18 Revert "Temporarily enable image editor."
This reverts commit 1078756bc6.
6 years ago
Matthew Chen 49685c52bb Temporarily enable image editor. 6 years ago
Matthew Chen 3209ce6cd9 Normalize images in the image editor. 6 years ago
Matthew Chen 22626bdffd Revert "Temporarily enable image editor."
This reverts commit 1078756bc6.
6 years ago
Matthew Chen 1078756bc6 Temporarily enable image editor. 6 years ago
Matthew Chen 6052ce477a Revert "Temporarily enable image editor."
This reverts commit 66c0419131.
6 years ago
Matthew Chen 66c0419131 Temporarily enable image editor. 6 years ago
Matthew Chen ddbef4e311 Respond to CR. 6 years ago
Matthew Chen c31d469651 Improve new text item continuity. 6 years ago
Matthew Chen 371c12bd40 Show caption indicators in attachment approval media rail. 6 years ago
Matthew Chen 80d297c10a Render strokes behind text. 6 years ago
Matthew Chen 871dceac3a Improve palette interactions. 6 years ago
Matthew Chen 1a159d4d70 Clean up brush stroke gesture usage. 6 years ago
Matthew Chen 3d96cd488e Improve color continuity in the image editor. 6 years ago
Matthew Chen 93cb0e3a10 Fix bar button layout on iOS 9. 6 years ago
Matthew Chen 65ead451c0 Don't enable undo in stroke view for items created before stroke view. 6 years ago
Matthew Chen 9be84fc912 Respond to CR. 6 years ago
Matthew Chen 919e886eb7 Ensure brush strokes include the entire gesture. 6 years ago
Matthew Chen 65ee1dbd75 Hide the current text item while the text item editor is open. 6 years ago
Matthew Chen d15f5b581f Tweak how image editor overlays are presented. 6 years ago
Matthew Chen 7ee38f808d Show "add attachment caption" button for non-media attachments; only show if more than one attachment. 6 years ago
Matthew Chen 82f18d8e4e Respond to CR. 6 years ago
Matthew Chen 63637af240 Clean up ahead of PR. 6 years ago
Matthew Chen dc4e174e86 Clean up ahead of PR. 6 years ago
Matthew Chen 7c486d9093 Clean up image editor. 6 years ago
Matthew Chen fa08b18fd7 Clean up image editor. 6 years ago
Matthew Chen b64be3aa73 Clean up image editor. 6 years ago
Matthew Chen 97660e0a11 Clean up image editor. 6 years ago
Matthew Chen bc31c8fcf4 Add brush view controller. 6 years ago
Matthew Chen 00aa5be55d Use navigation bar for image editor buttons. 6 years ago
Matthew Chen e47ceab41c Use navigation bar for image editor buttons. 6 years ago
Matthew Chen a630974e76 Use navigation bar for image editor buttons. 6 years ago
Matthew Chen 87646b1798 Replace old caption view with new caption view. 6 years ago
Michael Kirk 71dd4eb151 in-conversation search
- use MediaTime for computing benchmarks
6 years ago
Matthew Chen be26c135e1 Rework image editor buttons, modes, etc. 6 years ago
Matthew Chen d08445969d Generate gradient for color picker. 6 years ago
Matthew Chen fac123eeb2 Add "crop lock" button and feature. 6 years ago
Matthew Chen e01f39e8e1 Apply image editor design. 6 years ago
Matthew Chen d419709ebd Respond to CR. 6 years ago
Matthew Chen de27ed8728 Add color palette to image editor. 6 years ago
Michael Kirk 3be41e8c25 Unless you're on a call, all windows respect the orientation mask of the
primary app visible VC.

Fixes:
- Avoid flicker when forgrounding onboarding while in landscape
- Fix status bar in landscape while fingerprint is portrait, same with device linker
6 years ago
Matthew Chen dd2b47bd76 Add "flip horizontal" feature. 6 years ago
Matthew Chen 0ce84b7929 Respond to CR. 6 years ago
Matthew Chen 69635fafac Update crop view to reflect design. 6 years ago
Matthew Chen 4db09b45b6 Update crop view to reflect design. 6 years ago
Matthew Chen c07a74d029 Update crop view to reflect design. 6 years ago
Matthew Chen ac1e89ce1d Respond to CR. 6 years ago
Matthew Chen cc20182ec0 Normalize translation in image editor. 6 years ago
Matthew Chen 0d26caced7 Normalize translation in image editor. 6 years ago
Matthew Chen f01fe8e563 Normalize translation in image editor. 6 years ago
Michael Kirk 5bd3cec6dc Merge tag '2.36.1.0' 6 years ago
Michael Kirk 870caaa84a simplify completion checking - make nonnull 6 years ago
Michael Kirk 13154fb828 allow long text with non-durable sends (SAE) 6 years ago
Matthew Chen 56e5feca46 Introduce ConversationSnapshot. 6 years ago
Matthew Chen 2bc5ac14ca Respond to CR. 6 years ago
Matthew Chen 7130895e3f Fix translation in all of editor view's gestures. 6 years ago
Matthew Chen 674cf2e01f Render stroke and text items in image coordinates, not canvas coordinates. 6 years ago
Matthew Chen 7aa826748a Fix translation in crop editor's pinch gesture. 6 years ago
Matthew Chen 4022ba1a16 Fix translation in crop editor's pan gesture. 6 years ago
Matthew Chen 72082edad8 Fix a visual bug that would sometimes occur while rendering settings switches. Thanks to Gunnar C. Pope for the bug report. 6 years ago
Michael Kirk f1623b6037 missing nullability text 6 years ago
Michael Kirk 7e5256856c render media+longText message 6 years ago
Michael Kirk b7989e9384 feature flag approval sending 6 years ago
Michael Kirk bc4260b444 Send long-text with other attachments 6 years ago
Michael Kirk a218d6c465 Send first chars of longtext in protobuf 6 years ago
Michael Kirk 680b844f3c Allow all windows to do landscape, fixes:
1. Remove undesirable animation from portrait->landscape when minimizizing in
   landscape and relaunching in landscape.

2. This also seems to fix the intermittently misplaced toolbar when launching
   in landscape. I believe this is a consequence of fix #1
6 years ago
Michael Kirk 7a4041cdde Cache dark theme preference
This is a hot path
6 years ago
Michael Kirk fabd3996c2 pop view if message is deleted
- use global ui database connection
6 years ago
Matthew Chen 9402e088b2 Apply design feedback from Myles. 6 years ago
Matthew Chen 93e09be18e Apply design feedback from Myles. 6 years ago
Matthew Chen aa8fd9e69c Remove old registration views. 6 years ago
Matthew Chen 8ecad88674 Move the accessibility identifier macros into UIUtil.h. 6 years ago
Matthew Chen 4d4b840787 Respond to CR. 6 years ago
Matthew Chen ef5cd5344e Fix the auto-format of phone numbers in the onboarding views. 6 years ago
Matthew Chen edf09c92f4 Rework "empty inbox" state. 6 years ago
Matthew Chen 1f922aa478 Sketch out the 'onboarding code verification' view. 6 years ago
Matthew Chen 05d63fd6b5 Update font sizes in onboarding views. 6 years ago
Matthew Chen 8cfe768e86 Update font sizes in onboarding views. 6 years ago
Matthew Chen b658866319 Sketch out the 'onboarding phone number' view. 6 years ago
Matthew Chen 2a4b9426c3 Sketch out the 'onboarding phone number' view. 6 years ago
Matthew Chen c0f907c441 Respond to CR. 6 years ago
Matthew Chen 69c5492fce Clean up ahead of PR. 6 years ago
Matthew Chen 331a013f8d Clean up ahead of PR. 6 years ago
Matthew Chen 618a3b1d47 Sketch out crop tool. 6 years ago
Matthew Chen 54c8c1f352 Sketch out the onboarding splash view. 6 years ago
Matthew Chen 2c0aa7a222 Sketch out the onboarding permissions view. 6 years ago
Matthew Chen 73b36c5400 Respond to CR. 6 years ago
Matthew Chen 6ac2dd7ea1 First draft of image editor's text tool. 6 years ago
Matthew Chen 3f8ea271b4 First draft of image editor's text tool. 6 years ago
Michael Kirk cc2e062b85 CR: clean up graphics context code 6 years ago
Michael Kirk 2323cc21f0 note-to-self avatar 6 years ago
Michael Kirk d29ce740cb Voice Note Lock 6 years ago
Matthew Chen ea547fa46a Merge tag '2.35.0.12' 6 years ago
Michael Kirk d88ffc4775 Notification titles for iOS10+ 6 years ago
Michael Kirk fe84275cce Respect audio preferences/throttling 6 years ago
Michael Kirk 1bfe691895 In app notifications for iOS10+
Extract shared notification presention/response

Implement adapters which use that logic for modern UNUserNotification and
legacy UINotifications
6 years ago
Matthew Chen 6bfe0f0418 Ensure 'link new device' view is portrait. 6 years ago
Matthew Chen 7a990ed1ff Ensure 'link new device' view is portrait. 6 years ago
Matthew Chen 6b5952abda Move work off main thread. 6 years ago
Matthew Chen 12e57ecd25 Improve background screenshots v. orientation. 6 years ago
Matthew Chen 4be302bbea Update link previews setting behavior. 6 years ago
Matthew Chen 77396e11fd Send sync messages with link previews preference. 6 years ago
Matthew Chen 910df7069c Link previews migration. 6 years ago
Matthew Chen 7f2ca60615 Link previews migration. 6 years ago
Matthew Chen 2b71c433ac Update appearance of draft quoted replies. 6 years ago
Matthew Chen ccb174120f Tweak conversation input toolbar layout. 6 years ago
Matthew Chen 39de96ac26 Re-enable landscape orientation; fix 'double activation' issue. 6 years ago
Matthew Chen c359f2b708 Replace "connecting/sonar ping" with "outbound ringing." 6 years ago
Matthew Chen c02d633272 Align draft view of link preview and draft view of quoted reply. 6 years ago
Matthew Chen 9149282e94 Resize link preview images if necessary. 6 years ago
Matthew Chen 4e7dbc486d Segment proxied content downloads. 6 years ago
Matthew Chen 82ceb044e3 Use link preview image when quote replying. 6 years ago
Matthew Chen 9b7ae86a6d Rework layout of conversation input toolbar. 6 years ago
Matthew Chen 6ff6ee2e2e Rework layout of conversation input toolbar. 6 years ago
Matthew Chen 3d757b492a Add link previews to conversation message bubbles. 6 years ago
Matthew Chen 8c7c9b27a2 Merge tag '2.34.0.26' 6 years ago
Michael Kirk 896a9f78f7 limit media message body to 2k chars 6 years ago
Michael Kirk 599a57e3a4 Pan horizontal to bulk select images 6 years ago
Michael Kirk 169581f12f show toast when selecting too many items 6 years ago
Matthew Chen 977ee9ffe9 Merge remote-tracking branch 'private/release/2.34.0' 6 years ago
Matthew Chen 2dcc79fbca Fix issues around link previews. 6 years ago
Matthew Chen 8e44bf554c Respond to CR. 6 years ago
Matthew Chen d775a70a89 Build link previews. 6 years ago
Matthew Chen 31ea64bdaf Build link previews. 6 years ago
Matthew Chen 7878c0fac8 Add feature flag for 'note to self'. 6 years ago
Michael Kirk 721f330296 warm non-signal accounts cache in the background 6 years ago
Matthew Chen debf2e7a95 Fix 'mutation during enumeration' and 'bad ordering' crashes. 6 years ago
Michael Kirk 0fb6dab020 avoid blocking write connection with long running read when building sync message 6 years ago
Michael Kirk 3c0982e0f9 Fix missing captionView when navigating via RailView 6 years ago
Michael Kirk 0c1b2e9f48 CR: remove unnecessary param, clearer code, comment typo 6 years ago
Michael Kirk 6e50a5353b rename for clarity 6 years ago
Matthew Chen be714399c7 Add feature flag for landscape orientation. 6 years ago
Matthew Chen eab3599ce9 Add feature flag for landscape orientation. 6 years ago
Michael Kirk b4908e71e9 Use FTS for compose picker search 6 years ago
Matthew Chen 635a644e2f Fix safe area insets in SAE. 6 years ago
Matthew Chen 50f9a089bf Fix navbar layout in share extension. 6 years ago
Matthew Chen a477e01a4a Apply LinkPreview model. 6 years ago
Matthew Chen efd1be30c7 Cull unknown migrations. 6 years ago
Michael Kirk 0e78f9912b bump migration version 6 years ago
Matthew Chen bf0d92acfb Landscape layout in gif picker. 6 years ago
Matthew Chen 4ab0c8fe58 Landscape orientation. 6 years ago
Matthew Chen 2ddde368ec Landscape orientation. 6 years ago
Matthew Chen 5adcbac5ef Landscape orientation. 6 years ago
Matthew Chen 460f160cbb Landscape orientation. 6 years ago
Michael Kirk 099b9f60c3 enable multisend 6 years ago
Michael Kirk 0ab326da92 Only show delete button on selected rail item 6 years ago
Matthew Chen c0922fc2c0 Remove LockInteractionController. 6 years ago
Michael Kirk 265552ae0e enable multisend in debug 6 years ago
Michael Kirk c690ac2710 allow deselecting tool 6 years ago
Michael Kirk a8200d6f4a Fix swipe between multi-images
gesture shouldn't be enabled until tool has been selected
6 years ago
Matthew Chen 5e3de84fdc Add feature flag for image editor. 6 years ago
Matthew Chen 9ab8bec2b1 Fix searching for 'note to self'. 6 years ago