Commit Graph

403 Commits (411d5a3b4fe1ce2ef884d7e246bf7f275e059d20)

Author SHA1 Message Date
Matthew Chen f2b416d800 Respond to CR. 7 years ago
Matthew Chen 180cbbcdb3 Don't use scaledFontForFont. 7 years ago
Matthew Chen 8c1362b807 Fix small text usage. 7 years ago
Matthew Chen ade2ee7216 Use dynamic type everywhere in conversation view. 7 years ago
Michael Kirk 81b2b57703 CR: add comments, make atomic
// FREEBIE
7 years ago
Michael Kirk 90486aa49c Inline method with one caller, fix formatting
// FREEBIE
7 years ago
Michael Kirk c56e8acc51 QuotedReplyModel from SSK->SignalMessaging
// FREEBIE
7 years ago
Michael Kirk 1d4c0624be Clarify variable names
// FREEBIE
7 years ago
Michael Kirk cb5d3d4f85 Use QuotedReplyModel to access attachment data
This view model loads the attachment when it's build.

// FREEBIE
7 years ago
Michael Kirk 253435b27f extract QuotedReplyDraft model 7 years ago
Michael Kirk 53af41fcc6 Reusable UploadOperation based on extracted OWSOperation
// FREEBIE
7 years ago
Matthew Chen 6830d4e8cb Apply message bubble view to message details view. 7 years ago
Matthew Chen 71c5c3a4b7 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 822aa64b14 Respond to CR. 7 years ago
Matthew Chen 6171505657 Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 10b4ade55a Refine appearance of quoted reply message cells. 7 years ago
Matthew Chen 9085609087 Fix interaction initializers and tests. 7 years ago
Michael Kirk b6409dd514 CR: formatting changes
// FREEBIE
7 years ago
Michael Kirk bf401bad90 Send quoted messages
MVP

- [x] populate from menu
- [x] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
7 years ago
Michael Kirk 6874a9e28e Convert to swift
// FREEBIE
7 years ago
Michael Kirk 5f8b3ff285 Object lifecycle disposes SystemSound
// FREEBIE
7 years ago
Michael Kirk 2580c690cb CR: Use LRU Cache for storing system sounds
// FREEBIE
7 years ago
Michael Kirk 3cb53f5f44 Respect system alert volume for notifications while in app
// FREEBIE
7 years ago
Michael Kirk 86553b62f9 keyboard pinning vs iPhoneX 7 years ago
Michael Kirk af5f549e49 Fix TableView layout for iPhoneX
// FREEBIE
7 years ago
Michael Kirk f441c6211d Format
// FREEBIE
7 years ago
Michael Kirk 6f1608f44b Conventional naming for out custom PureLayout methods.
This moves methods more in line with PureLayout conventions.

- Methods always specify if they pin to an edge vs margin

- `margin` is a reserved word which should only refer to layout margins.
  i.e. do not use it to refer to "inset" and "offset".

// FREEBIE
7 years ago
Matthew Chen 4240b517d0 Respond to CR. 7 years ago
Matthew Chen 8e4f2ca0ed Rework proto schema changes for quoted replies.
Sketch out model changes for quoted replies.

Sketch out quoted reply input preview.

Send quoted messages protos.

Update models to reflect quoted messages.

Rework interaction initializers.

Rework interaction initializers.

Add debug UI methods for generating quoted reply variations.

Add debug UI methods for generating quoted reply variations.
7 years ago
Matthew Chen f98c45603c Respond to CR. 7 years ago
Matthew Chen 31f062ed11 Bubble collapse. 7 years ago
Matthew Chen c8012d3891 Bubble collapse. 7 years ago
Matthew Chen e0e8eafb5d Bubble collapse. 7 years ago
Matthew Chen 11819d9b8a Bubble collapse. 7 years ago
Matthew Chen 75177ef00f Bubble collapse. 7 years ago
Michael Kirk d7cccd1e87 Fix: Audio stops when leaving MessageDetails VC
// FREEBIE
7 years ago
Michael Kirk 9adf79c546 Always remove metadata
// FREEBIE
7 years ago
Michael Kirk 1d95cd6977 Improve video scrubbing UX in PageView
// FREEBIE
7 years ago
Matthew Chen 9962bf56b1 Fix 'invalid auth can hang on launch' issue. 7 years ago
Matthew Chen ef34cd5d58 Fix 'invalid auth can hang on launch' issue. 7 years ago
Michael Kirk 394cc6637c Backport comments from translations
// FREEBIE
7 years ago
Matthew Chen bb596dba98 Add screen lock feature. 7 years ago
Matthew Chen 847a0269cb Properly cleanup content. 7 years ago
Matthew Chen 8d689ec090 Properly cleanup content. 7 years ago
Michael Kirk 0025661a8d Extract GradientView
// FREEBIE
7 years ago
Michael Kirk 7754d3d94f Real assets
// FREEBIE
7 years ago
Michael Kirk 352f5c1059 Prefer back button over dismiss
In some context this makes more sense, and it will never be confusing.

// FREEBIE
7 years ago
Michael Kirk 2412ab092e Avoid occasional audio crash
// FREEBIE
7 years ago
Michael Kirk 4c2d30a776 Memory warning clears MediaPageView cache
Doing so required MediaDetailView to retain GalleryItem, but because
GalleryItem is a swift struct, I had to envoke the Box dance.

// FREEBIE
7 years ago
Michael Kirk ba2923bae3 remove unused category
// FREEBIE
7 years ago
Michael Kirk 96e5a8f4b7 One time thumbnail generation
// FREEBIE
7 years ago
Michael Kirk dfd628250d Gallery performance
- [x] share uiDatabaseConnection to share cache
- [x] increase cache size
- [x] load less initially
- [x] lazy loading
  - [x] slider view
  - [x] tile view

// FREEBIE
7 years ago
Michael Kirk 985af76d0b WIP: All Media view
TODO

- [ ] label video/gif
- [ ] reasonable load perf
- [ ] reasonable scroll perf
- [ ] select / delete
- [ ] cancel share action from media details returns signal style

NICE TO HAVE

- [ ] fancy in/out animation from All Media <-> tiles
- [ ] label video thumbnail with duration stamp
- [ ] Other perf?
- [ ] dbModified?
- [ ] select / send
- [ ] darken section header a shade once it's "active"

DONE

- [x] tap to refocus on new media
- [x] generate test data
- [x] section headers
- [x] equal spacing around cells

// FREEBIE

WIP WIP extract datasouce to GalleryViewController

- [x] swipe through is broken
- [x] present animation
- [x] dismiss animation

// FREEBIE
7 years ago
Matthew Chen 565743b66d Fix edge cases in migrations. 7 years ago
Matthew Chen d2f2dd273a Fix edge cases in migrations. 7 years ago
Michael Kirk 4ac9a1019b Media page view controller
First pass at a swipe-through media view for conversations.

Future work could include

- title label per item
  - sender name
  - date/time
- photo rail
- include caption

// FREEBIE
7 years ago
Matthew Chen 4746948dfe Respond to CR. 7 years ago
Matthew Chen 76b4deffe4 Respond to CR. 7 years ago
Matthew Chen 5035cb040e Implement backup import logic. 7 years ago
Matthew Chen a91eea9a17 Fix rebase breakage. 7 years ago
Matthew Chen 593f7da72d Upload test file to CloudKit. 7 years ago
Michael Kirk c5ff9a94a0 Merge tag '2.22.0.3' 7 years ago
Michael Kirk 173008fba9 Clarify reminder view, touchup layout
Layout needs to be kept tight for small form factors, but it was overly
cramped on larger devices.

// FREEBIE
7 years ago
Collin B. Stuart 6f7b4a6e43 Strip media metadata.
- removes non-orientation metadata from image and video attachments

- option to disable the feature

// FREEBIE
7 years ago
Michael Kirk 319e0d808f Merge tag '2.21.0.14' into release/2.22.0 7 years ago
Michael Kirk 3aebaefc31 A lighter touch for the fix-call connect.
Though it should be fine, reloading the callUIAdapter is a bit heavy
handed. And the current implementation is prone to being broken, since
we sometimes forget not to treat callUIAdapter as a singleton.

Longer term we can find a way to either: make callUIAdapter a true
singleton or possibly make callUIAdapter a private member of something
which *is* a true singleton.

Since we only *need* it to be reloaded the one time the migration runs
(or when a user changes settings which should be rare) it makes sense to
remove it from the happy path.

// FREEBIE
7 years ago
Michael Kirk bbdcd0c768 Call connection fixups
callUIAdapter is not a singleton (for better or for worse)

No one should hold a reference directly to it, but rather via the
CallService, which is a singleton

Wait a bit longer for initial call screen before terminating. Especially
first call can hit this limit.

When call *does* take too long to show, terminate properly to ensure
we're not left with a phantom call

// FREEBIE
7 years ago
Michael Kirk 74ccdfdf2c Fix redundant profile downloads
// FREEBIE
7 years ago
Michael Kirk a1de99f1f1 Merge tag '2.21.0.9' 7 years ago
Michael Kirk 39b87b702b Fix debuglogs.org integration
// FREEBIE
7 years ago
Matthew Chen db430d6aa7 Revert unwanted changes. 7 years ago
Matthew Chen d6f4db1523 Rename TSStorageManager to OWSPrimaryStorage. 7 years ago
Michael Kirk f459c9ce6d CR: rename SignalClassic constant
// FREEBIE
7 years ago
Michael Kirk 5739f074ae Show migration screen at first launch.
sort sounds alphabetically (other than Default/None)

// FREEBIE
7 years ago
Michael Kirk 55a4b66ca3 Run call settings migration
// FREEBIE
7 years ago
Michael Kirk 1ddf3bb4e1 Fix "use ambient" for notifications
// FREEBIE
7 years ago
Michael Kirk 126a4cb7ca Fix build break
// FREEBIE
7 years ago
Michael Kirk 79ee5ed216 Be more conservative about logging legacy users into "Recents"
// FREEBIE
7 years ago
Michael Kirk 4e64b09ad6 Don't set audio to ambient while other audioActivity exists
// FREEBIE
7 years ago
Michael Kirk 830e9f1bfd Make "Signal Classic" audio stand out more
// FREEBIE
7 years ago
Michael Kirk 7883167265 Fix "None" audio for fallback notifications.
// FREEBIE
7 years ago
Michael Kirk d3be2b4a3b Vibrate when playing sound as alert
// FREEBIE
7 years ago
Michael Kirk d7fcac8a5a In-App notifications don't pause background audio
// FREEBIE
7 years ago
Matthew Chen 4f55079a79 Respond to CR. 7 years ago
Matthew Chen 2d6b9a7c81 Respond to CR. 7 years ago
Matthew Chen 9db9409561 Share background tasks. 7 years ago
Michael Kirk 07ee3ea843 Merge tag '2.21.0.5' 7 years ago
Michael Kirk 1d3831eccd Registration Lock reminder view
Also fixed: Don't lose PIN across registrations

// FREEBIE
7 years ago
Michael Kirk 6077367e66 Notification sounds should respect silent switch
// FREEBIE
7 years ago
Michael Kirk 1ff2f3f42e Merge tag '2.21.0.1' 7 years ago
Matthew Chen 864f1cc8ee Clean up ahead of PR. 7 years ago
Matthew Chen 4834a85fb5 Add share option for debug logs. 7 years ago
Matthew Chen 06d16bdec5 Revert "Revert "Merge branch 'charlesmchen/debugLogs' into hotfix/2.20.1""
This reverts commit b1dd325ce8.
7 years ago
Matthew Chen e89a0f815b Respond to CR. 7 years ago
Matthew Chen 5e02032fc3 Fix profile avatar downloads. 7 years ago
Matthew Chen 69c49d4a7b Fix profile avatar downloads. 7 years ago
Matthew Chen b62a43217f Fix profile avatar downloads. 7 years ago
Matthew Chen 15921fa0b5 Fix profile avatar downloads. 7 years ago
Matthew Chen dfa082238e Fix profile avatar downloads. 7 years ago
Michael Kirk 1d7e2e367e Fix migration to work with fallback notifications as well
// FREEBIE
7 years ago