Commit Graph

320 Commits (12dbb9928bff7f6f552e6adcb36c10c0c4e9e3c9)

Author SHA1 Message Date
Matthew Chen 547724b5cf Add inner shadows to profile pics. 7 years ago
Matthew Chen 352777765e Add inner shadows to profile pics. 7 years ago
Matthew Chen 25d56b30c1 Rework group avatars to reflect conversation colors. 7 years ago
Matthew Chen ae84528dc3 Update avatar colors; add shaded conversation color constants, modify color picker to be color-name-based, not color-based, use shaded conversation colors, remove JSQ. 7 years ago
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Michael Kirk fd492f379a Use BlockListCache where possible 7 years ago
Michael Kirk 2c49232db0 remove barely used getters
Lock contention on these methods is less important because we're not iterating
over their access, e.g. per tableViewCell
7 years ago
Michael Kirk 28d28cf2b6 remove unused code 7 years ago
Michael Kirk 8aba5725cf BlockListViewController v. group blocking 7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Michael Kirk 236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Matthew Chen df7acfeed3 Simplify OWSPreferences access. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Matthew Chen d4f7b5d45b Respond to CR. 7 years ago
Matthew Chen e1049fdfcc Respond to CR. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Michael Kirk 1743407cc2 Code cleanup per code review 7 years ago
Michael Kirk 3022f92925 Tweak tint for search bar icons in dark theme 7 years ago
Michael Kirk 75bb9b60db Alternative dark theme search bar
Rather than our custom class, we can get pretty far using existing UISearchBar
styling, and then apply the final tweak, the search bar text field background
color by traversing the view.

This fixes a couple issues:

1. There was a small wavering in height of the custom search bar
2. When your table header view is a UISearchBar you get nice scroll "snapping"
   when showing/hiding the search bar.
7 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
7 years ago
Michael Kirk b80d88c824 theme attachment approval keyboard
// FREEBIE
7 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 7 years ago
Matthew Chen decb0c54ca Theme review. 7 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 7 years ago
Matthew Chen 26001e49d1 Unify log tags. 7 years ago
Michael Kirk 7a0d74c17e Use dark blur for navbar
In the light theme, using the "light" blur allows the bar to seem invisible
when over white content. Similarly for the "dark" blur over black content.
7 years ago
Michael Kirk 1ff443c3ac restore transparent navbar in attachment approval 7 years ago
Matthew Chen 9c92719ec4 Refine theme. 7 years ago
Matthew Chen 5ef0b6d056 Refine theme. 7 years ago
Matthew Chen acd7d094b1 Refine theme. 7 years ago
Matthew Chen 579e88bdc2 Improve nullability handling for SignalAccount. 7 years ago
Michael Kirk 78ad597e44 Merge tag '2.28.0.15' 7 years ago
Michael Kirk def8b43daa iOS9/10 fixups 7 years ago
Matthew Chen fa8a07abf1 Respond to CR. 7 years ago
Michael Kirk 6e1c1a681b Merge tag '2.28.0.12' 7 years ago
Michael Kirk 3d6b8e2bb5 hide navbar blur layer in attachment approval, which has a clear navbar 7 years ago
Matthew Chen 48975eaac8 Respond to CR. 7 years ago
Matthew Chen 8862f9a531 Refine views. 7 years ago
Michael Kirk 11fc674ef4 Avoid blur as overly-tall navigation bar lingers after dismissal.
Use the precise status bar height.
7 years ago
Michael Kirk 7a5f5476db rename to avoid confusion 7 years ago
Michael Kirk 8da47b64d9 clarify different methods
These method names were too similar to existing methods in PureLayout, which
have slightly different behavior.

ows_autoPinToSuperviewEdges uses left/right, whereas PureLayouts uses
leading/trailing

ows_autoPinToSuperviewMargins uses our own constraint adding logic, which
behaves differently in some cases.
7 years ago
Michael Kirk a2c67bb96b Enhance navbar blur, match input toolbar blur
// FREEBIE
7 years ago
Matthew Chen c460ff2945 Fix contact cell layout. 7 years ago
Michael Kirk 4f94d5c5a9 default value 7 years ago
Michael Kirk 104e63ded9 remove appearance juggling 7 years ago
Michael Kirk f8abe32ae9 more styling to new nav colors 7 years ago
Michael Kirk de56eb9d6b Proper color for compose screen avatars
ConversationCell#thread is nullable

// FREEBIE
7 years ago
Michael Kirk 16df4f589e conversation colors
// FREEBIE
7 years ago
Matthew Chen d2f2e1cb22 Respond to CR. 7 years ago
Matthew Chen 7634e3a44d Respond to CR. 7 years ago
Matthew Chen 2b457c6499 Tweak contact shares. 7 years ago
Michael Kirk 803a58f33a avoid assert
// FREEBIE
7 years ago
Michael Kirk cde1c3fb7c Fix: iOS10 was not respecting margins with our homebrew pin method
// FREEBIE
7 years ago
Matthew Chen 8cb057c23f Fix 'contact cell vs. message details layout' issue. 7 years ago
Matthew Chen c8d0a80032 Fix 'contact cell vs. message details layout' issue. 7 years ago
Matthew Chen 2ecbf1bb65 Fix 'contact cell vs. message details layout' issue. 7 years ago
Matthew Chen 1a57fe631c Fix 'contact cell vs. message details layout' issue. 7 years ago
Matthew Chen 0df71e22a5 Fix message detail view. 7 years ago
Matthew Chen 83f11ad79b Don't cache CNContact. 7 years ago
Matthew Chen 1acf51ea5c Unify the cell and avatar sizes. 7 years ago
Matthew Chen 261719e53b Unify the cell and avatar sizes. 7 years ago
Matthew Chen dd49c6225f Auto-size contact cells everywhere. 7 years ago
Matthew Chen 44b23d44fd Respond to CR. 7 years ago
Matthew Chen f4a559156c Style the search results. 7 years ago
Matthew Chen fefc9843b1 Modify views to observe changes when active, not just foreground. 7 years ago
Matthew Chen 812210a63c Modify views to observe changes when active, not just foreground. 7 years ago
Matthew Chen f63d25a172 Migrate to Swift 4. 7 years ago
Matthew Chen 28e26e1f75 Migrate to Swift 4. 7 years ago
Matthew Chen 28f7142a59 Auto-migration to Swift 4. 7 years ago
Michael Kirk 20424d9a7e remove debug code, reorder for clarity
// FREEBIE
7 years ago
Michael Kirk fe62a6ac92 CNContactController needs to be presented in a navcontroller with a
translucent navbar.

In cases where we were presenting modally, we can easily modify the
modal to have a translucent navbar.

In the one place we were pushing onto the SignalsNavigationController,
rather than modifying the SNC.isTranslucent and having to clean it up,
I've opted to convert to a modal presentation.

// FREEBIE
7 years ago
Michael Kirk 4c9808d1a1 Fix iPhoneX layout show status bar above call banner
// FREEBIE
7 years ago
Michael Kirk 3383c5e80c Fixup for iPhoneX
// FREEBIE
7 years ago
Michael Kirk 49c652ad14 Comment cleanup
// FREEBIE
7 years ago
Michael Kirk 1b60716759 Stop worrying about notification order by using delegate pattern
// FREEBIE
7 years ago
Michael Kirk 319a6ff765 fixup behavior on iOS10 7 years ago
Michael Kirk 29d08545e2 Use OWSNavigationController instead of UINavigationController
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
7 years ago
Matthew Chen e2d9c1187a Fix "group avatar doesn't update after local change." 7 years ago
Matthew Chen 2edabdbba4 Sort group members. 7 years ago
Michael Kirk 0c469764f1 re-use contact picker for "add to existing"
Required refactor of contact picker to be presented non-modally.

TODO: merge emails, address, display names

// FREEBIE
7 years ago
Matthew Chen 44ceee5849 Add contact share actions to conversation view and improve phone number parsing. 7 years ago
Matthew Chen 50c49baca8 Update design of 'approve contact share' view. 7 years ago
Matthew Chen fa5577eece Create contact view. 7 years ago
Michael Kirk b702695793 cleanup 7 years ago
Michael Kirk 7a1d24a9ab Avatar updates when contact/profile/group photo changes
// FREEBIE
7 years ago
Matthew Chen 6caa5b87b6 Add more asserts around thread in SAE. 7 years ago
Matthew Chen 8c1362b807 Fix small text usage. 7 years ago
Matthew Chen ade2ee7216 Use dynamic type everywhere in conversation view. 7 years ago
Michael Kirk 6f1608f44b Conventional naming for out custom PureLayout methods.
This moves methods more in line with PureLayout conventions.

- Methods always specify if they pin to an edge vs margin

- `margin` is a reserved word which should only refer to layout margins.
  i.e. do not use it to refer to "inset" and "offset".

// FREEBIE
7 years ago
Michael Kirk 394cc6637c Backport comments from translations
// FREEBIE
7 years ago
Matthew Chen bb596dba98 Add screen lock feature. 7 years ago
Michael Kirk 0025661a8d Extract GradientView
// FREEBIE
7 years ago
Matthew Chen d6f4db1523 Rename TSStorageManager to OWSPrimaryStorage. 7 years ago
Matthew Chen 152c570900 Respond to CR. 7 years ago
Matthew Chen 5444fc73b0 Improve handling of db modifications while conversation view is not observing. 7 years ago
Michael Kirk a1d3073705 Cannot open settings from share extension
// FREEBIE
7 years ago
Matthew Chen 6a7f06f940 Respond to CR. 7 years ago
Michael Kirk baa312f449 Timer button with duration label
// FREEBIE
7 years ago
Michael Kirk 5c2075cdb6 Show disappearing messages timer in share extension
// FREEBIE
7 years ago
Michael Kirk 3ca5ec2726 Ensure media-library permissions when accessing media library
// FREEBIE
7 years ago
Matthew Chen 2b528ad894 Don't use mainApplicationState in business logic. 7 years ago
Matthew Chen 17907dca10 Clean up ahead of PR. 7 years ago
Matthew Chen 15b8e58324 Retain changes from session database branch. 7 years ago
Matthew Chen e77c3e6717 Retain changes from session database branch. 7 years ago
Matthew Chen 6b0e3508a5 Respond to CR. 7 years ago
Matthew Chen 245304116f Respond to CR. 7 years ago
Matthew Chen d52eba739d Clean up TSStorageManager usage. 7 years ago
Matthew Chen 85686d3144 Continue TSStorageManager refactor. 7 years ago
Matthew Chen 9a990b58e8 Respond to CR. 7 years ago
Matthew Chen 0c9d9ba679 Fix issues around cross process db changes. 7 years ago
Matthew Chen 74efcb9041 Rework thread safety in profile manager. 7 years ago
Michael Kirk a58f1f385c Share a photo from photos app
Shows the conversation picker, and sends the attachment to that
conversation.

There's still a lot TODO

-[ ] resolve JSQ dependency
-[ ] properly wait for app to load
-[ ] dismiss share extension after send is complete
-[ ] support non jpeg file types
-[ ] Fix device sleep manager

// FREEBIE
7 years ago