Commit Graph

496 Commits (01496b2db86a993c159e1b5230064c4a158ec49d)

Author SHA1 Message Date
Matthew Chen 01496b2db8 Avoid deadlocks in message sender. 7 years ago
Matthew Chen a19882baaa Avoid deadlocks in message sender. 7 years ago
Collin B. Stuart cc94573e9b Constant time compare
- fix case when second part of the && conditional is skipped when data is not equal

- isEqual variable marked volatile to prevent case when it doesn't equal 0, the loop can break early since it can never be 0 again

- tested with Fastest O3 and Whole Module optimization (App Store Release)

// FREEBIE
7 years ago
Michael Kirk ea12ed4c23 Fix dynamic type check which was too restrictive
// FREEBIE
7 years ago
Michael Kirk ae2ddb25cc CR: add assert
// FREEBIE
7 years ago
Michael Kirk d6b3e191d1 Fix crash while searching when group somehow has nil members
This shouldn't normally happen, but seeing it on my device.

// FREEBIE
7 years ago
Michael Kirk a23f1b86ef nullability annotations for TSGroupModel
- add readonly where possible
- group members needn't be a mutable array

// FREEBIE
7 years ago
Joshua Lund 2c18a75d12 Update to the new GitHub organization name 7 years ago
Matthew Chen ba42ac73d8 Revisit TODOs in the SAE work. 7 years ago
Matthew Chen 9c8178653d Revisit TODOs in the SAE work. 7 years ago
Matthew Chen b64528e817 Respond to CR. 7 years ago
Matthew Chen 78c4c00eac Respond to CR. 7 years ago
Matthew Chen 862172072c Respond to CR. 7 years ago
Matthew Chen bd0f601792 Respond to CR. 7 years ago
Matthew Chen 38950ae2ed Respond to CR. 7 years ago
Matthew Chen 6b357f9445 Respond to CR. 7 years ago
Matthew Chen 43765ef3b5 Respond to CR. 7 years ago
Matthew Chen 51cec20c50 Clean up ahead of PR. 7 years ago
Matthew Chen 7d3f79440f Clean up ahead of PR. 7 years ago
Matthew Chen c8e7eb903c Add protocol context to protocol kit. 7 years ago
Matthew Chen bbd689bfd0 Add protocol context to protocol kit. 7 years ago
Matthew Chen d3e16583eb Add protocol context to protocol kit. 7 years ago
Matthew Chen 074046b98e Add protocol context to protocol kit. 7 years ago
Matthew Chen 7358f3053f Add protocol context to protocol kit. 7 years ago
Matthew Chen 218bb15ea7 Add protocol context to protocol kit. 7 years ago
Matthew Chen 39e353503f Add protocol context to protocol kit. 7 years ago
Matthew Chen 71782e0369 Add protocol context to protocol kit. 7 years ago
Matthew Chen 122ef91e57 Add protocol context to protocol kit. 7 years ago
Michael Kirk a1d3073705 Cannot open settings from share extension
// FREEBIE
7 years ago
Matthew Chen 799949e546 Refine sync messages. 7 years ago
Matthew Chen 59ff1561f5 Set the timestamp property on data messages. 7 years ago
Matthew Chen 4218af13d5 Send image width/height for image and video attachments. 7 years ago
Matthew Chen 3a4180214f Send image width/height for image and video attachments. 7 years ago
Matthew Chen 43ed8d9a5d Send "disappearing messages" state for groups. 7 years ago
Matthew Chen b16a65a4cd Sync block state for contacts. 7 years ago
Matthew Chen 742d4cabc2 Send "disappearing messages" state for contacts. 7 years ago
Matthew Chen 2dc37d598c Updates service proto schema to latest. 7 years ago
Michael Kirk 4f8db63fb3 Ensure keyspec is generated before DB is created
// FREEBIE
7 years ago
Michael Kirk 6f959ff292 CR: be more conservative about deriving key spec, clear old passphrase
after deriving key spec.

// FREEBIE
7 years ago
Michael Kirk d22fc664f2 more granular key access
// FREEBIE
7 years ago
Michael Kirk 426c9baa16 Key material changes
- For new installs, generate raw key-spec rather than derive it
- Adapt to separated concerns of the key derivation migration from the unencrypted header migration
- Reduce number of places where we delete/generate keying information
- Only store relevant keying material

// FREEBIE
7 years ago
Michael Kirk 938b9c85b8 Don't crash on clean install
Otherwise we'll error when retrieving non-existent password.

// FREEBIE
7 years ago
Matthew Chen 4bfdef520a Respond to CR. 7 years ago
Matthew Chen a30170b3b2 Prefer "app is ready" flag to "storage is ready" flag. 7 years ago
Matthew Chen be1fde905c Don't mark app as ready until all version migrations are done. 7 years ago
Matthew Chen 963d0547ad Clean up ahead of PR. 7 years ago
Matthew Chen 8e427111ef Clean up ahead of PR. 7 years ago
Matthew Chen ebbe96a5d5 Clean up ahead of PR. 7 years ago
Matthew Chen 6eddfae214 Improve post-migration testing tools. 7 years ago
matthew chen 8325c37191 Fix build breakage. 7 years ago