Respond to CR.

8 years ago · 38950ae2ed
parent 6b357f9445
commit 38950ae2ed
1 changed files with 4 additions and 2 deletions
--- a/SignalServiceKit/src/Storage/OWSStorage.m
+++ b/SignalServiceKit/src/Storage/OWSStorage.m
@ -454,8 +454,10 @@ typedef NSData *_Nullable (^CreateDatabaseMetadataBlock)(void);
 - (YapDatabaseConnection *)newDatabaseConnection
 {
    YapDatabaseConnection *dbConnection = self.database.newConnection;
-    OWSRaiseException(
-        @"OWSStorageExceptionName_CouldNotOpenConnection", @"Storage could not open new database connection.");
+    if (!dbConnection) {
+        OWSRaiseException(
+            @"OWSStorageExceptionName_CouldNotOpenConnection", @"Storage could not open new database connection.");
+    }
    return dbConnection;
 }