You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
session-ios/Signal/src
Michael Kirk 3850ca29b0 Bigger hack to fix problem with lesser hack.
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
6 years ago
..
Generated
Jobs log token in debug 6 years ago
Models Sketch out the 'onboarding phone number' view. 6 years ago
Storyboard Landscape orientation. 6 years ago
UserInterface Haptic feedback when remote enables video 6 years ago
ViewControllers Bigger hack to fix problem with lesser hack. 6 years ago
call Ensure Callkit is enabled for locale. 6 years ago
environment Merge remote-tracking branch 'origin/release/2.36.0' 6 years ago
network Use content proxy to configure all proxied content requests. 6 years ago
util Apply presentAlert() throughout codebase. 6 years ago
views Ensure constant bubble sizes for oversize text. 6 years ago
AppDelegate.h
AppDelegate.m Apply presentAlert() throughout codebase. 6 years ago
ConversationSearch.swift in-conversation search 6 years ago
Signal-Bridging-Header.h Remove old registration views. 6 years ago
UIAlerts+iOS9.m fix crash when presenting alerts on iOS9 6 years ago
UIApplication+OWS.swift
UIStoryboard+OWS.swift