You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Michael Kirk 3850ca29b0 Bigger hack to fix problem with lesser hack.
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
6 years ago
.github Update ISSUE_TEMPLATE.md 7 years ago
Pods@1da2265dd4 update pods 6 years ago
Scripts Update reverse integration check. 6 years ago
SettingsBundle Update to the new GitHub organization name 7 years ago
Signal Bigger hack to fix problem with lesser hack. 6 years ago
Signal.xcodeproj Add accessibility identifiers to blocklist popups. 6 years ago
Signal.xcworkspace Enable legacy build system. 7 years ago
SignalMessaging Bigger hack to fix problem with lesser hack. 6 years ago
SignalServiceKit disable custom capture flow for now 6 years ago
SignalShareExtension "Bump build to 2.38.0.5." 6 years ago
ThirdParty update WebRTC artifact to M73 6 years ago
fastlane Add jenkinsfile 6 years ago
protobuf Clean up ahead of PR. 7 years ago
.clang-format format objc. 9 years ago
.gitattributes Supporting diffing of localizablestrings. 10 years ago
.gitignore track pod dependencies publicly 7 years ago
.gitmodules use https:// url for gitmodules 7 years ago
.ruby-version bump ruby version 6 years ago
.travis.yml CI runs SSK tests 8 years ago
BUILDING.md removed outdated build instructions. 7 years ago
CONTRIBUTING.md update translation location 7 years ago
Gemfile update ci to use latest XCode / fastlane 8 years ago
Gemfile.lock update fastlane 6 years ago
Jenkinsfile ci labels PRs with GH title 6 years ago
LICENSE Update license. 8 years ago
MAINTAINING.md Update MAINTAINING.md 7 years ago
Makefile Add jenkinsfile 6 years ago
Podfile Revert PromiseKit update for now 6 years ago
Podfile.lock link checks 6 years ago
README.md update translation location 7 years ago
SignalServiceKit.podspec replace SocketRocket with Starscream 6 years ago

README.md

Signal for iOS

Signal is a messaging app for simple private communication with friends.

Available on the App Store

Translation

Help us translate Signal! The translation effort happens on Transifex

Contributing Code

Instructions on how to set up your development environment and build Signal-iOS can be found in BUILDING.md. Other useful instructions for development can be found on the Development Guide wiki page. We also recommend reading the contribution guidelines.

Contributing Ideas

Have something you want to say about Open Whisper Systems projects or want to be part of the conversation? Get involved in the community forum.

SignalServiceKit

Check out the SignalServiceKit README for details about using SignalServiceKit in your own app.

Cryptography Notice

This distribution includes cryptographic software. The country in which you currently reside may have restrictions on the import, possession, use, and/or re-export to another country, of encryption software. BEFORE using any encryption software, please check your country's laws, regulations and policies concerning the import, possession, or use, and re-export of encryption software, to see if this is permitted. See http://www.wassenaar.org/ for more information.

The U.S. Government Department of Commerce, Bureau of Industry and Security (BIS), has classified this software as Export Commodity Control Number (ECCN) 5D002.C.1, which includes information security software using or performing cryptographic functions with asymmetric algorithms. The form and manner of this distribution makes it eligible for export under the License Exception ENC Technology Software Unrestricted (TSU) exception (see the BIS Export Administration Regulations, Section 740.13) for both object code and source code.

License

Copyright 2014-2018 Open Whisper Systems

Licensed under the GPLv3: http://www.gnu.org/licenses/gpl-3.0.html