Commit Graph

1167 Commits (f6e792c7075ce69e06b598427a88648255a9187d)

Author SHA1 Message Date
Michael Kirk 015c0bf5ca Merge tag '2.27.1.2' 7 years ago
Matthew Chen 3f4cd15f5b Use sending queue in websocket send failover to REST. 7 years ago
Michael Kirk 0f34f76611 Merge tag '2.27.1.1' 7 years ago
Michael Kirk 2c1693c941 Revert "Revert "Revert "Disable contact sharing."""
This reverts commit 57e3d0d5f9.
7 years ago
Matthew Chen 92332c2b69 Rework contact share buttons. 7 years ago
Michael Kirk 1e8c7d63b8 clarify sync logging 7 years ago
Michael Kirk 8576de0618 Fix: No contacts/groups after initial device link
The server caches your device list on the websocket, so sending on the
websocket to a just-linked device will always fail. We could close/open the
websocket, but that might be disruptive in it's own way. Instead we'll closely
mirror the Android approach, where WebSocket sends are attempted only one time,
and failure is handled by falling back to the original REST approach.

So note: we don't do any special handling of failures on the websocket
(409/410). We simply retry it with REST which will handle the 409/410/etc.

Consequently, we don't want to decrement our retry count for websocket sends.
7 years ago
Michael Kirk 9cb25024c3 bump limit to allow more legit strings through 7 years ago
Matthew Chen 1412998b4a Rework isRTL. 7 years ago
Michael Kirk 16df4f589e conversation colors
// FREEBIE
7 years ago
Michael Kirk 266469163e Merge tag '2.27.0.7' 7 years ago
Michael Kirk 57e3d0d5f9 Revert "Revert "Disable contact sharing.""
This reverts commit 91af7d3855.
7 years ago
Matthew Chen 16a1dcfb77 Respond to CR. 7 years ago
Michael Kirk 3bee54dbef Merge tag '2.27.0.6' 7 years ago
Matthew Chen a6dbb7704a Remove overzealous assert in search finder. 7 years ago
Matthew Chen fc299b8700 Use UI database connection throughout the conversation cells. 7 years ago
Matthew Chen ac6f78a5fc Tweak message cells. 7 years ago
Michael Kirk e88dc15255 Fix failing assert: only set state on main thread
MessageSender completion queue is not the main queue.

// FREEBIE
7 years ago
Matthew Chen 700e9fa491 Improve logging around deserialization exceptions. 7 years ago
Michael Kirk 0bc88666c8 Show legal terms link
// FREEBIE
7 years ago
Michael Kirk 737598c731 Return unknown object from deserializer
// FREEBIE
7 years ago
Matthew Chen ebcc435c9f Clean up ahead of PR. 7 years ago
Matthew Chen 87ea1dcae1 Clean up ahead of PR. 7 years ago
Matthew Chen 08ca4fdb50 Lazy-load contact avatar data and images. Use NSCache for avatar images. 7 years ago
Matthew Chen 83f11ad79b Don't cache CNContact. 7 years ago
Matthew Chen 12295bd8c5 Don't cache CNContact. 7 years ago
Matthew Chen a7d712d1b2 Respond to CR. 7 years ago
Matthew Chen e507256e52 Outage detection. 7 years ago
Matthew Chen c96e2bb8b4 Outage detection. 7 years ago
Matthew Chen 20b1a2606e Outage detection. 7 years ago
Matthew Chen 776b5abed1 Handle edge cases around unread indicator & contact offers. 7 years ago
Matthew Chen 463a323585 Image content types. 7 years ago
Matthew Chen 1607aa7f57 Image content types. 7 years ago
Matthew Chen 4abaed0e6d Tidy up type checking in database views. 7 years ago
Matthew Chen b88254244a Respond to CR. 7 years ago
Matthew Chen 2e6b4899a7 Remove TSRecipient. 7 years ago
Matthew Chen 21a9ce3b20 Ensure TSRecipient can be deserialized. 7 years ago
Matthew Chen f1708c0b30 Improve logging around deserialization failures. 7 years ago
Matthew Chen 7f346326f6 Add re-registration UI. 7 years ago
Matthew Chen bc6a4ea8d8 Add re-registration UI. 7 years ago
Matthew Chen fc4763673f Improve de-registration checks in socket manager. 7 years ago
Matthew Chen b0646e8bff Track and persist 'is de-registered' state. 7 years ago
Matthew Chen 985f735f1a Track and persist "is de-registered" state. 7 years ago
Matthew Chen 28047abb6a Tweak database reset. 7 years ago
Matthew Chen 18a8efe1a9 Respond to CR. 7 years ago
Michael Kirk c48f2404a3 Fix overzealous assert
// FREEBIE
7 years ago
Michael Kirk a346465db5 tune down logging
// FREEBIE
7 years ago
Matthew Chen 40e5bcc23f Respond to CR. 7 years ago
Matthew Chen e8d0d9ecc0 Index oversize text for search. 7 years ago
Matthew Chen dd49c6225f Auto-size contact cells everywhere. 7 years ago
Matthew Chen f8e785ef72 Merge tag '2.26.0.25' 7 years ago
Michael Kirk a91b6b35e2 update UI DB to latest before showing CVC
// FREEBIE
7 years ago
Matthew Chen c8f2201a37 Respond to CR. 7 years ago
Matthew Chen 527e2715d4 Elaborate the search tests. 7 years ago
Matthew Chen 5c42e4c59e Improve search query construction. 7 years ago
Matthew Chen 755d30254e Improve search query construction. 7 years ago
Matthew Chen 153f3fc0a5 Improve search query construction. 7 years ago
Matthew Chen a51e9b78b0 Improve search query construction. 7 years ago
Matthew Chen f5a5d84edc Filter search index text. 7 years ago
Matthew Chen b5e0265758 Filter search index text. 7 years ago
Michael Kirk 0a17246737 Don't use group name in message.
// FREEBIE
7 years ago
Michael Kirk 95b1dced18 add: messages in Book Club will disappear in 1 minute
Show different message when joining group with disappearing messages
7 years ago
Michael Kirk 0cf751d34f Newly added group members should have expire time
Send expire timer with group info updates and in group updates that add a user.
7 years ago
Michael Kirk 74b741e9de Update timer
// FREEBIE
7 years ago
Matthew Chen f9f931fc2d Fix assert around failing sync message sends. 7 years ago
Matthew Chen c8fee4efa7 Add swift logging to SSK. 7 years ago
Matthew Chen d5c738af2f Clean up websocket logging. 7 years ago
Matthew Chen 44b23d44fd Respond to CR. 7 years ago
Matthew Chen 37d3dfdfb6 Merge tag '2.26.0.23' 7 years ago
Michael Kirk dff8d7bf97 Moving code around
// FREEBIE
7 years ago
Michael Kirk f57a5dbc77 Match searches for national number format
// FREEBIE
7 years ago
Michael Kirk 8c88382f37 less call logging
// FREEBIE
7 years ago
Óscar Morales Vivó 51a9841144 https://github.com/signalapp/Signal-iOS/issues/3455: Treat AMR files as generic attachments (AVFoundation doesn't support playback) 7 years ago
Matthew Chen 91af7d3855 Revert "Disable contact sharing."
This reverts commit cb603d0bad.
7 years ago
Michael Kirk fff8474150 adapt to rebase conflicts 7 years ago
Michael Kirk f415827da6 Contact search results
// FREEBIE
7 years ago
Michael Kirk 729befa5cb CR: Cap max search results
// FREEBIE
7 years ago
Michael Kirk b3705196b3 remove unused code/comments 7 years ago
Michael Kirk 13c43c2520 search groups by member name, cleanup tests
// FREEBIE
7 years ago
Michael Kirk 3a03c4f74c WIP: message indexing 7 years ago
Michael Kirk b00e5a4fd9 Fuzzier search matching
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[ ] group thread est: actual:
      -[x] group name actual: e.25
      -[ ] group member name: e.25
      -[ ] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[ ] messages e1
      -[ ] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
   -[x] wire up matchs
   -[] style contact cell
   -[] style conversation cell
   -[] style messages cell
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] go to next search result in thread e2
  -[] No Results page
  -[] Hide search unless pulled down
7 years ago
Michael Kirk a9e2834d9f WIP: FTS - rudimentary show results
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[ ] group thread est: actual:
      -[x] group name actual: e.25
      -[ ] group member name: e.25
      -[ ] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[ ] messages e1
      -[ ] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
   -[x] wire up matchs
   -[] style contact cell
   -[] style conversation cell
   -[] style messages cell
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] go to next search result in thread e2
  -[] No Results page
  -[] Hide search unless pulled down
7 years ago
Michael Kirk 1db1d76d98 Merge branch 'mkirk/fix-build-warnings' 7 years ago
Michael Kirk 7df158120b Fix build warnings: mark initWithCoder as designated.
// FREEBIE
7 years ago
Matthew Chen afc2cabe90 Merge remote-tracking branch 'origin/hotfix/2.25.3' 7 years ago
Matthew Chen 16cee92ca1 Suppress legal links. 7 years ago
Matthew Chen 7cc46a06fa Rebuild finder index. 7 years ago
Matthew Chen 0dcde9516e Suppress legal links. 7 years ago
Michael Kirk 626573a8a9 Revert "Revert "Disable contact sharing.""
This reverts commit 6e0d92e039.
7 years ago
Matthew Chen b59140cb3f Revert some of the socket sending logging. 7 years ago
Matthew Chen 3fe63726e0 Improve logging around socket messages. 7 years ago
Matthew Chen e7ca98fcfe Improve logging around socket messages. 7 years ago
Matthew Chen 6bc145ce3a Fix more build warnings. 7 years ago
Michael Kirk 00f8ea4ff8 Use a single ui connection to share cache.
Primarly two things:
1. using an extension for the first time per connection is slow
2. fetching the same objects (e.g. if you leave/re-enter the same
conversation)

// FREEBIE
7 years ago
Matthew Chen 9a08afae28 Fix build warnings. 7 years ago
Matthew Chen 3cd6a33aa6 Fix build warnings. 7 years ago
Matthew Chen fefc9843b1 Modify views to observe changes when active, not just foreground. 7 years ago
Matthew Chen d62725d3b7 Add reported application state. 7 years ago
Matthew Chen ad8a713566 Merge tag '2.25.2.4' 7 years ago
Matthew Chen 61ec865b6d Respond to CR. 7 years ago
Matthew Chen 4342b04bd3 Include response data in 'request over websocket' failures. 7 years ago
Matthew Chen f7abcc9064 Respond to CR. 7 years ago
Matthew Chen caad6f796e Clean up ahead of PR. 7 years ago
Matthew Chen 4d498563e7 Unify the socket manager's 'can send requests' logic. 7 years ago
Matthew Chen 1466852329 Revert "Add temporary verbose logging around message creation."
This reverts commit 7200a8dc4d.
7 years ago
Matthew Chen 7200a8dc4d Add temporary verbose logging around message creation. 7 years ago
Matthew Chen 21b54bee4f Fix breakage from recents changes in share extension. 7 years ago
Matthew Chen 08affb4400 Merge branch 'hotfix/2.25.2' 7 years ago
Matthew Chen 90f0681198 Update legal URL. 7 years ago
Michael Kirk 9a34c6804c policy links
// FREEBIE
7 years ago
Michael Kirk 4c9808d1a1 Fix iPhoneX layout show status bar above call banner
// FREEBIE
7 years ago
Michael Kirk 966b1ac84b Treat `id` as reserved word, use consistent setter style
// FREEBIE
7 years ago
Michael Kirk 84776f2757 Start timers for migrated messages
// FREEBIE
7 years ago
Matthew Chen 1343e4bc19 Preserve legacy outgoing message state; special case contact thread messages. 7 years ago
Matthew Chen d4fe671261 Respond to CR. 7 years ago
Matthew Chen 0a41684374 Respond to CR. 7 years ago
Matthew Chen dc36ae134d Respond to CR. 7 years ago
Matthew Chen 1a441cc40c Respond to CR. 7 years ago
Matthew Chen 6a1bb3f04c Add web sockets protos to proto make file. 7 years ago
Matthew Chen b50561a5b6 Use websocket for sends. 7 years ago
Matthew Chen 5ff984ab16 Use websocket for sends. 7 years ago
Matthew Chen fa36f2fb10 Use websocket for sends. 7 years ago
Matthew Chen 8a76e778b5 Use websocket for sends. 7 years ago
Matthew Chen 5f1682deab Use websocket for sends. 7 years ago
Matthew Chen a5c42ecca8 Clean up ahead of CR. 7 years ago
Matthew Chen 3967a5ab05 Call lifecycle edge cases. 7 years ago
Matthew Chen 6e0d92e039 Revert "Disable contact sharing."
This reverts commit cb603d0bad.
7 years ago
Matthew Chen efb0769c6f Disable contact sharing. 7 years ago
Matthew Chen e2d9c1187a Fix "group avatar doesn't update after local change." 7 years ago
Matthew Chen 2f8b5b8ea2 Move app state check to main thread. 7 years ago
Matthew Chen 7254d92601 Revert "Disable contact sharing."
This reverts commit cb603d0bad.
7 years ago
Matthew Chen cb603d0bad Disable contact sharing. 7 years ago
Michael Kirk c0ddcc7919 Only clean up messages while active
// FREEBIE
7 years ago
Michael Kirk af8ddf7bf0 Use raw text when localization fails
// FREEBIE
7 years ago
Matthew Chen cbc27f1c30 Revert "Disable contact sharing."
This reverts commit 2b6b8c2f69.
7 years ago
Matthew Chen 2b6b8c2f69 Disable contact sharing. 7 years ago
Matthew Chen 1a3737d5c6 Respond to CR. 7 years ago
Matthew Chen 530983c161 Build & enqueue network requests async. 7 years ago
Michael Kirk f652ecef99 localize _Main_ and other CN label types
// FREEBIE
7 years ago
Matthew Chen a62e86c7ab Revert "Disable contact sharing."
This reverts commit e27af7a66d.
7 years ago
Matthew Chen e27af7a66d Disable contact sharing. 7 years ago
Matthew Chen 986e3e0925 Revert "Disable contact sharing."
This reverts commit e138c73bdc.
7 years ago
Matthew Chen e138c73bdc Disable contact sharing. 7 years ago
Matthew Chen b74f545a64 Fix profile key protos. 7 years ago
Michael Kirk 54f7373037 Clean up logging, start messages timer regardless of current
configuration

// FREEBIE
7 years ago
Matthew Chen 4949ade274 Revert "Disable contact sharing."
This reverts commit e8b41789d7.
7 years ago
Matthew Chen e6dceffdbd Respond to CR. 7 years ago
Matthew Chen 5c7b98e5c4 Improve handling of unregistered users. 7 years ago
Matthew Chen e8b41789d7 Disable contact sharing. 7 years ago
Matthew Chen 8489c55fde Mark send-to-self as sent. 7 years ago
Matthew Chen 9c2f619132 Don't echo messages sent to self 1:1. 7 years ago
Matthew Chen 81a40909f4 Respond to CR. 7 years ago
Michael Kirk 742492dd32 remove redundant protocol definition
`debugDescription` is defined on all NSObjects (but as a property)

// FREEBIE
7 years ago
Matthew Chen 8cdb75d52a Respond to CR. 7 years ago
Matthew Chen 8337c3bd68 Refine contact merging. 7 years ago
Matthew Chen 6460493669 Surface organization name in contact view. 7 years ago
Matthew Chen aa7cc4633a Rework contact names. 7 years ago
Michael Kirk 407ec997ab Add comment per CR
// FREEBIE
7 years ago
Michael Kirk 7631315227 Remove unused code
// FREEBIE
7 years ago
Michael Kirk a16040f19f Fix avatar sending in SAE
// FREEBIE
7 years ago
Michael Kirk ed2945126a Remove contact share avatars upon message deletion
// FREEBIE
7 years ago
Michael Kirk c15fea4eca merge avatar with existing
// FREEBIE
7 years ago
Michael Kirk 95b93115f9 Code formatting
// FREEBIE
7 years ago
Michael Kirk bf37f41164 Move CNContact logic into our system contact adapter
// FREEBIE
7 years ago
Michael Kirk b1f3324514 cleanup contact syncing
It's largely a redundant check anyway, but the previous typo was a
no-op.

// FREEBIE
7 years ago
Matthew Chen b4d24f1c72 Refine field actions in contact view. 7 years ago
Matthew Chen 37da52413f Fix contact share protos: display name, organization name. 7 years ago
Matthew Chen 44ceee5849 Add contact share actions to conversation view and improve phone number parsing. 7 years ago
Michael Kirk 98aa054496 Avoid spurious "Disabled Disappearing Messages"
`dictionaryDidChange` was always true for new records.

// FREEBIE
7 years ago
Michael Kirk d3cda951ef Fix/Simplify outgoing attachment proto building
// FREEBIE
7 years ago
Matthew Chen bd116f8938 Share contacts from share extension. 7 years ago
Michael Kirk a10ae1835e respond to code review
// FREEBIE
7 years ago
Michael Kirk 77fc5571fb Implement avatar sending
// FREEBIE
7 years ago
Michael Kirk eb97e82d19 fixup debug UI 7 years ago
Michael Kirk 5ba5e98260 Show downloaded contact avatar in thread
// FREEBIE
7 years ago
Michael Kirk 48b4791b13 Download avatar attachment stream
// FREEBIE
7 years ago
Michael Kirk 3fdf703a60 PhoneNumberUtil is no longer a singleton
// FREEBIE
7 years ago
Michael Kirk 9e1a3a0da4 Consider off/on in addition to duration when becoming consistent
// FREEBIE
7 years ago
Matthew Chen 4b6239f491 Fix build breakage. 7 years ago
Matthew Chen e7eaa7945d Handle completely skipped message sends. 7 years ago
Matthew Chen 043218fb91 Ensure thread safety in phone parsing logic. 7 years ago
Matthew Chen 7c3991ebd8 Respond to CR. 7 years ago
Matthew Chen 7a9acce504 Add contact share approval view. 7 years ago
Matthew Chen 0c745dd989 Add contact share approval view. 7 years ago
Matthew Chen 1fc401d200 Respond to CR. 7 years ago
Matthew Chen b37588fc4c Provide default labels for custom contact fields. 7 years ago
Matthew Chen 1a1a043b27 Format phone numbers of contacts. 7 years ago
Matthew Chen dcf7a05986 Use default avatars for contact shares in contact view. 7 years ago
Michael Kirk a01164e8b1 Add canary assert
// FREEBIE
7 years ago
Michael Kirk ecf767ea53 canary assert 7 years ago
Michael Kirk 1dd8c41770 Only touch messages which have been read.
// FREEBIE
7 years ago
Michael Kirk 24f3362df1 ensure expirations started
// FREEBIE
7 years ago
Michael Kirk ed3db50978 clarify naming
// FREEBIE
7 years ago
Michael Kirk 242cc1138f A few lingering places were ordered with their envelope timestamp
// FREEBIE
7 years ago
Matthew Chen 8e84f89239 Respond to CR. 7 years ago
Matthew Chen 8dc3333467 Send fake contact shares. 7 years ago
Matthew Chen 390c0bc201 Send fake contact shares. 7 years ago
Matthew Chen f4ee688401 Add feature flag for contact sharing. 7 years ago
Matthew Chen ff6b45abee Respond to CR. 7 years ago
Matthew Chen fa5577eece Create contact view. 7 years ago
Matthew Chen 00eadd629f Text previews for contact shares. 7 years ago
Matthew Chen 411d5a3b4f Respond to CR. 7 years ago
Matthew Chen 708b44e3c5 Improve handling of contact display names. 7 years ago
Michael Kirk d67a3b4167 WORKS GREAT
// FREEBIE
7 years ago
Matthew Chen d1f6118e6e Rework contact normalization and validation. 7 years ago
Matthew Chen 1520422b29 Respond to CR. 7 years ago
Matthew Chen 0316a98eb8 Undo renaming of contactShare property of TSMessage. 7 years ago
Matthew Chen 147368913c Gather all contact conversion logic in OWSContacts. 7 years ago
Matthew Chen ee9a13cdf0 Update cocoapods. 7 years ago
Matthew Chen bd7c8e4a4b Add conversion methods between vcard, system contacts and ows contacts. 7 years ago
Matthew Chen 0d8cfc5403 Rename contact share class to contact. 7 years ago
Matthew Chen 796958d87f Elaborate contact conversion. 7 years ago
Matthew Chen e22e9a7842 Populate contact share protos. 7 years ago
Matthew Chen 757234d309 Populate contact share protos. 7 years ago
Matthew Chen 2a63423c3d Elaborate fake contact shares. 7 years ago
Matthew Chen 521013a674 Fix contact share property synthesis. 7 years ago
Matthew Chen 7490a55f61 Sketch out "contact share" model. 7 years ago
Matthew Chen 4b8a2fa8a3 Sketch out "contact share" model. 7 years ago
Matthew Chen 6005747856 Update protos to reflect 'share contact'. 7 years ago
Matthew Chen bb96454070 More outgoing message fixes. 7 years ago
Matthew Chen 752bca313c Fix glitches in outgoing messages. 7 years ago
Matthew Chen 8dbe4387b7 Update protos to reflect 'share contact'. 7 years ago
Matthew Chen f16e9a2920 Fix issues in outgoing messages status changes. 7 years ago
Matthew Chen 5c6f9ec088 Fix issues in outgoing messages status changes. 7 years ago
Michael Kirk 7a1d24a9ab Avatar updates when contact/profile/group photo changes
// FREEBIE
7 years ago
Matthew Chen 8f19622a89 Fix sync transcripts. 7 years ago
Matthew Chen 5773b45345 Respond to CR. 7 years ago
Matthew Chen c75c3d5f9e Respond to CR. 7 years ago
Matthew Chen 204d379603 Respond to CR. 7 years ago
Matthew Chen 4de4a4b229 Respond to CR. 7 years ago
Matthew Chen 40ac0daa9a Respond to CR. 7 years ago
Matthew Chen 6486b99415 Clean up ahead of PR. 7 years ago
Matthew Chen 9e6062f21c Rework outgoing message state. 7 years ago
Matthew Chen 9275c67818 Rework outgoing message state. 7 years ago
Matthew Chen aa35594ad5 Respond to CR. 7 years ago
Matthew Chen 67f2d6608f Detect and handle corrupt database views. 7 years ago
Matthew Chen 1a4c01ae29 Detect and handle corrupt database views. 7 years ago
Matthew Chen 212891c50d Detect and handle corrupt database views. 7 years ago
Matthew Chen f70a45ef1b Clean up ahead of PR. 7 years ago
Matthew Chen 50a59c907d Detect and handle corrupt database views. 7 years ago
Matthew Chen d3b484482c Detect and handle corrupt database views. 7 years ago
Matthew Chen d3fb5d321d Fix build break. 7 years ago
Matthew Chen c5981b164b Notify users of corrupt messages. 7 years ago
Matthew Chen fa9a4c808a Simplify usage of contacts framework. 7 years ago
Matthew Chen 7f23dfa258 Respond to CR. 7 years ago
Matthew Chen 2265ae08aa Don't start app version migrations until storage is ready. 7 years ago
Michael Kirk d1230abdc5 Fix type declaration
// FREEBIE
7 years ago
Michael Kirk 1f63ce02a0 Increase cache, remove dead code, add debug logging
// FREEBIE
7 years ago
Michael Kirk b3cd6a112b Add OWSJanksUI assertion
// FREEBIE
7 years ago
Michael Kirk 9c81eb44a1 Replace remaining UI usage of `interaction.description`
// FREEBIE
7 years ago