Commit Graph

11507 Commits (de01731316a8f3779e3088a0fb9ee3e23a01d0fb)
 

Author SHA1 Message Date
Matthew Chen 81e3dfc3cf Respond to CR. 5 years ago
Matthew Chen bb1921afe6 Simplify link preview cache. 5 years ago
Matthew Chen 04b60677a6 Simplify link preview cache. 5 years ago
Matthew Chen ae5cee2167 Clean up the link preview cache. 5 years ago
Matthew Chen f6ca66f9c6 Merge branch 'charlesmchen/removeScrollUpButton' 5 years ago
Matthew Chen 0d9b780f75 Remove scroll up button. 5 years ago
Michael Kirk 3ed2e76eb4 "Bump build to 2.38.0.9." 5 years ago
Michael Kirk d02152cf14 fix release build 5 years ago
Michael Kirk dc87ae821d "Bump build to 2.38.0.8." 5 years ago
Michael Kirk ab91fedc3e sync translations 5 years ago
Michael Kirk 4068496644 Merge branch 'charlesmchen/imageEditorVsCaptions' 5 years ago
Matthew Chen db958f4a01 Preserve caption text of edited images. 5 years ago
Michael Kirk 04ec6b9ddb Merge branch 'charlesmchen/imageEditorRenderingLayerOrder' 5 years ago
Matthew Chen d9760b6bbc Fix bug around layer ordering when rendering image editor output. 5 years ago
Michael Kirk 9835c68ec4 Merge branch 'charlesmchen/ensureTextItemOnCanvas' 5 years ago
Matthew Chen 5973c326de Ensure new text items are on the canvas. 5 years ago
Michael Kirk 675c60bf4e Merge branch 'mkirk/fix-ios9-sae-crash' 5 years ago
Michael Kirk f8244eeefe Fix SAE crash for iOS9 5 years ago
Michael Kirk 840c811b95 Merge branch 'mkirk/ios9-deprecation' 5 years ago
Michael Kirk 58d99a480f Notify iOS9 users occasionally that iOS10 will soon be required 5 years ago
Matthew Chen 53299c139f Merge branch 'charlesmchen/cdsFeedbackErrors' 5 years ago
Matthew Chen 9b34e4ac61 Respond to CR. 5 years ago
Matthew Chen c5a87c4d20 Add asserts around CDS feedback errors. 5 years ago
Michael Kirk 5cc6fc0632 Merge branch 'mkirk/ri_checks' 5 years ago
Michael Kirk 62ce0339a5 Update tags to ignore, introduce scheme for ignoring internal tags 5 years ago
Matthew Chen c3ddb4b912 Merge branch 'charlesmchen/accessibilityIdentifiers3' 5 years ago
Matthew Chen 3ce3f9faaa Add accessibilityIdentifiers to conversation settings view. 5 years ago
Matthew Chen f073dd9a52 Add accessibilityIdentifiers to conversation settings view. 5 years ago
Matthew Chen d253c5aa91 Add accessibilityIdentifiers to conversation view. 5 years ago
Matthew Chen 50888b20d2 Add accessibilityIdentifiers to 'new group thread' view. 5 years ago
Matthew Chen 4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 5 years ago
Matthew Chen 95e125d55e Simplify usage of accessibilityIdentifiers. 5 years ago
Matthew Chen 2d854406a1 Add accessibilityIdentifiers to home view. 5 years ago
Michael Kirk 2464fe230d sync translations 5 years ago
Michael Kirk 0e6647626d Merge branch 'mkirk/search-icon' 5 years ago
Michael Kirk ed6b461662 search icon 5 years ago
Michael Kirk c37fb42c7a "Bump build to 2.38.0.7." 5 years ago
Michael Kirk 753a60fe66 Merge branch 'charlesmchen/conversationViewIsDisappearing' 5 years ago
Matthew Chen a6e00c8fec Respond to CR. 5 years ago
Matthew Chen a7ae79aaad Ignore keyboard notifications while the view is disappearing or has disappeared. 5 years ago
Matthew Chen 8c345d0878 "Bump build to 2.38.0.6." 5 years ago
Matthew Chen 9cb137598a Merge branch 'charlesmchen/callsFromPhoneapp' 5 years ago
Matthew Chen 85d58d3396 Improve handling of call intents. 5 years ago
Matthew Chen 76ac745f8b Merge branch 'charlesmchen/imageEditorFixes3' 5 years ago
Matthew Chen 558b5f5816 Tap to dismiss caption editor. 5 years ago
Matthew Chen 4ea608cd45 Ensure status bar is hidden in image editor subviews. 5 years ago
Michael Kirk 607adbf261 Merge branch 'mkirk/search-qa' 5 years ago
Michael Kirk e3cc8bb101 Keep results bar visible when dismissing keyboard or returning to view. 5 years ago
Michael Kirk 2c72775815 Merge branch 'mkirk/keyboard-dismiss-bug2' 5 years ago
Michael Kirk 3850ca29b0 Bigger hack to fix problem with lesser hack.
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
5 years ago