Commit Graph

2268 Commits (aad93d2d897d74ed5809e611d720346090136ce2)

Author SHA1 Message Date
Matthew Chen 89a04852df Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 0a926567ed Respond to CR.
// FREEBIE
8 years ago
Matthew Chen c6047b72b4 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 563eed6c6e Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 530b70d706 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 841a2333e3 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 12de1aa90c Split up GIF requests.
// FREEBIE
8 years ago
Matthew Chen 55d53ae222 Split up GIF requests.
// FREEBIE
8 years ago
Matthew Chen c83090a46e Split up GIF requests.
// FREEBIE
8 years ago
Matthew Chen e4602f2a12 Split up GIF requests.
// FREEBIE
8 years ago
Matthew Chen 2dfea25243 Split up GIF requests.
// FREEBIE
8 years ago
Matthew Chen 84406b5fec Split up GIF requests.
// FREEBIE
8 years ago
Michael Kirk 259695a9fd Attachments require digest or show explanatory error.
// FREEBIE
8 years ago
Matthew Chen eb3ca43256 Jumbomoji.
// FREEBIE
8 years ago
Matthew Chen 997665a902 Hide MIME types in production builds.
// FREEBIE
8 years ago
Matthew Chen bee70fa028 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 5e1c6c02a0 Add "failed message send" badges.
// FREEBIE
8 years ago
Michael Kirk 6eeb78157a Include size in attachment pointer
// FREEBIE
8 years ago
Matthew Chen 8cb3e5d35d Fix edge cases around oversize test messages.
// FREEBIE
8 years ago
Matthew Chen 9cc4521d07 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen bcf83a4c8e Rework handling of oversize text messages.
// FREEBIE
8 years ago
Matthew Chen 5af6b6f213 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 1b3b5fc9e5 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen d1141581de Only one system contacts fetch at a time.
// FREEBIE
8 years ago
Matthew Chen 878fd3d842 Only one system contacts fetch at a time.
// FREEBIE
8 years ago
Matthew Chen 8c1dfe7ee6 Only one system contacts fetch at a time.
// FREEBIE
8 years ago
Michael Kirk 8f9311a6ac Show timer in navbar without reload
// FREEBIE
8 years ago
Michael Kirk 709010499f remove overzealous assert
// FREEBIE
8 years ago
Matthew Chen 7e585b72aa Fix tests broken by the JSQ rewrite.
// FREEBIE
8 years ago
Michael Kirk 2d7deff839 Make message bubbles a bit wider.
// FREEBIE
8 years ago
Michael Kirk cd291e19ff We conceivably want to to initiate calls more than once without leaving
the conversation view. e.g. from Contacts.app

// FREEBIE
8 years ago
Michael Kirk 4000760cf7 Fix "back button count" flash. Only call once.
This affects returning from message info or when leaving conversation
settings.

// FREEBIE
8 years ago
Matthew Chen df7d40ed4c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen a23b8b717b RTL fixes for JSQ rewrite.
// FREEBIE
8 years ago
Michael Kirk 43dd3abf6c clamp value per CR
// FREEBIE
8 years ago
Michael Kirk 59b125c3fb Add clarifying comment per CR
// FREEBIE
8 years ago
Michael Kirk d87f000051 Interactive/Cancelable slide left for details
// FREEBIE
8 years ago
Matthew Chen 6b2f7e4842 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen fb3bb852ca Tap image attachment preview to view full screen.
// FREEBIE
8 years ago
Matthew Chen 722fc4d7a7 Fix size of message previews.
// FREEBIE
8 years ago
Matthew Chen be0149ccf2 Update layout of views to reflect keyboard.
// FREEBIE
8 years ago
Matthew Chen 0eafbd8fe4 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 188b733d57 Don't send with return key.
// FREEBIE
8 years ago
Matthew Chen 27af310235 Auto-dismiss keyboard if user scrolls away from bottom of the conversation.
// FREEBIE
8 years ago
Matthew Chen 3fa2f22beb Fixes for input toolbar.
// FREEBIE
8 years ago
Matthew Chen c9e385920a Fix spacing around date headers.
// FREEBIE
8 years ago
Matthew Chen 429f833913 Center the progress bar within the bubble mask.
// FREEBIE
8 years ago
Matthew Chen 658c3c5599 Only show attachment upload UI for not-yet-uploaded attachments.
// FREEBIE
8 years ago
Matthew Chen 067b16903c Fix attachment uploads.
// FREEBIE
8 years ago
Matthew Chen c1f35a0ea6 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 2fa3cf1bc6 Rework attachment approval UI.
// FREEBIE
8 years ago
Matthew Chen cbb0030b12 Rework attachment approval UI.
// FREEBIE
8 years ago
Matthew Chen d04f9111db Rework attachment approval UI.
// FREEBIE
8 years ago
Michael Kirk 1fee5d97e6 Merge branch 'release/2.18.0' 8 years ago
Matthew Chen a1d8c7765d Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 54c56f1c4b Fix layout of generic and audio messages.
// FREEBIE
8 years ago
Matthew Chen a16197f193 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b1b0ddbf2e Fix layout glitches in JSQ rewrite.
// FREEBIE
8 years ago
Michael Kirk 21df2dc047 Never hide "failed to send" footer
// FREEBIE
8 years ago
Daniel e8f92ede60 added accessibility labels for call screen controls FREEBIE
Added Prefix

combined similar labels to CALL_VIEW_MUTE_LABEL
8 years ago
Michael Kirk bd4b4f0041 Use proper color when messages fail to send.
// FREEBIE
8 years ago
Michael Kirk c5244e175e orphan cleanup shouldn't happen until DB is registered
// FREEBIE
8 years ago
Michael Kirk f3f0d591ea Revert "Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons."
This reverts commit 7c82f6d448.

This wasn't helping our crash rate, and on my device, as of iOS11.1B2,
the button is easily tappable, not detectably different from prior iOS
releases.
8 years ago
Michael Kirk 66ab4e2549 Merge tag '2.16.2.0' into release/2.18.0 8 years ago
Michael Kirk 2d10080c33 Merge tag '2.17.1.1' into release/2.18.0 8 years ago
Michael Kirk 68e755ade9 Merge branch 'release/2.18.0' 8 years ago
Matthew Chen c11b82ba30 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 9274d7fd9b Fix proxying of Giphy requests.
// FREEBIE
8 years ago
Michael Kirk 0cd56d4bcc On iOS11 doc picker requires system appearance.
Otherwise nav items are illegible.

// FREEBIE
8 years ago
Michael Kirk 64c7c40b81 CR: add shadow to activity indicator
// FREEBIE
8 years ago
Michael Kirk 2af99eb710 Allow canceling GIF download
// FREEBIE
8 years ago
Michael Kirk 891cc6ee0d CR: better method names
// FREEBIE
8 years ago
Michael Kirk 6eaa49593d preview vs. sending have independent resolution min
// FREEBIE
8 years ago
Michael Kirk 688810c267 CR: Enforce "one time only" with a bool, not a cell ref
Since cell's can be re-used, at a later point, we might not be
referencing the data we intend. Since all we want to do is enforce a
"one time only" check, just use a bool.

// FREEBIE
8 years ago
Michael Kirk 591cba6468 fix comment typos
// FREEBIE
8 years ago
Michael Kirk a01de44917 Fix intermittent crash
// FREEBIE
8 years ago
Michael Kirk 6db5895269 dismiss keyboard when scrolling after auto-search
// FREEBIE
8 years ago
Michael Kirk be51776d82 Fix mask appearing partially above search bar
// FREEBIE
8 years ago
Michael Kirk 37177de7cb Make sure user knows what they're picking
Abort selection until *some* kind of asset has been downloaded.

// FREEBIE
8 years ago
Michael Kirk e4ad169d71 Show retryable error alert when fetching GIF fails
// FREEBIE
8 years ago
Michael Kirk 3939e8a6ac Download picked GIF faster: cancel pending request
// FREEBIE
8 years ago
Michael Kirk b8ce636afc Show loading screen while selected GIF downloads
// FREEBIE
8 years ago
Michael Kirk ddf2fe21a1 Download smaller GIF for previews.
Previously we were downloading a full sized GIF for each cell, which can
take dozens of seconds on a slower connection. Now we download a smaller
GIF for the picker view, and only download the full sized GIF for the
selected cell.

Some stats:

Before:

Scenario: search "Cat" and no scrolling, no picking
~10 MB

Scenario: search "Cat" and no scrolling, then pick
~10 MB

Scenario: search "Cat" and scroll 3 screens, no picking
~30 MB

Scenario: search "Cat" and scroll 3 screens, then pick
~30 MB

After:

Scenarios: search "Cat" and no scrolling, no picking
~1.0 MB (savings 90%)

Scenarios: search "Cat" and no scrolling, then pick
~3.5 MB (savings 65%)

Scenarios: search "Cat" and scroll 3 screens, no picking
~3.0 MB (savings 90%)

Scenarios: search "Cat" and scroll 3 screens, then pick
~5.5 MB (savings 81%)

// FREEBIE
8 years ago
Michael Kirk 2a4c6506fb log giphy data usage in debug
// FREEBIE
8 years ago
Matthew Chen 7fa7d5d526 Fix "mark as read."
// FREEBIE
8 years ago
Matthew Chen b0aa84e420 Clean up conversation view.
// FREEBIE
8 years ago
Matthew Chen d355b45bae Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
8 years ago
Matthew Chen c2608785e1 Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
8 years ago
Matthew Chen 4dc6934fc7 End text editing if we leave conversation view.
// FREEBIE
8 years ago
Matthew Chen bd5639baaf Linkify text messages.
// FREEBIE
8 years ago
Matthew Chen bf80e6dd36 Fix broken message cell layout.
// FREEBIE
8 years ago
Matthew Chen 45ba79d296 Auto-load more message if user scrolls near the top of the conversation.
// FREEBIE
8 years ago
Matthew Chen 1ad3add1d5 Fix message injection.
// FREEBIE
8 years ago
Matthew Chen c7097db939 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen f28abbc2a1 Revert from numeric to default keyboard after message send.
// FREEBIE
8 years ago
Matthew Chen 4dabb71815 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Matthew Chen fb4d43d542 Fix "can't send same GIF twice" issue.
// FREEBIE
8 years ago
Matthew Chen f3102e2761 Fix presentation animation of new "attachment approval" state of input toolbar.
// FREEBIE
8 years ago
Matthew Chen 0fe76aaab8 Move "attachment approval" into input toolbar.
// FREEBIE
8 years ago
Matthew Chen 298a4aa108 Simplify and fix edge cases around menu controller.
// FREEBIE
8 years ago
Matthew Chen 06eb794db6 Simplify and fix edge cases around long pressing on system message cells.
// FREEBIE
8 years ago
Matthew Chen 37841d9b67 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 4a94d039e8 Restore the input toolbar's placeholder text.
// FREEBIE
8 years ago
Matthew Chen c47573334b Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 3b945a9da2 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 88c874e4e6 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 257f8249bf Cull cached cell media outside a load window.
// FREEBIE
8 years ago
Matthew Chen 65efa7f836 Lazy load, eagerly unload & cache cell media.
// FREEBIE
8 years ago
Matthew Chen e77292c2a9 Add contentWidth property to ConversationViewCell.
// FREEBIE
8 years ago
Erik Strottmann d7f24e4808 Increase profile disclosure compression resistance
Prevents disclosure indicator in profile row of settings from collapsing
when the profile name is too long.

Fixes #2515.

// FREEBIE
8 years ago
Matthew Chen b269c72acb Respond to CR.
// FREEBIE
8 years ago
Matthew Chen f36ecbdfa6 Button locations in input toolbar should reflect RTL.
// FREEBIE
8 years ago
Matthew Chen cec614706e Button locations in input toolbar should reflect RTL.
// FREEBIE
8 years ago
Matthew Chen 2ec8522355 Fix the input toolbar.
// FREEBIE
8 years ago
Matthew Chen b9f6bbb369 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 163e66dd4f Restore "load more messages" functionality.
// FREEBIE
8 years ago
Matthew Chen ccb37bfac3 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen ae550fa960 Add actions to debug UI to inject fake incoming messages.
// FREEBIE
8 years ago
Matthew Chen ed350f8ea6 Add vertical scroll indicator to conversation view.
// FREEBIE
8 years ago
Matthew Chen a386ac5685 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b90e9fcd64 Skip redundant GIF searches.
// FREEBIE
8 years ago
Matthew Chen 33d3c4123a Progressive GIF search shouldn't dismiss keyboard.
// FREEBIE
8 years ago
Matthew Chen 032ec59d1c Respond to CR.
// FREEBIE
8 years ago
Matthew Chen 01691b7ade Ensure attachment masking is updated to reflect cell relayout.
// FREEBIE
8 years ago
Matthew Chen 212d5dd112 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen ae27d062f6 Clamp content aspect ratio.
// FREEBIE
8 years ago
Matthew Chen b6a61afd5c Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 46dc0acdfb Fix media cropping.
// FREEBIE
8 years ago
Matthew Chen 132d5b3408 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen e91599d986 Restore message cell footers.
// FREEBIE
8 years ago
Matthew Chen 3723a4845f Restore message cell footers.
// FREEBIE
8 years ago
Matthew Chen c2f07bb3d8 Restore message cell footers.
// FREEBIE
8 years ago
Matthew Chen 227fd5280d Resize conversation view cells as necessary.
// FREEBIE
8 years ago
Matthew Chen f7bd813c9f Restore the date headers to the conversation view cells.
// FREEBIE
8 years ago
Michael Kirk 6e12b9c898 Fix trailing edge of group member listing
// FREEBIE
8 years ago
Michael Kirk 603a7d2639 Merge branch 'release/2.18.0' 8 years ago
Michael Kirk ab05bd32e8 compose search cleanup per code review
// FREEBIE
8 years ago
Michael Kirk 0f859d6b20 Merge branch 'release/2.18.0' 8 years ago
Michael Kirk 9ae4a26eb1 Message details shows entire message
When viewing a longer message, to avoid the risk of the user not being
aware they can scroll down, we scroll to the last couple lines of the
message, ensuring they can see the meta-data.

// FREEBIE
8 years ago
Michael Kirk 038ca0d6a9 Fix invite via SMS in search
- whispersystems.org -> signal.org
- nav color was wrong since iOS10
- update search results after clearing post SMS invite

// FREEBIE
8 years ago
Michael Kirk 6a65ee6def Pull to refresh on homeview fetches messages.
This is useful when you're using censorship circumvention and unable to
receive push notifications.

// FREEBIE
8 years ago
Michael Kirk 3080cb512b Compose View: collation index and group search
- Include table index for contacts
- Fix extra spacing in OWS table view
- Separate search results into contact/invite sections
- Include groups in search results when composing new message
- Compose Screen search matches on group member names

// FREEBIE
8 years ago
Matthew Chen 7c82f6d448 Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons.
// FREEBIE
8 years ago
Matthew Chen 49501a5d1b Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b1624d6818 Respond to CR.
// FREEBIE
8 years ago
Matthew Chen b833976b77 Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen 5621fe893c Clean up ahead of PR.
// FREEBIE
8 years ago
Matthew Chen fb408f980c Remove JSQ.
// FREEBIE
8 years ago
Michael Kirk 796be18c56 enable gif picker
// FREEBIE
8 years ago
Michael Kirk dd5a19d1fd Suspend while answering shows "Missed Call"
When awakened by a voip push, we get some arbitrary amount of background
time to connect the call (in practice this is ~30s) before the app is
suspended.

Though we were properly terminating the call upon being suspended, we
were not notifying the user that they had missed a call.

// FREEBIE
8 years ago