Commit Graph

8584 Commits (7e8b2e30346ea7541ac21dbff258a8f845adba8b)
 

Author SHA1 Message Date
Michael Kirk 7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
7 years ago
Michael Kirk ae44b316aa Merge branch 'mkirk/show-message-actions-on-call' 7 years ago
Michael Kirk bc2ba63c21 DRY refactor 7 years ago
Michael Kirk 37738c24c5 Allow menuActions + callBanner
// FREEBIE
7 years ago
Michael Kirk 495ed56676 Merge branch 'mkirk/cleanup-longview' 7 years ago
Michael Kirk 464b854eb1 CR: follow naming conventions 7 years ago
Michael Kirk 9c9f3875a7 Link styling 7 years ago
Michael Kirk 5148747c12 clean up long text VC 7 years ago
Michael Kirk c8c2b8c640 Merge branch 'mkirk/swift-assert-main-thread' 7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Michael Kirk aabf9e79e8 Merge branch 'mkirk/async-search' 7 years ago
Michael Kirk 781c535327 weak capture self 7 years ago
Michael Kirk fc7dc03cee don't block main thread during search
// FREEBIE
7 years ago
Michael Kirk 65fe3cc1d2 Merge branch 'mkirk/debug-protos' 7 years ago
Michael Kirk 2fc3a211f1 restrict debug methods 7 years ago
Michael Kirk 1295a09ab3 add comment 7 years ago
Matthew Chen b75bc27d55 Respond to CR. 7 years ago
Matthew Chen c6132249e6 Respond to CR. 7 years ago
Matthew Chen cb827169fb Respond to CR. 7 years ago
Michael Kirk 1bf273eb3a Merge branch 'mkirk/theme-message-actions-overlay' 7 years ago
Michael Kirk eaf8d789fb Darken message actions overlay in dark theme 7 years ago
Michael Kirk 1fc5ebdc16 Merge branch 'mkirk/search-bar-theme-2' 7 years ago
Michael Kirk 1743407cc2 Code cleanup per code review 7 years ago
Michael Kirk e4b7d253a3 Theme "no results" cell 7 years ago
Michael Kirk 3022f92925 Tweak tint for search bar icons in dark theme 7 years ago
Michael Kirk 75bb9b60db Alternative dark theme search bar
Rather than our custom class, we can get pretty far using existing UISearchBar
styling, and then apply the final tweak, the search bar text field background
color by traversing the view.

This fixes a couple issues:

1. There was a small wavering in height of the custom search bar
2. When your table header view is a UISearchBar you get nice scroll "snapping"
   when showing/hiding the search bar.
7 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
7 years ago
Matthew Chen bc7efaf4ad "Bump build to 2.29.0.16." 7 years ago
Matthew Chen 4971d40c75 Respond to CR. 7 years ago
Matthew Chen 10ab97bb6c "Bump build to 2.29.0.15." 7 years ago
Matthew Chen 501b5a7c97 Merge branch 'charlesmchen/themeQuotedReplies' 7 years ago
Matthew Chen 9e21612298 Respond to CR. 7 years ago
Matthew Chen 6dd474d794 Theme quoted replies. 7 years ago
Matthew Chen a92fca5c13 Theme quoted replies. 7 years ago
Matthew Chen 7b835bd08e Merge branch 'mkirk/fix-toolbar-appearance' 7 years ago
Michael Kirk 32f8795342 media tile toolbar respects theme by using UIAppearance defaults 7 years ago
Michael Kirk 61dc39b696 Merge branch 'mkirk/quote-2' 7 years ago
Michael Kirk 93cb378f7a constantize toast inset 7 years ago
Michael Kirk 06a8bffa66 Never show more than one toast view 7 years ago
Michael Kirk 75ead2ac09 quoted reply: distinguish "not found" vs. "no longer available" 7 years ago
Matthew Chen fb9958b1da "Bump build to 2.29.0.14." 7 years ago
Matthew Chen 122e138f07 Merge branch 'charlesmchen/disableCDS' 7 years ago
Matthew Chen 2b8b688fb6 Disable CDS. 7 years ago
Matthew Chen 2af0a897e1 Disable CDS. 7 years ago
Michael Kirk cbdc46fdab Merge branch 'mkirk/dark-keyboard' 7 years ago
Michael Kirk b80d88c824 theme attachment approval keyboard
// FREEBIE
7 years ago
Michael Kirk 5907cd2a0d Merge branch 'mkirk/tap-to-retry' 7 years ago
Michael Kirk c6f77ec6ea "Tap to retry" retries, rather than maybe deletes.
Attachment downloads can fail on slow networks or if the app crashes.
It's unlikely that the users response to this would be to delete the
attachment pointer, so it doesn't make sense to surface that as a
primary action.

If a user does want to delete the attachment, as always they can
long-press to delete.

// FREEBIE
7 years ago
Michael Kirk 7b156be73b Merge branch 'mkirk/gallery-headers' 7 years ago
Michael Kirk 8cd290ba2b fix section headers not appearing on iOS11/iPhoneX
// FREEBIE
7 years ago