Matthew Chen
							
						 
						
							 
							
							
							
								
							
								49a24a4e6a 
								
							
								 
							
						 
						
							
							
								
								Improve handling of incomplete and failed attachment downloads.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								bdde3c73c5 
								
							
								 
							
						 
						
							
							
								
								Improve handling of incomplete and failed attachment downloads.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								fbd3859a85 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/removeRedPhoneCode'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								36485c9461 
								
							
								 
							
						 
						
							
							
								
								Remove RedPhone code.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								968066eff6 
								
							
								 
							
						 
						
							
							
								
								Merge pull request  #151  from WhisperSystems/mkirk/freebie-check-script  
							
							 
							
							... 
							
							
							
							post commit which double checks for freebie presence 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								708dca282e 
								
							
								 
							
						 
						
							
							
								
								post commit which double checks for freebie presence  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								9e0f777556 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/oversizeTextMessages'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								75fabe5c25 
								
							
								 
							
						 
						
							
							
								
								Add support for oversize text messages sent as attachments.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								334912a48f 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/filterCountryCodes'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								d38f6fbfd1 
								
							
								 
							
						 
						
							
							
								
								Filter out country codes properly.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								28e2639dc5 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/swiftDataWriteCrash'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								f005b66fa5 
								
							
								 
							
						 
						
							
							
								
								code review: move unnecessary __block allocation  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								a730381424 
								
							
								 
							
						 
						
							
							
								
								Fix crash writing a "swift" NSData on iOS 9.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								97a66f30f2 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/messageSenderDeadlock'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								607dd9a2f2 
								
							
								 
							
						 
						
							
							
								
								Avoid YapDatabase deadlock in OWSMessageSender.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								63cc0328b5 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'mkirk/better-envelope-logging'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								b73594b234 
								
							
								 
							
						 
						
							
							
								
								Better envelop logging.  
							
							 
							
							... 
							
							
							
							Previously it was basically impossible to trace recipients in debug
logs.
// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								1fd7627daf 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/sendQueuePerConvo'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								5739f71bd4 
								
							
								 
							
						 
						
							
							
								
								Respond to CR.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								c3d2ea7abd 
								
							
								 
							
						 
						
							
							
								
								Use a separate sending queue for each conversation.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								289d0df064 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/sendToSelfVsIncompleteOperation'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								62d52ce9a0 
								
							
								 
							
						 
						
							
							
								
								Fix “send to self operations never complete” issue.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								d31cfe6fd6 
								
							
								 
							
						 
						
							
							
								
								Ensure existing sessions are invalidated when saving new identity  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								4dc18f2f03 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/phoneNumberParsingTweaks'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								5846131976 
								
							
								 
							
						 
						
							
							
								
								Further refinements to phone number parsing.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								5dc4938746 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/decryptionExceptionLogging'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								7f681e964b 
								
							
								 
							
						 
						
							
							
								
								Improve logging around decryption exceptions.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								cdef86e276 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/websocketEdgeCases'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								a1e5019370 
								
							
								 
							
						 
						
							
							
								
								Respond to CR.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								e92d40a127 
								
							
								 
							
						 
						
							
							
								
								Fix edge cases around the websocket lifecycle.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								0f47dc6200 
								
							
								 
							
						 
						
							
							
								
								Fix edge cases around the websocket lifecycle.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								5cbaafe38a 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/maxIncomingAttachmentFileSize'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								04a3e4323c 
								
							
								 
							
						 
						
							
							
								
								Respond to CR.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								8231f79977 
								
							
								 
							
						 
						
							
							
								
								Don’t check content length header until we’ve received at least one byte of the attachment download.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								2c61943537 
								
							
								 
							
						 
						
							
							
								
								Abort attachment downloads of excessive size.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								d3af0d3a27 
								
							
								 
							
						 
						
							
							
								
								Merge pull request  #135  from WhisperSystems/mkirk/fix-attachment-dispatch  
							
							 
							
							... 
							
							
							
							Only call sendMessage on main thread. 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								29a0597b0c 
								
							
								 
							
						 
						
							
							
								
								Only call sendMessage on main thread.  
							
							 
							
							... 
							
							
							
							The proximate cause for this change was a failing assert in the recently
introduced call to `setBackgroundTaskIdentifier` which is synchronized
on the main thread.
But generally, to keep things simple, we prefer calling back on main
thread unless performance dictates otherwise.
// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								ca5bcaf3c2 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'mkirk/refactor_country_code_search'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								c8fa47d9c9 
								
							
								 
							
						 
						
							
							
								
								Added some tests per CR  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								d3ecbba0e8 
								
							
								 
							
						 
						
							
							
								
								Keep unit tests with their class files  
							
							 
							
							... 
							
							
							
							Moved from Signal-iOS and updated to use standard XCTest macros vs. our
test-util's
// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Thomas Guillet
							
						 
						
							 
							
							
							
								
							
								478b5b247a 
								
							
								 
							
						 
						
							
							
								
								Remove convoluted dependency  
							
							 
							
							... 
							
							
							
							of PhoneNumberUtil to ContactsManagerProtocol
Also moved tests from Signal-iOS repository here. 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								778d3dd2bc 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'mkirk/background-sending'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								58829e2162 
								
							
								 
							
						 
						
							
							
								
								ensure we don't interrupt sending by being backgrounded  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								15f5c078a1 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'mkirk/nsoperation-sending-queue'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								e68ee28e51 
								
							
								 
							
						 
						
							
							
								
								Add clarifying asserts per code review  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								db15ff5e87 
								
							
								 
							
						 
						
							
							
								
								Save message before sending starts.  
							
							 
							
							... 
							
							
							
							Otherwise the message doesn't get saved until it's in the queue.
Interestingly, this could also address some of the perceived lag
mentioned in: https://github.com/WhisperSystems/Signal-iOS/pull/1850 
// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								df51523a84 
								
							
								 
							
						 
						
							
							
								
								Serialize message sending and generalized retry logic.  
							
							 
							
							... 
							
							
							
							Previously messages could be sent out of order if (e.g.)
1. You're on a slow network
2. You send a big attachment
3. You immediately send text
Generally in this scenario, the text will be sent before the attachment.
Also, introduced a more general retry loop to retry on *any* failure
during sending.
Previously the only retry logic was around the messages API on the
Signal Server.
Now we'll also retry failures when allocating an attachment, or
uploading an attachment.
TODO: remove the now redundant retry logic in the message sender?
TODO: there is still one place where we send messages directly through
the MessageSender, rather than via the operation - when resending to a
group due to a safety number change. This is separate logic because we
were being sure to *only* resend to that one recipient. Cleaning this up
would move a lot of code around.
Once Signal-Desktop implements timestamp based de-duping we could shave
that wart by having this troublesome codepath use NSOperation like
everything else.
// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Kirk
							
						 
						
							 
							
							
							
								
							
								d6af5028ca 
								
							
								 
							
						 
						
							
							
								
								Fix receiving attachments from old clients  
							
							 
							
							... 
							
							
							
							Protobuf's null-object pattern provides an empty NSData when no digest
is provided rather than nil.
// FREEBIE 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								312f398ddd 
								
							
								 
							
						 
						
							
							
								
								Merge branch 'charlesmchen/nonUSNonContactSearch'  
							
							 
							
							
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Matthew Chen
							
						 
						
							 
							
							
							
								
							
								332833da7b 
								
							
								 
							
						 
						
							
							
								
								Respond to CR.  
							
							 
							
							... 
							
							
							
							// FREEBIE 
							
						 
						
							9 years ago