Commit Graph

988 Commits (46ebe52a2771641c9a8d521387b50d25ef3c42fa)

Author SHA1 Message Date
Michael Kirk 1f15ba6dc5 Cache group details on blocking manager
In case the group thread is later deleted.
6 years ago
Michael Kirk c0991fce74 enable dark theme for beta 6 years ago
Michael Kirk 7b7da4bc13 add docs to BlockListCache 6 years ago
Michael Kirk fd492f379a Use BlockListCache where possible 6 years ago
Michael Kirk 2c49232db0 remove barely used getters
Lock contention on these methods is less important because we're not iterating
over their access, e.g. per tableViewCell
6 years ago
Michael Kirk 448936d156 BlockListCache
block manager synchronizes on self for coherent read/writes to blocking state
across threads, but we want to be able to have performant reads on the main
thread.
6 years ago
Michael Kirk 28d28cf2b6 remove unused code 6 years ago
Michael Kirk b6eb1476cb Leave group when blocking it 6 years ago
Michael Kirk 8aba5725cf BlockListViewController v. group blocking 6 years ago
Michael Kirk c6de8c579c WIP: Localizations 6 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
6 years ago
Michael Kirk 236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
6 years ago
Matthew Chen 3935b019f4 Add base class for tests. 6 years ago
Matthew Chen 3fe7d7f9be Remove more usage of logTag. 6 years ago
Michael Kirk 5bafc7b6d6 Don't allow enabling dark theme in production yet 6 years ago
Matthew Chen df7acfeed3 Simplify OWSPreferences access. 6 years ago
Matthew Chen 106ecf2e8e Respond to CR. 6 years ago
Matthew Chen cc117b385c Modify environment accessors to use our 'shared' convention. 6 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 6 years ago
Matthew Chen bd05cdc031 Rename TextSecureKitEnv to SSKEnvironment. 6 years ago
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 6 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
6 years ago
Matthew Chen 34a05cdb85 Refine image validation. 6 years ago
Matthew Chen 51e8fdcb25 Use small thumbnail when creating quoted reply. 6 years ago
Matthew Chen 206432fdf0 Add failure methods to thumbnail service. 6 years ago
Matthew Chen 3437361d70 Use new thumbnails in media gallery thumbnails. 6 years ago
Matthew Chen ac4365e1c9 Add OWSThumbnailService. 6 years ago
Matthew Chen 446ceb2b9c Rename AttachmentStream methods. 6 years ago
Matthew Chen 498828f93c Rename AttachmentStream methods. 6 years ago
Matthew Chen 9ab4da5c81 cherry-pick Merge branch 'charlesmchen/logSdp' 6 years ago
Matthew Chen fac7f6932f Rename TSGroupMetaMessage enum values. 6 years ago
Matthew Chen f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 6 years ago
Michael Kirk d6f856a626 fixup: Leave theme enabled if ever enabled 6 years ago
Michael Kirk 4e19a79436 Leave theme enabled if ever enabled 6 years ago
Michael Kirk 64dd7c79ed enable dark theme for beta 6 years ago
Michael Kirk e715bf9ea2 image sizing
Validate image sizing
6 years ago
Matthew Chen f473f60111 Apply OWS log functions in Objective-C. 6 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 6 years ago
Matthew Chen 03829779cc Apply OWS log functions in Objective-C. 6 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 6 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 6 years ago
Matthew Chen 0b5b74a901 Respond to CR. 6 years ago
Matthew Chen b4539328e1 Log call session description. 6 years ago
Matthew Chen 2d06c05a4f Log call session description. 6 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 6 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 6 years ago
Matthew Chen 7be8f30877 Apply -> Never. 6 years ago
Matthew Chen d4f7b5d45b Respond to CR. 6 years ago
Matthew Chen e1049fdfcc Respond to CR. 6 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 6 years ago
Michael Kirk 1a92f414eb Revert "Disable dark theme in production."
This reverts commit 472a92a1a3.
6 years ago
Michael Kirk 1d2590fa12 Merge tag '2.29.0.17' 6 years ago
Michael Kirk bc2ba63c21 DRY refactor 6 years ago
Michael Kirk 37738c24c5 Allow menuActions + callBanner
// FREEBIE
6 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 6 years ago
Matthew Chen cb827169fb Respond to CR. 6 years ago
Matthew Chen 472a92a1a3 Disable dark theme in production. 6 years ago
Michael Kirk 1743407cc2 Code cleanup per code review 6 years ago
Michael Kirk 3022f92925 Tweak tint for search bar icons in dark theme 6 years ago
Michael Kirk 75bb9b60db Alternative dark theme search bar
Rather than our custom class, we can get pretty far using existing UISearchBar
styling, and then apply the final tweak, the search bar text field background
color by traversing the view.

This fixes a couple issues:

1. There was a small wavering in height of the custom search bar
2. When your table header view is a UISearchBar you get nice scroll "snapping"
   when showing/hiding the search bar.
6 years ago
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
6 years ago
Matthew Chen 4971d40c75 Respond to CR. 6 years ago
Matthew Chen 9e21612298 Respond to CR. 6 years ago
Matthew Chen 6dd474d794 Theme quoted replies. 6 years ago
Matthew Chen a92fca5c13 Theme quoted replies. 6 years ago
Michael Kirk b80d88c824 theme attachment approval keyboard
// FREEBIE
6 years ago
Matthew Chen c7ed09ed91 Fix 'can't delete formatting in phone number' issue. 6 years ago
Matthew Chen 8daaef22da Add custom themed search bar. 6 years ago
Matthew Chen decb0c54ca Theme review. 6 years ago
Matthew Chen d62e07d6f1 Theme review. 6 years ago
Matthew Chen 4ea5d9b849 Theme review. 6 years ago
Matthew Chen a76d488e8b Fix QA issues in theme. 6 years ago
Matthew Chen 22dda476bb Fix QA issues in theme. 6 years ago
Matthew Chen 26001e49d1 Unify log tags. 6 years ago
Michael Kirk 71cb90b575 Avoid incremental theme-redraws
IMO this feels more impressive
6 years ago
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 6 years ago
Michael Kirk 7a0d74c17e Use dark blur for navbar
In the light theme, using the "light" blur allows the bar to seem invisible
when over white content. Similarly for the "dark" blur over black content.
6 years ago
Michael Kirk 1ff443c3ac restore transparent navbar in attachment approval 6 years ago
Michael Kirk ebd2e6d5ac Tweak theme 6 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
6 years ago
Matthew Chen 8ecf6884c5 Remove "sending" color for outgoing messages. 6 years ago
Matthew Chen 3fc3425605 Theme search bars. 6 years ago
Matthew Chen 800689d9ff Configure default cells. 6 years ago
Matthew Chen 2c9c028504 Clean up. 6 years ago
Matthew Chen adadf094d4 Enable theme. 6 years ago
Matthew Chen 6dfe36f9b5 Respond to CR. 6 years ago
Matthew Chen 816f02fbab Fix unintentional moves. 6 years ago
Matthew Chen 9c92719ec4 Refine theme. 6 years ago
Matthew Chen 5ef0b6d056 Refine theme. 6 years ago
Matthew Chen acd7d094b1 Refine theme. 6 years ago
Matthew Chen a56a16411f Refine theme. 6 years ago
Matthew Chen a543cd5a4e Refine theme. 6 years ago
Matthew Chen ce4fdd5135 Refine theme. 6 years ago
Matthew Chen d34f83b445 Refine theme. 6 years ago
Matthew Chen 4f8dbf39b5 Refine theme. 6 years ago
Michael Kirk 0620aba3bc Add cancel button 6 years ago
Michael Kirk 2ea7e2b036 CR: clean up preferences 6 years ago
Michael Kirk e5b3cbd00c Use StoreKit for reviews 6 years ago
Matthew Chen a5ffbdebb3 Remove Obj-c proto parser. 6 years ago
Matthew Chen 06d84860ae Fix rebase breakage. 6 years ago
Matthew Chen 45e782c243 Revamp orphan data cleaner. 6 years ago
Michael Kirk 0bc03b0fd4 Move seed 6 years ago
Matthew Chen 6be3d2e42d Code generate Swift wrappers for protocol buffers. 6 years ago
Matthew Chen dfc39b4a1d Tidy files. 6 years ago
Matthew Chen e6bc37d941 Tidy files. 6 years ago
Matthew Chen 8f55f53329 Tidy files. 6 years ago
Matthew Chen d6cb07cc4a Respond to CR. 6 years ago
Matthew Chen 0f4e846ed7 Tidy profile avatars. 6 years ago
Matthew Chen 579e88bdc2 Improve nullability handling for SignalAccount. 6 years ago
Michael Kirk 78ad597e44 Merge tag '2.28.0.15' 6 years ago
Michael Kirk def8b43daa iOS9/10 fixups 6 years ago
Michael Kirk 78b4df95a5 fixup call banner offsets 6 years ago
Jesse Squires 6dc74ddcaf Fix some project warnings + other fixes
- Prefer checking `.isEmpty` rather than `.count == 0` for Swift collections (can be more optimal)
- Avoid comparing `BOOL` explicitly to `NO` (considered bad practice since `BOOL` is a `signed char`)
- Specify unused `SGX_FLAGS` as `__unused` to silence warnings
6 years ago
Matthew Chen fa8a07abf1 Respond to CR. 6 years ago
Matthew Chen 581347a7fb Refine theme. 6 years ago
Matthew Chen 7759c9ca0f Refine theme. 6 years ago
Matthew Chen f795b12a86 Refine theme. 6 years ago
Michael Kirk 6e1c1a681b Merge tag '2.28.0.12' 6 years ago
Michael Kirk b42f528713 Integrate with new contact discovery endpoint
Also:
* use system cookie parsing
* add AESGCM additional authenticated data parameter

// FREEBIE
6 years ago
Matthew Chen 25a98554b7 Intern JSQMessagesViewController. 6 years ago
Matthew Chen 906d0b01a4 Fix build break. 6 years ago
Matthew Chen 819c2b1ceb Remove Twisted Oak. 6 years ago
Michael Kirk 3d6b8e2bb5 hide navbar blur layer in attachment approval, which has a clear navbar 6 years ago
Matthew Chen 2b1f928770 Respond to CR. 6 years ago
Matthew Chen 48975eaac8 Respond to CR. 6 years ago
Matthew Chen 8862f9a531 Refine views. 6 years ago
Matthew Chen fcbf8d4dc2 Refine views. 6 years ago
Matthew Chen 9f9e0965d5 Refine table views. 6 years ago
Michael Kirk ab1190222b Fix overzealous failure when user has no Signal contacts
// FREEBIE
6 years ago
Matthew Chen 460f7344ad Remote attestation. 6 years ago
Matthew Chen 39c7fd9f15 Respond to CR. 6 years ago
Matthew Chen 3c3742aae9 Clean up ahead of PR. 6 years ago
Matthew Chen bf1642052a Fix nullability. 6 years ago
Matthew Chen 03e5d2973b Delta contact intersections. 6 years ago
Matthew Chen d14f764b50 Streamline SignalRecipient. 6 years ago
Michael Kirk d591fb7f2c Fix some compiler warnings 6 years ago
Matthew Chen 0c453c8d57 Fix content insets. 6 years ago
Michael Kirk 11fc674ef4 Avoid blur as overly-tall navigation bar lingers after dismissal.
Use the precise status bar height.
6 years ago
Michael Kirk 7a5f5476db rename to avoid confusion 6 years ago
Michael Kirk 06b4584e02 move fix to OWSViewController 6 years ago
Michael Kirk 24060c17d0 CR: proper width calculation for header view 6 years ago
Michael Kirk fef6c64bdc decrease header spacing from 32->28.
Previous spacing was based on applying the "full width" gutter spacing twice.
6 years ago
Michael Kirk 8da47b64d9 clarify different methods
These method names were too similar to existing methods in PureLayout, which
have slightly different behavior.

ows_autoPinToSuperviewEdges uses left/right, whereas PureLayouts uses
leading/trailing

ows_autoPinToSuperviewMargins uses our own constraint adding logic, which
behaves differently in some cases.
6 years ago
Matthew Chen c3b02522ca Fix oversize accessory view. 6 years ago
Matthew Chen 3a3fb0e41b Fix oversize accessory view. 6 years ago
Michael Kirk 1a2428a4b0 CR: leave some wiggle room on max window height. 6 years ago
Michael Kirk bdc8181cbc hide menu view controller when resigning active
// FREEBIE
6 years ago
Michael Kirk dde2fd6f33 Hide menu window when vc dismisses.
Normally this isn't possible, just being paranoid.

// FREEBIE
6 years ago
Michael Kirk 82fdd5b883 Split out generic action sheet components
Keep the message specific components separte, so we could re-use the
MenuActionsViewController.
6 years ago
Michael Kirk 3a157d9df6 window level on iOS11
// FREEBIE
6 years ago
Michael Kirk 0c4cae133b milestone: route one real action (copy text) 6 years ago
Michael Kirk bb6722ea42 animate in/out 6 years ago
Michael Kirk ceeddbc67b localize, proper action height 6 years ago
Michael Kirk adfaeaa8e1 round top corners 6 years ago
Michael Kirk 57400e1ecb WIP: ActionView 6 years ago
Michael Kirk 635c0275db stop observing db notifications while message actions are presented
This let's new messages appear after the message actions are dismissed without
complicating scroll state.
6 years ago
Michael Kirk 6275a2f102 Highlight focused view 6 years ago
Michael Kirk 22fada2457 don't dismiss keyboard when presenting actions 6 years ago
Michael Kirk aa98963fd9 Abandonded: separate window pattern
Hiding the old window, caused keyboard to resign first responder.
6 years ago
Michael Kirk 6037a440c9 wire up window mgmt 6 years ago
Michael Kirk a2c67bb96b Enhance navbar blur, match input toolbar blur
// FREEBIE
6 years ago
Matthew Chen 3729943cd3 Fix production build breakage. 6 years ago
Matthew Chen b2f42adb86 Respond to CR. 6 years ago
Matthew Chen f6eb8dfe72 Refine app settings view. 6 years ago
Matthew Chen 20d1d11259 Refine home view. 6 years ago
Matthew Chen 8287076499 More design tweaks. 6 years ago
Matthew Chen 0c420ed28a Tweak appearance. 6 years ago
Matthew Chen 750b935122 Tweak appearance. 6 years ago
Matthew Chen 376e2cc1db Respond to CR. 6 years ago
Matthew Chen 35f058c46a Rework unread indicators. 6 years ago
Matthew Chen ecafe546b6 Rework unread indicators. 6 years ago
Matthew Chen 8d72bb032e Rework unread indicators. 6 years ago
Matthew Chen 8b3bdb88f3 Revert "Merge branch 'charlesmchen/tweakCalls'"
This reverts commit 3e0233ea60, reversing
changes made to 74ce3012cf.
6 years ago
Michael Kirk 92705490a0 No write transaction needed for syncing colors
// FREEBIE
6 years ago
Michael Kirk 4d3d5d98e1 Sync colors with contacts 6 years ago
Michael Kirk c8b4e879e7 CR: remove unused font 6 years ago
Michael Kirk f22cb48f85 date break font/color to spec
// FREEBIE
6 years ago
Michael Kirk 28abf426f1 White status bar for call screen
Transition to VC controlled status bar style.
6 years ago
Michael Kirk 998c2f392c CR: inline per code review 6 years ago
Michael Kirk 834021fe39 tweak selected color for homeview cells 6 years ago
Michael Kirk 10ac7be03a prefer localizedUppercaseString for user facing text
// FREEBIE
6 years ago
Michael Kirk 76745bee5b failed background color to spec 6 years ago
Michael Kirk b0978abd01 use points not pixels when determining how short a device is 6 years ago
Matthew Chen 03d393553a Tweak home view cells. 6 years ago
Matthew Chen b92fc89986 Retweak date and unread messages breaks. 6 years ago
Matthew Chen 712d6d89e1 Tweak relative timestamps. 6 years ago
Matthew Chen a28a5251f6 Respond to CR. 6 years ago
Matthew Chen 4893b01907 Retweak colors. 6 years ago
Matthew Chen 4b448ed018 Retweak colors. 6 years ago
Matthew Chen bbd65d6433 Retweak colors. 6 years ago
Matthew Chen 929615ab0c Tweak sender avatar sizes. 6 years ago
Matthew Chen 57c79fd797 Respond to CR. 6 years ago
Matthew Chen 1a9a5016fe Tweak calls. 6 years ago
Michael Kirk b301dba4ba cell height to spec 6 years ago
Matthew Chen c460ff2945 Fix contact cell layout. 6 years ago
Matthew Chen 01cc206e8e Tweak styling of phone number + profile name. 6 years ago
Matthew Chen 5b5ef7e0bf Respond to CR. 6 years ago
Matthew Chen dd078b106f Tweak message send failed indicator. 6 years ago
Matthew Chen 19699fd45f Tweak message send failed indicator. 6 years ago
Michael Kirk 0f34f76611 Merge tag '2.27.1.1' 6 years ago
Michael Kirk b47062831f Don't block "register" button on iPad registration
On short devices, add a toolbar with a "dismiss" button to the number pad.
6 years ago
Michael Kirk 83d3f17d44 remove unused code, add comment 6 years ago
Michael Kirk 2b588017f3 round attachment approval toolbar 6 years ago
Matthew Chen 05b1b37eab Respond to CR. 6 years ago
Matthew Chen 92a9796e9e Respond to CR. 6 years ago
Matthew Chen 1412998b4a Rework isRTL. 6 years ago
Matthew Chen 39eac9129b Respond to CR. 6 years ago
Matthew Chen 32f33f6d12 Tweak sender names. 6 years ago
Michael Kirk 4f94d5c5a9 default value 6 years ago
Michael Kirk 5719aba91a separate icon vs. title color for toolbars 6 years ago
Michael Kirk 126d41e542 Fixup "scroll down" button so it doesn't fall behind toolbar 6 years ago
Michael Kirk ee898829a1 fixup white nav 6 years ago
Michael Kirk 767f06b09f fixup status bar 6 years ago
Michael Kirk 104e63ded9 remove appearance juggling 6 years ago
Michael Kirk f8abe32ae9 more styling to new nav colors 6 years ago
Michael Kirk 5d6a988955 WIP navbar 6 years ago
Michael Kirk de56eb9d6b Proper color for compose screen avatars
ConversationCell#thread is nullable

// FREEBIE
6 years ago
Michael Kirk 16df4f589e conversation colors
// FREEBIE
6 years ago
Matthew Chen 24c4c4c098 Respond to CR. 6 years ago
Matthew Chen d2f2e1cb22 Respond to CR. 6 years ago
Matthew Chen 87380894ba Tweak message cells. 6 years ago
Matthew Chen 17d4ccc489 Disable compact text layout. 6 years ago
Matthew Chen 35dc348551 Move conversation style. 6 years ago
Matthew Chen af4eb39a2d Respond to CR. 6 years ago
Matthew Chen a34719ce69 Tweak color palette. 6 years ago
Matthew Chen f2153f888b Tweak color palette. 6 years ago
Matthew Chen cbc80abff1 Tweak color palette. 6 years ago
Matthew Chen ce9a9ec925 Tweak color palette. 6 years ago
Matthew Chen 8943669d88 Tweak colors. 6 years ago
Matthew Chen 7634e3a44d Respond to CR. 6 years ago
Matthew Chen 2b457c6499 Tweak contact shares. 6 years ago
Matthew Chen ac6f78a5fc Tweak message cells. 6 years ago
Michael Kirk 803a58f33a avoid assert
// FREEBIE
6 years ago
Michael Kirk 9f06163b76 Fix contacts reminder view
We had a guard that prevented 'called at least once' from ever getting set when contacts access was disabled.

// FREEBIE
6 years ago
Michael Kirk cde1c3fb7c Fix: iOS10 was not respecting margins with our homebrew pin method
// FREEBIE
6 years ago
Matthew Chen 8cb057c23f Fix 'contact cell vs. message details layout' issue. 6 years ago
Matthew Chen c8d0a80032 Fix 'contact cell vs. message details layout' issue. 6 years ago
Matthew Chen 2ecbf1bb65 Fix 'contact cell vs. message details layout' issue. 6 years ago
Matthew Chen 1a57fe631c Fix 'contact cell vs. message details layout' issue. 6 years ago
Matthew Chen 0df71e22a5 Fix message detail view. 6 years ago
Matthew Chen 71c63d9fce Remove obsolete assert. 6 years ago
Matthew Chen b75f4596aa Remove obsolete assert. 6 years ago
Michael Kirk cc1bde34cd Inform iPad users upon registration
// FREEBIE
6 years ago
Matthew Chen fbbb9276b9 Respond to CR. 6 years ago
Matthew Chen 63b6276c25 Clear LRUCache in background. 6 years ago
Matthew Chen 87ea1dcae1 Clean up ahead of PR. 6 years ago
Matthew Chen 08ca4fdb50 Lazy-load contact avatar data and images. Use NSCache for avatar images. 6 years ago
Matthew Chen b9e2963f47 Don't cache CNContact. 6 years ago
Matthew Chen 83f11ad79b Don't cache CNContact. 6 years ago
Matthew Chen 12295bd8c5 Don't cache CNContact. 6 years ago