Commit Graph

5767 Commits (3b984bd393dfdacf0da9a3dad10027bb92895954)
 

Author SHA1 Message Date
Matthew Chen 3b984bd393 Merge branch 'mkirk/perm-thread' into hotfix/2.20.1 7 years ago
Michael Kirk 9dfbf6e6bc Fix crash presenting settings dialog off main thread
// FREEBIE
7 years ago
Matthew Chen 815c9af150 Merge branch 'charlesmchen/unsafeFilenameCharacters' into hotfix/2.20.1 7 years ago
Matthew Chen 579da1c768 Refine handling of unsafe filename characters. 7 years ago
Matthew Chen 47a6d844c9 Refine handling of unsafe filename characters. 7 years ago
Matthew Chen de5d17a396 Merge branch 'charlesmchen/debugLogs' into hotfix/2.20.1 7 years ago
Matthew Chen 7e1ae33167 Refine changes to debug logs. 7 years ago
Matthew Chen 920c2b1d76 Rework log upload. 7 years ago
Matthew Chen d32e90c3d1 Fix build break. 7 years ago
Matthew Chen a471cc32b9 Merge branch 'charlesmchen/backgroundEdgeCases' into hotfix/2.20.1 7 years ago
Matthew Chen 59f480d5c4 Use background tasks during storage registration and disappearing message jobs. 7 years ago
Matthew Chen 03bea4fd8b "Bump build to 2.20.0.42." 7 years ago
Matthew Chen 9e3aa77fc6 Update l10n strings. 7 years ago
Matthew Chen cf39181d05 Merge branch 'mkirk/freeze-after-dismiss' 7 years ago
Michael Kirk 5af1123219 Fix freeze in host app after "dismissing" select thread VC
We must call these completion handlers whenever we exit the SAE

// FREEBIE
7 years ago
Matthew Chen 01cde6740c "Bump build to 2.20.0.41." 7 years ago
Matthew Chen fbab526b3c Update l10n strings. 7 years ago
Matthew Chen ff88f11738 Update l10n strings. 7 years ago
Matthew Chen ec32d8839b "Bump build to 2.20.0.40." 7 years ago
Matthew Chen e0793a0eae Merge branch 'charlesmchen/backgroundVsMigration' 7 years ago
Matthew Chen 5235f97953 Use background task while migrating. 7 years ago
Matthew Chen 8ec9540b8f Merge branch 'charlesmchen/handleCaptions' 7 years ago
Matthew Chen 10ca369da8 Respond to CR. 7 years ago
Matthew Chen 6006d22870 Improve handling of attachments with captions. 7 years ago
Matthew Chen 8576da791c Improve handling of attachments with captions. 7 years ago
Matthew Chen 96b5f22799 Improve handling of attachments with captions. 7 years ago
Matthew Chen d30dd22040 "Bump build to 2.20.0.39." 7 years ago
Matthew Chen 81629a87df Fix build break. 7 years ago
Matthew Chen 5e88110a0b "Bump build to 2.20.0.38." 7 years ago
Matthew Chen 8e9261e1ba "Bump build to 2.20.0.37." 7 years ago
Matthew Chen 708ff7efbd "Bump build to 2.20.0.36." 7 years ago
Matthew Chen 1112f7a644 Merge branch 'charlesmchen/conversationViewVsModifiedExternal' 7 years ago
Matthew Chen 152c570900 Respond to CR. 7 years ago
Matthew Chen 03670b4868 Rename the view horizon. 7 years ago
Matthew Chen fabbe46114 Clean up ahead of PR. 7 years ago
Matthew Chen 4e1e232825 Flush writes from other processes. 7 years ago
Matthew Chen 1ff4f85247 Improve handling of db modifications while conversation view is not observing. 7 years ago
Matthew Chen 5444fc73b0 Improve handling of db modifications while conversation view is not observing. 7 years ago
Matthew Chen 2ac7716771 Improve handling of db modifications while conversation view is not observing. 7 years ago
Matthew Chen 31d22e3e35 "Bump build to 2.20.0.35." 7 years ago
Matthew Chen ba31059e43 Merge branch 'mkirk/fix-share-with-caption' 7 years ago
Michael Kirk e43d0b1b5a Fix "Share" for attachment with caption
// FREEBIE
7 years ago
Matthew Chen 88d8eacc6e "Bump build to 2.20.0.34." 7 years ago
Michael Kirk e27ab36205 Merge branch 'mkirk/remove-share-menu' 7 years ago
Michael Kirk 5ba5d3f524 Remove "Share" from edit menu
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.

Specifically:

- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
  share extension (could be the Signal share extension or another app's
  share extension)
- the conversation view (which is rendered behind the share extension)
  regains first responder, causing the input toolbar to appear above the
  share extension

One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.

// FREEBIE
7 years ago
Michael Kirk 9428b5d02b Merge branch 'mkirk/obscure-alert' 7 years ago
Michael Kirk d7f8c3e9d3 Ensure inputAccessory doesn't obscure the SN alert
This affects iOS 8, 9, and to a lesser degree iOS10.
On iOS11, presenting an alert causes the keyboard/inputAccessoryView to
temporarily dismiss.

// FREEBIE
7 years ago
Michael Kirk c0d1126394 Merge branch 'mkirk/fix-date-formatting-crash' 7 years ago
Michael Kirk 7040437ca6 Handle nil date when formatting
// FREEBIE
7 years ago
Matthew Chen 2575d01b96 "Bump build to 2.20.0.33." 7 years ago