Commit Graph

7151 Commits (36ee6af62102c3b591b6c62b2747673426000f89)
 

Author SHA1 Message Date
Michael Kirk 36ee6af621 respond to CR 7 years ago
Michael Kirk b8707b6fa4 WIP: call view changes 7 years ago
Michael Kirk 20424d9a7e remove debug code, reorder for clarity
// FREEBIE
7 years ago
Michael Kirk fe62a6ac92 CNContactController needs to be presented in a navcontroller with a
translucent navbar.

In cases where we were presenting modally, we can easily modify the
modal to have a translucent navbar.

In the one place we were pushing onto the SignalsNavigationController,
rather than modifying the SNC.isTranslucent and having to clean it up,
I've opted to convert to a modal presentation.

// FREEBIE
7 years ago
Michael Kirk 2709a91b5e Fixup attachment approval vis-a-vis call banner
// FREEBIE
7 years ago
Michael Kirk 4f80100234 Tapping on status bar returns to call
We want to render the return-to-call banner behind the status bar, so
the user can see the system clock, etc.

But normally, doing so would mean we wouldn't receive touches in the top
20px of the screen.

// FREEBIE
7 years ago
Michael Kirk 4c9808d1a1 Fix iPhoneX layout show status bar above call banner
// FREEBIE
7 years ago
Michael Kirk 3383c5e80c Fixup for iPhoneX
// FREEBIE
7 years ago
Michael Kirk 778e11c2c3 cleanup ahead of PR
// FREEBIE
7 years ago
Michael Kirk 7ad5f15448 Restore cancleable back gesture for those VC's that use it
// FREEBIE
7 years ago
Michael Kirk 49c652ad14 Comment cleanup
// FREEBIE
7 years ago
Michael Kirk 1b60716759 Stop worrying about notification order by using delegate pattern
// FREEBIE
7 years ago
Michael Kirk d9d0227ce5 Align search bar to safe area insets
// FREEBIE
7 years ago
Michael Kirk 319a6ff765 fixup behavior on iOS10 7 years ago
Michael Kirk 6c7af671bc call banner above status bar for now 7 years ago
Michael Kirk 29d08545e2 Use OWSNavigationController instead of UINavigationController
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
7 years ago
Michael Kirk 33eb4c38cd Centralize translucency configuration
// FREEBIE
7 years ago
Michael Kirk 12c98f4340 cleanup and move to OWSNavigationController
// FREEBIE
7 years ago
Michael Kirk a2b1793262 initial render is wrong, but settles somewhere nice
-[x] fix initial placement
-[x] add additional top safe area?

// FREEBIE
7 years ago
Michael Kirk 3a9391f4fb notes on what didn't work 7 years ago
Michael Kirk 4dbd14ac41 WIP navbar resize
-[ ] CallScreen
  -[x] functional button
  -[ ] needs design
  -[x] disable conversation view call buttons while in call
-[ ] iOS11
  -[x] resize nav content
  -[ ] background showing at top of all vc's
  -[] iPhoneX
    -[x] use differently sized banner for now
    -[] mimic X system design
-[ ] iOS10
  -[x] resize nav content
  -[ ] animation glitch while push/pop
-[ ] iOS9

// FREEBIE
7 years ago
Michael Kirk 0e87cbe7a5 WIP navbar resize
-[ ] CallScreen
  -[x] functional button
  -[ ] needs design
  -[ ] disable other contact call buttons while in call
-[ ] iOS11
  -[x] resize nav content
  -[ ] background showing at top of all vc's
  -[] iPhoneX
    -[x] use differently sized banner for now
    -[] mimic X system design
-[ ] iOS10
  -[x] resize nav content
  -[ ] animation glitch while push/pop
-[ ] iOS9

// FREEBIE
7 years ago
Michael Kirk ffe17a3fcc add guard to avoid redundant show, fix logic in existing guard when
hiding.

// FREEBIE
7 years ago
Michael Kirk 2258e18d34 rename for clarity
// FREEBIE
7 years ago
Michael Kirk 91cd1af3f9 Extract ReturnToCallViewController
// FREEBIE
7 years ago
Michael Kirk a7252544b0 WIP: custom navbar
TODO:

Use custom navcontroller everywhere - no more UINavigationController

listen to notification for when call starts/ends and sizeToFit.
7 years ago
Michael Kirk 772af10e50 Resizing call banner window
problem is the navigation bar is now too tall, since it has room for
status.

We could shirnk the nav bar, but maybe it's easier to just have the call
banner in the navbar?

// FREEBIE
7 years ago
Michael Kirk e62fe87b01 show status bar *above* call window 7 years ago
Michael Kirk 94323baba8 tmp - mute hides callscreen 7 years ago
Matthew Chen b5c290afd1 Merge branch 'michaelkirk/requestIdProtos' 7 years ago
Michael Kirk 966b1ac84b Treat `id` as reserved word, use consistent setter style
// FREEBIE
7 years ago
Matthew Chen a5fd119c1e "Bump build to 2.26.0.2." 7 years ago
Matthew Chen fedb5d9385 Merge branch 'charlesmchen/callTerminationBug' 7 years ago
Matthew Chen a722bcde72 Fix call termination reference. 7 years ago
Matthew Chen 9eb17c3fd3 "Bump build to 2.26.0.1." 7 years ago
Matthew Chen 1afaa9d658 Merge branch 'charlesmchen/websocketProfileGets' 7 years ago
Matthew Chen bb19505c6a Make profile gets over websocket. 7 years ago
Matthew Chen 69b6eb9f4e Merge branch 'charlesmchen/weakPeerConnectionClient' 7 years ago
Matthew Chen bfb87582fe Respond to CR. 7 years ago
Matthew Chen 735b4e07b1 Respond to CR. 7 years ago
Matthew Chen 918abb02a1 Remove capture of self. 7 years ago
Matthew Chen 9c0c87a8c3 Remove capture of self. 7 years ago
Matthew Chen 7eab0569b6 PeerConnectionClient thread safety. 7 years ago
Matthew Chen 078da69ee0 PeerConnectionClient thread safety. 7 years ago
Matthew Chen 9075a12ac6 PeerConnectionClient thread safety. 7 years ago
Matthew Chen c2f1a12d9f PeerConnectionClient thread safety. 7 years ago
Matthew Chen 88c2ff26e7 PeerConnectionClient thread safety. 7 years ago
Matthew Chen e63a7f8fb0 PeerConnectionClient thread safety. 7 years ago
Matthew Chen c3e8fde24c PeerConnectionClient thread safety. 7 years ago
Matthew Chen 1a0347b782 PeerConnectionClient thread safety. 7 years ago