Commit Graph

8887 Commits (2eb3ec6d0cfe59385e3391a669ebff8d1d5270f3)
 

Author SHA1 Message Date
Michael Kirk 2eb3ec6d0c benchmark migration 7 years ago
Michael Kirk b281b37637 replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId
Update migration accordingly

Date shown on home view cell is message.receivedAt
7 years ago
Michael Kirk c27d35f8f2 sort search results by sortId 7 years ago
Michael Kirk 1459fad01a sort media gallery by sortId 7 years ago
Michael Kirk 90aa593dcd sortId vs. Read status 7 years ago
Michael Kirk 089c4f09ea bump all views which rely on message sorting 7 years ago
Michael Kirk d6d6c4fca4 ConversationVC - lastSeenSortId 7 years ago
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
7 years ago
Michael Kirk e1a46d85fb investigation shows we don't use this timestamp for call error messages 7 years ago
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 7 years ago
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
7 years ago
Michael Kirk 550e7ba63b Create disappearing message update info messages before messages they affect
Since we're no longer sorting by timestamp we have to ensure we save the update
info message before we save any affected message, e.g. in the case of implicit
updates.
7 years ago
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
7 years ago
Michael Kirk 6c5fbc6de5 Update existing contact offers in place
WIP: migration / autoincrement logic

TODO:

-[x] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?

fixup contact offers
7 years ago
Michael Kirk a60d8eb161 WIP: migration / autoincrement logic
TODO:

-[ ] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?
7 years ago
Michael Kirk ae668ceca9 include sequence number in fake messages 7 years ago
Michael Kirk 87509df26a Merge branch 'mkirk/fix-release-compile' into release/2.30.1 7 years ago
Michael Kirk bccb633b6c fix release compile 7 years ago
Michael Kirk 4b9d720b9f ignore RI check for unreleased 2.30 tags 7 years ago
Michael Kirk 306c6ade71 "Bump build to 2.30.1.0." 7 years ago
Matthew Chen 6a5935c6e8 Merge branch 'charlesmchen/fix-ssk-tests-o' 7 years ago
Matthew Chen be76267105 Update cocoapods. 7 years ago
Matthew Chen 98630cca50 Respond to CR; add db utility methods to test base classes. 7 years ago
Matthew Chen 559c496ae5 Clean up. 7 years ago
Matthew Chen 66fc389fba Get SSK tests building and running. 7 years ago
Matthew Chen c87eea2ab6 Merge branch 'charlesmchen/fix-ssk-tests-n' 7 years ago
Matthew Chen 87836f506b Move more singletons to SSKEnvironment. 7 years ago
Matthew Chen 6e3462c13f Merge branch 'charlesmchen/fixProtoStreamTest' 7 years ago
Matthew Chen b881bb467c Fix proto stream test. 7 years ago
Matthew Chen 52c27005ee Merge branch 'charlesmchen/logCurl' 7 years ago
Matthew Chen 39ebdf0921 Log curl command for failed requests in debug builds. 7 years ago
Matthew Chen 562d516a78 Merge branch 'charlesmchen/newGrayscalePalette' 7 years ago
Matthew Chen 6a712366ae Tweak gray 95. 7 years ago
Matthew Chen 922c505559 Respond to CR. 7 years ago
Matthew Chen ef6689410b Design feedback from Myles. 7 years ago
Matthew Chen 8cf5f3e58f New grayscale palette. 7 years ago
Matthew Chen c7eb80700e Fix memory leak in Curve25519Kit. 7 years ago
Matthew Chen e7b7fb9293 Merge branch 'charlesmchen/corruptThreadView' 7 years ago
Matthew Chen 15b52db8bf Respond to CR. 7 years ago
Matthew Chen 29bb69032a DRY up the debounce of db extension version increment. 7 years ago
Matthew Chen 20de087441 Repair corrupt thread view. 7 years ago
Matthew Chen a0a48431ca Merge branch 'charlesmchen/fix-ssk-tests-l' 7 years ago
Matthew Chen 6563c829e3 Update cocoapods. 7 years ago
Matthew Chen e8186a7005 Fix rebase breakage. Make environment properties mutable in tests. 7 years ago
Matthew Chen 3b2c5bfc7b Modify mock environments to register all db views. 7 years ago
Matthew Chen 83e6484156 Respond to CR. Rework how OWSUploadOperation's networkManager property. 7 years ago
Matthew Chen a7a05e9bbf Respond to CR. Rework how CallNotificationsAdapter adaptee is populated. 7 years ago
Matthew Chen edcedd2845 Remove selfRecipient method. 7 years ago
Matthew Chen e1db60c1c0 Rework creation of singletons. 7 years ago
Matthew Chen 27023c9d83 Merge branch 'charlesmchen/brokenSignalTests' 7 years ago