Commit Graph

84 Commits (0fe22ee0e40e28a7a55782a3081cb17e84580b00)

Author SHA1 Message Date
Matthew Chen 0ac1cb1e72 Cache system message text. 7 years ago
Michael Kirk 42eb7a8d31 cleanup unused code 7 years ago
Michael Kirk 2552368146 add text reply action, comment out more deprecated uimenu code 7 years ago
Matthew Chen ecafe546b6 Rework unread indicators. 7 years ago
Matthew Chen 8d72bb032e Rework unread indicators. 7 years ago
Matthew Chen e48a1e0816 Respond to CR. 7 years ago
Matthew Chen 8b3bdb88f3 Revert "Merge branch 'charlesmchen/tweakCalls'"
This reverts commit 3e0233ea60, reversing
changes made to 74ce3012cf.
7 years ago
Michael Kirk c81799169e CR: intercell spacing dicated by ConversationViewItem 7 years ago
Michael Kirk 77e9533dc1 remove hairline
// FREEBIE
7 years ago
Matthew Chen 1a9a5016fe Tweak calls. 7 years ago
Matthew Chen db32dcc6a2 Cleanup. 7 years ago
Matthew Chen 7be6fbc24f Refine intra-cell spacing. 7 years ago
Matthew Chen 39eac9129b Respond to CR. 7 years ago
Matthew Chen d869afc3e4 Tweak break spacing. 7 years ago
Matthew Chen 966e6a1156 Tweak sender names. 7 years ago
Matthew Chen 227234d8cb Respond to CR. 7 years ago
Matthew Chen 16a1dcfb77 Respond to CR. 7 years ago
Matthew Chen 89523f556b Tweak intra-cell spacing. 7 years ago
Matthew Chen 33b1628c26 Rename to ConversationStyle. 7 years ago
Matthew Chen 4effa56d50 Tweak 'group sender' avatars. 7 years ago
Matthew Chen a9b6fe5978 Respond to CR. 7 years ago
Matthew Chen fdd6174871 Fix breakage from cell layout changes. 7 years ago
Matthew Chen fc299b8700 Use UI database connection throughout the conversation cells. 7 years ago
Matthew Chen d40f74dd0b Respond to CR. 7 years ago
Matthew Chen ac6f78a5fc Tweak message cells. 7 years ago
Matthew Chen 3cd6a33aa6 Fix build warnings. 7 years ago
Michael Kirk 5ba5e98260 Show downloaded contact avatar in thread
// FREEBIE
7 years ago
Matthew Chen 411d5a3b4f Respond to CR. 7 years ago
Matthew Chen 708b44e3c5 Improve handling of contact display names. 7 years ago
Matthew Chen 7e35a7e7d7 Sketch out rendering of contact shares in conversation view. 7 years ago
Matthew Chen 9275c67818 Rework outgoing message state. 7 years ago
Matthew Chen 9c93099515 Fix incomplete asserts. 7 years ago
Matthew Chen ea82419a40 Fix long press on quoted reply. 7 years ago
Michael Kirk 5320536736 remove WIP comments
// FREEBIE
7 years ago
Matthew Chen 9769d482da Respond to CR. 7 years ago
Matthew Chen 76995e4594 Enforce quoted reply edge cases. 7 years ago
Michael Kirk 1d4c0624be Clarify variable names
// FREEBIE
7 years ago
Michael Kirk cb5d3d4f85 Use QuotedReplyModel to access attachment data
This view model loads the attachment when it's build.

// FREEBIE
7 years ago
Michael Kirk d99054d895 Reply menu item
MVP

- [x] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
7 years ago
Matthew Chen 7cf169012c Elaborate conversation view items around quoted replies. 7 years ago
Michael Kirk 00e5e1b0d6 Fixup some tests
// FREEBIE
7 years ago
Matthew Chen 12bcf887c1 Bubble collapse. 7 years ago
Matthew Chen 4f9085a761 Bubble collapse. 7 years ago
Matthew Chen 3ca2c08b06 Bubble collapse. 7 years ago
Matthew Chen 578f40d791 Bubble collapse. 7 years ago
Matthew Chen 8d74c68f9d Bubble collapse. 7 years ago
Matthew Chen e0e8eafb5d Bubble collapse. 7 years ago
Matthew Chen 75177ef00f Bubble collapse. 7 years ago
Matthew Chen 38ff82ab97 Rebrand OWSAudioPlayer. 7 years ago
Michael Kirk 5ba5d3f524 Remove "Share" from edit menu
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.

Specifically:

- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
  share extension (could be the Signal share extension or another app's
  share extension)
- the conversation view (which is rendered behind the share extension)
  regains first responder, causing the input toolbar to appear above the
  share extension

One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.

// FREEBIE
7 years ago