Commit Graph

1440 Commits (0b4ed1175d507be79f96ca5ca03e44c87bd77c20)

Author SHA1 Message Date
Matthew Chen 29bb69032a DRY up the debounce of db extension version increment. 7 years ago
Matthew Chen e8186a7005 Fix rebase breakage. Make environment properties mutable in tests. 7 years ago
Matthew Chen 3b2c5bfc7b Modify mock environments to register all db views. 7 years ago
Matthew Chen 83e6484156 Respond to CR. Rework how OWSUploadOperation's networkManager property. 7 years ago
Matthew Chen edcedd2845 Remove selfRecipient method. 7 years ago
Matthew Chen e1db60c1c0 Rework creation of singletons. 7 years ago
Matthew Chen 4ad7ca79b7 Respond to CR. 7 years ago
Matthew Chen e8eac9f30b Clean up ahead of PR. 7 years ago
Matthew Chen b883209f91 Refine logging. 7 years ago
Matthew Chen 69290f7ec8 Improve logging around failied keychain deletion. 7 years ago
Matt Rubin d25579e478 Treat failure to delete a non-existent password as success
Fixes https://github.com/signalapp/Signal-iOS/issues/3876
7 years ago
Michael Kirk e1f131f09c restore save after marking item as uploaded
This was lost in an earlier fixup commit - markAsAccepted mutates but does not
persist anything since SPK doesn't know about YapDB
7 years ago
Michael Kirk cb55ba57f5 CR: rename classes, no functional changes 7 years ago
Michael Kirk 9f35b93647 CR: clarify comment 7 years ago
Michael Kirk 9bca1c8e52 Add some missing nullability annotations 7 years ago
Michael Kirk b3d3c27f39 CR: Split operations into separate files (no changes in functionality) 7 years ago
Michael Kirk ff3e9bcdd1 cr: add comment about operation queue 7 years ago
Michael Kirk bfd8eb63c6 Add some comments/nullability annotations for clarity 7 years ago
Michael Kirk c9218b59ca CR: add operation queue name 7 years ago
Michael Kirk 5a7d7634bf store keys before uploading to avoid race condition with service 7 years ago
Michael Kirk 1853e79c3e Don't retry send until SPK has been rotated
// FREEBIE
7 years ago
Michael Kirk 5e1306aaa5 Restore check debounce 7 years ago
Michael Kirk 8e488b5c3b remove unused code 7 years ago
Michael Kirk 85d35b52d6 restore PreKey upload failure tracking 7 years ago
Michael Kirk 39b691b697 Fix operations not being de-alloced 7 years ago
Michael Kirk 619597cd61 ensure operations run to completion on the PreKey operation queue 7 years ago
Michael Kirk 3df0e72eda Extract SPK rotation and CreatePreKey operations 7 years ago
Michael Kirk 286d3c8ce9 Serialize RefreshKeyOperation
TODO

-[] rotate signed prekey job
-[] verify current prekey w/ server
-[] create keys
7 years ago
Michael Kirk 01811a4891 fix swift method signature 7 years ago
Michael Kirk b11bd6ea46 extract convenience intitializer for param parser 7 years ago
Michael Kirk 1eb05c1d01 remove unused preKeyLastResort 7 years ago
Michael Kirk 920a82564f Merge tag '2.29.3.3' 7 years ago
Matthew Chen 22afe39cd0 Respond to CR. 7 years ago
Matthew Chen 2ea751bbac Clean up attachment downloads. 7 years ago
Matthew Chen 32f1ce9473 Clean up attachment downloads. 7 years ago
Matthew Chen b00858921d Update Cocoapods. 7 years ago
Matthew Chen 9b94580dae Update assertions.
* Streamline precompiled headers.
* Remove obsolete assertions in Constraints.h.
7 years ago
Matthew Chen e15b8ebe16 Add names to operation queues. 7 years ago
Matthew Chen 62c55c9cfb Fix broken tests. 7 years ago
Matthew Chen 2ba642c9e9 Ensure fakes/mocks are debug-only. 7 years ago
Matthew Chen e784f9feeb Move fakes to SSK/tests. 7 years ago
Michael Kirk df67e883f3 BlockList vs. "zero length" group names 7 years ago
Michael Kirk 24ea8262d5 consolidate blocked-group state tracking 7 years ago
Michael Kirk 0f9b0936df Use cached group details when rendering blocklist 7 years ago
Michael Kirk 1f15ba6dc5 Cache group details on blocking manager
In case the group thread is later deleted.
7 years ago
Michael Kirk b96e9a6a82 Fix: not receiving group deliveries
Previously we were using the wrong method - the local user's id is removed
from group.recipientIdentifiers
7 years ago
Michael Kirk f1e5b1862f Ignore messages from left groups 7 years ago
Michael Kirk b369ffa88f add type annotations 7 years ago
Michael Kirk b6eb1476cb Leave group when blocking it 7 years ago
Michael Kirk 2c9d905a16 Message processor ignores messages from blocked group 7 years ago
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Michael Kirk b282d51da0 SyncMessages for blocked groups 7 years ago
Michael Kirk 236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
7 years ago
Michael Kirk bfe1f38c75 update protos for group blocking 7 years ago
Michael Kirk 08c0b248ed fix group avatar updates and quote generation
don't shadow same-named variable
7 years ago
Matthew Chen 25239ca608 Respond to CR. 7 years ago
Matthew Chen 3935b019f4 Add base class for tests. 7 years ago
Michael Kirk e4d12feeb9 rev gallery db extension since our `isValid` checks have changed 7 years ago
Matthew Chen 106ecf2e8e Respond to CR. 7 years ago
Matthew Chen cc117b385c Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 7 years ago
Matthew Chen bd05cdc031 Rename TextSecureKitEnv to SSKEnvironment. 7 years ago
Matthew Chen bcceda1861 Respond to CR. 7 years ago
Matthew Chen cfb511aa57 Respond to CR. 7 years ago
Matthew Chen eb616a3411 Respond to CR. 7 years ago
Matthew Chen 535241ef9e Add test app context; use mock "document" and "shared data container" directories in tests, use mock keychain storage in tests. 7 years ago
Matthew Chen 399dd13cee Add test app context; use mock "document" and "shared data container" directories in tests, use mock keychain storage in tests. 7 years ago
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 7 years ago
Michael Kirk 9ec82b9a44 graceful failure when receiving too-small profile data 7 years ago
Michael Kirk 503cb046e4 remove unused FunctionalUtil code 7 years ago
Michael Kirk a2852ee930 Overflow math and safer asserts in Cryptography.m
Also removed some unused code
7 years ago
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
7 years ago
Michael Kirk a54ed8b201 Step 1/2 Prefer safer asserts 7 years ago
Matthew Chen 9fefdd2e2c Respond to CR. 7 years ago
Matthew Chen a2fe4dbe39 Refine image validation. 7 years ago
Matthew Chen 34a05cdb85 Refine image validation. 7 years ago
Matthew Chen b6649319da Fix build breakage. 7 years ago
Matthew Chen 27fa5dc2ef Make thumbnail logic thread-safe to being called on main thread. 7 years ago
Matthew Chen a04aa259ed Fix bug in sync loading of thumbnails. 7 years ago
Matthew Chen 5bdbf76b08 Cache "is valid image/video" properties. 7 years ago
Matthew Chen b1f2b9e75c Clean up thumbnail-related logic. 7 years ago
Matthew Chen a088b94c74 Update Cocoapods, fix build breakage. 7 years ago
Matthew Chen b91751a114 Respond to CR. 7 years ago
Matthew Chen 748b243156 Restore full-screen thumbnails. 7 years ago
Matthew Chen 9eb2a4f5ad Raise max valid image size. 7 years ago
Matthew Chen 72a71c185b Improve handling of thumbnails dir. 7 years ago
Matthew Chen 3a5d1877da Reduce thumbnail sizes. 7 years ago
Matthew Chen ec83ed182b Clean up. 7 years ago
Matthew Chen 32bf47fc74 Don't track thumbnail metadata in db; improve thumbnail quality. 7 years ago
Matthew Chen 8026d34651 Remove full-screen thumbnail. 7 years ago
Matthew Chen 2daa66fdf6 Use thumbnails dir. 7 years ago
Matthew Chen a9096209e9 Add failure methods to thumbnail service. 7 years ago
Matthew Chen 8748dc9b2e Modify new thumbnail system to include video and GIF thumbnails. 7 years ago
Matthew Chen 206432fdf0 Add failure methods to thumbnail service. 7 years ago
Matthew Chen f6e792c707 Add failure methods to thumbnail service. 7 years ago
Matthew Chen 3437361d70 Use new thumbnails in media gallery thumbnails. 7 years ago
Matthew Chen ac4365e1c9 Add OWSThumbnailService. 7 years ago
Matthew Chen 1831f0b1f8 Reorder AttachmentStream methods. 7 years ago
Matthew Chen 446ceb2b9c Rename AttachmentStream methods. 7 years ago
Matthew Chen 498828f93c Rename AttachmentStream methods. 7 years ago
Matthew Chen 44a3a81469 Update logging and asserts in hotfix changes. 7 years ago
Matthew Chen 9ab4da5c81 cherry-pick Merge branch 'charlesmchen/logSdp' 7 years ago
Matthew Chen fac7f6932f Rename TSGroupMetaMessage enum values. 7 years ago
Matthew Chen f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 7 years ago
Michael Kirk 495830f08d Fixup some SSK tests
Still more to do...
7 years ago
Michael Kirk 6d92413931 WIP: Run SSK tests
This just configures them to run. They're very broken at the moment.
7 years ago
Michael Kirk 6821e4a3a5 Don't include invalid media in gallery 7 years ago
Michael Kirk e715bf9ea2 image sizing
Validate image sizing
7 years ago
Matthew Chen 9477606732 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen f473f60111 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 03829779cc Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 7 years ago
Matthew Chen d81dea1d84 Add OWS log macros. 7 years ago
Matthew Chen 2d06c05a4f Log call session description. 7 years ago
Matthew Chen 713606271c Rename fail macros in Obj-C. 7 years ago
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 7 years ago
Matthew Chen 7be8f30877 Apply -> Never. 7 years ago
Matthew Chen d01023d862 Respond to CR. 7 years ago
Matthew Chen 11eaf1474e Add OWSProdExit(). 7 years ago
Matthew Chen 4f2f4a44a0 Respond to CR. 7 years ago
Matthew Chen d4f7b5d45b Respond to CR. 7 years ago
Matthew Chen f34bdd34bc Respond to CR. 7 years ago
Matthew Chen dd4f1babba Respond to CR. 7 years ago
Matthew Chen e1049fdfcc Respond to CR. 7 years ago
Matthew Chen bc23e38efc Respond to CR. 7 years ago
Matthew Chen cf6f3841a8 Apply new Swift logging. 7 years ago
Matthew Chen 3697974ca8 Rework Swift logging. 7 years ago
Michael Kirk 82e559d11b Use swift macros for main thread assert 7 years ago
Michael Kirk 2fc3a211f1 restrict debug methods 7 years ago
Michael Kirk 1295a09ab3 add comment 7 years ago
Matthew Chen 2b8b688fb6 Disable CDS. 7 years ago
Matthew Chen 2af0a897e1 Disable CDS. 7 years ago
Michael Kirk d57cbf2acd main thread operation init which creates background task
// FREEBIE
7 years ago
Matthew Chen 52be2127ff Sync conversation colors. 7 years ago
Matthew Chen b347c40c66 Clean up ahead of PR. 7 years ago
Matthew Chen 0a7b3537b5 Recreate message database view when message mappings are corrupt. 7 years ago
Matthew Chen 8ce9f3b24d Fix nominal race in "is registered" state. 7 years ago
Matthew Chen 26001e49d1 Unify log tags. 7 years ago
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 7 years ago
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
7 years ago
Matthew Chen db3df249bf Merge NSData categories. 7 years ago
Matthew Chen 2c9c028504 Clean up. 7 years ago
Matthew Chen 7437e7a6b1 Remove 'has' accessors from proto wrappers. 7 years ago
Matthew Chen 1868c58037 Converge appLaunchTime. 7 years ago
Matthew Chen b3c62d91be Merge remote-tracking branch 'origin/release/2.28.1' 7 years ago
Matthew Chen e5eda8b45d Add convenience initializers to proto wrappers. 7 years ago
Michael Kirk ab62868851 Remove noisy comments, update rotation time. 7 years ago
Matthew Chen 21523ac522 Respond to CR. 7 years ago
Matthew Chen 1ab0842403 Remove Obj-c proto parser. 7 years ago
Matthew Chen a5ffbdebb3 Remove Obj-c proto parser. 7 years ago
Matthew Chen dc012d46e4 Migrate call proto wrappers. 7 years ago
Matthew Chen 135a1655fd Migrate call proto wrappers. 7 years ago
Matthew Chen 32d0f23b22 Migrate call proto wrappers. 7 years ago
Matthew Chen 94675e880a Migrate call proto wrappers. 7 years ago
Matthew Chen 8837e5902e Migrate call proto wrappers. 7 years ago
Matthew Chen 68241e8a0a Respond to CR. 7 years ago
Matthew Chen 34a404f589 Clean up ahead of PR. 7 years ago
Matthew Chen 67110d0def Migrate to websocket proto wrappers. 7 years ago
Matthew Chen f795ec352e Migrate to backup proto wrappers. 7 years ago
Matthew Chen eaf59b122d Migrate to provisioning proto wrappers. 7 years ago
Matthew Chen 50db472be5 Migrate to fingerprint proto wrappers. 7 years ago
Matthew Chen 45e782c243 Revamp orphan data cleaner. 7 years ago
Michael Kirk 87f97b8b97 fix typo 7 years ago
Michael Kirk 504f4afae5 fix typo 7 years ago
Michael Kirk 2e5cae2a6b Fix typo 7 years ago
Matthew Chen 463addaa6c Ignore new calls in the incomplete calls job. 7 years ago
Matthew Chen d3a4447f81 Convert overzealous assert. 7 years ago
Matthew Chen 64c6d820fd Fix typo. 7 years ago
Matthew Chen d709a02493 Clean up formatting. 7 years ago
Michael Kirk 0bc03b0fd4 Move seed 7 years ago
Michael Kirk fc1ce02ae5 CR: Now that we have transaction semantics, this shouldn't happen.
// FREEBIE
7 years ago
Michael Kirk 1eb7fc986c YapDB introduced a method purpose built to do what we were approximating.
This seems a little more future proof / less error prone if we change the
registered extensions.
7 years ago
Michael Kirk df01c7e63e Update to latest YapDB (with Signal patches applied)
Applied branches:

- mkirk/invalidFinalIndices
- mkirk/upstream-unencrypted-headers

Also fixed up test suite.
7 years ago
Matthew Chen a647b5be48 Respond to CR. 7 years ago
Matthew Chen 3f47524373 Respond to CR. 7 years ago
Matthew Chen 03a9b21cfd Respond to CR. 7 years ago
Matthew Chen 632dc145fd Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 6be3d2e42d Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 8d814a5210 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 950cab7eb9 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen ff8565dbd5 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen d3adb80242 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen ab31e5a07f Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 28acea3cf0 Respond to CR. 7 years ago
Matthew Chen e1eb58ba3b Swift proto parsing wrappers. 7 years ago
Matthew Chen 0d23b06cbc Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 377634a1f7 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen b164ce9403 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 73f22ae62e Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 6941ab8c8c Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 827f979282 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 77810f5918 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 64c99988a7 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 02a4de637e Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 2b05bbc0aa Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen 937ae24556 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen d8378c5372 Code generate Swift wrappers for protocol buffers. 7 years ago
Matthew Chen f814157a9e Code generate Swift wrappers for protocol buffers. 7 years ago