keejef
/
session-ios
mirror of https://github.com/oxen-io/session-ios
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Group's meta message defaults to "Delivery"

Browse Source 
// FREEBIE
pull/1/head
Michael Kirk 7 years ago
parent f45970922f
commit eec7678979
16 changed files with 37 additions and 26 deletions
Show Stats Download Patch File Download Diff File

6
Signal/src/ViewControllers/DebugUI/DebugUIMessages.m
Unescape Escape View File

@ -3700,7 +3700,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:(configuration.isEnabled ? configuration.durationSeconds expiresInSeconds:(configuration.isEnabled ? configuration.durationSeconds
: 0)expireStartedAt:0 : 0)expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
DDLogError(@"%@ resurrectNewOutgoingMessages2 timestamp: %llu.", self.logTag, message.timestamp); DDLogError(@"%@ resurrectNewOutgoingMessages2 timestamp: %llu.", self.logTag, message.timestamp);
[messages addObject:message]; [messages addObject:message];
@ -3778,7 +3778,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
[message saveWithTransaction:transaction]; [message saveWithTransaction:transaction];
[message updateWithMessageState:TSOutgoingMessageStateSentToService transaction:transaction]; [message updateWithMessageState:TSOutgoingMessageStateSentToService transaction:transaction];
@ -4016,7 +4016,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:isVoiceMessage isVoiceMessage:isVoiceMessage
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:quotedMessage]; quotedMessage:quotedMessage];
if (attachmentId.length > 0 && filename.length > 0) { if (attachmentId.length > 0 && filename.length > 0) {

2
SignalMessaging/utils/ThreadUtil.m
Unescape Escape View File

@ -138,7 +138,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:expiresInSeconds expiresInSeconds:expiresInSeconds
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:[attachment isVoiceMessage] isVoiceMessage:[attachment isVoiceMessage]
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:[quotedReplyModel buildQuotedMessage]]; quotedMessage:[quotedReplyModel buildQuotedMessage]];
[messageSender enqueueAttachment:attachment.dataSource [messageSender enqueueAttachment:attachment.dataSource

2
SignalServiceKit/src/Devices/OWSReadReceiptsForSenderMessage.m
Unescape Escape View File

@ -28,7 +28,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
if (!self) { if (!self) {
return self; return self;

2
SignalServiceKit/src/Devices/OWSRecordTranscriptJob.m
Unescape Escape View File

@ -94,7 +94,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:transcript.expirationDuration expiresInSeconds:transcript.expirationDuration
expireStartedAt:transcript.expirationStartedAt expireStartedAt:transcript.expirationStartedAt
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:transcript.quotedMessage]; quotedMessage:transcript.quotedMessage];
// TODO: When written, desktop didn't yet support sending quotedMessages, so we didn't have a // TODO: When written, desktop didn't yet support sending quotedMessages, so we didn't have a

2
SignalServiceKit/src/Messages/DeviceSyncing/OWSOutgoingSyncMessage.m
Unescape Escape View File

@ -21,7 +21,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
if (!self) { if (!self) {

2
SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncContactsMessage.m
Unescape Escape View File

@ -37,7 +37,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
if (!self) { if (!self) {
return self; return self;

2
SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncGroupsMessage.m
Unescape Escape View File

@ -23,7 +23,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
} }

2
SignalServiceKit/src/Messages/DeviceSyncing/OWSSyncGroupsRequestMessage.m
Unescape Escape View File

@ -27,7 +27,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
if (!self) { if (!self) {
return self; return self;

2
SignalServiceKit/src/Messages/Interactions/OWSDisappearingMessagesConfigurationMessage.m
Unescape Escape View File

@ -33,7 +33,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
if (!self) { if (!self) {
return self; return self;

2
SignalServiceKit/src/Messages/Interactions/OWSDynamicOutgoingMessage.m
Unescape Escape View File

@ -34,7 +34,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
if (self) { if (self) {

2
SignalServiceKit/src/Messages/Interactions/OWSEndSessionMessage.m
Unescape Escape View File

@ -18,7 +18,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
} }

2
SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.h
Unescape Escape View File

@ -22,7 +22,7 @@ typedef NS_ENUM(NSInteger, TSOutgoingMessageState) {
}; };
typedef NS_ENUM(NSInteger, TSGroupMetaMessage) { typedef NS_ENUM(NSInteger, TSGroupMetaMessage) {
TSGroupMessageNone, TSGroupMessageUnspecified,
TSGroupMessageNew, TSGroupMessageNew,
TSGroupMessageUpdate, TSGroupMessageUpdate,
TSGroupMessageDeliver, TSGroupMessageDeliver,

29
SignalServiceKit/src/Messages/Interactions/TSOutgoingMessage.m
Unescape Escape View File

@ -110,9 +110,6 @@ NSString *const kTSOutgoingMessageSentRecipientAll = @"kTSOutgoingMessageSentRec
[attachmentIds addObject:attachmentId]; [attachmentIds addObject:attachmentId];
} }
TSGroupMetaMessage groupMetaMessage =
[thread isKindOfClass:TSGroupThread.class] ? TSGroupMessageDeliver : TSGroupMessageNone;
return [[TSOutgoingMessage alloc] initOutgoingMessageWithTimestamp:[NSDate ows_millisecondTimeStamp] return [[TSOutgoingMessage alloc] initOutgoingMessageWithTimestamp:[NSDate ows_millisecondTimeStamp]
inThread:thread inThread:thread
messageBody:body messageBody:body
@ -120,7 +117,7 @@ NSString *const kTSOutgoingMessageSentRecipientAll = @"kTSOutgoingMessageSentRec
expiresInSeconds:expiresInSeconds expiresInSeconds:expiresInSeconds
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:groupMetaMessage groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:quotedMessage]; quotedMessage:quotedMessage];
} }
@ -162,7 +159,20 @@ NSString *const kTSOutgoingMessageSentRecipientAll = @"kTSOutgoingMessageSentRec
_messageState = TSOutgoingMessageStateAttemptingOut; _messageState = TSOutgoingMessageStateAttemptingOut;
_sentRecipients = [NSArray new]; _sentRecipients = [NSArray new];
_hasSyncedTranscript = NO; _hasSyncedTranscript = NO;
_groupMetaMessage = groupMetaMessage;
if ([thread isKindOfClass:TSGroupThread.class]) {
// Unless specified, we assume group messages are "Delivery" i.e. normal messages.
if (groupMetaMessage == TSGroupMessageUnspecified) {
_groupMetaMessage = TSGroupMessageDeliver;
} else {
_groupMetaMessage = groupMetaMessage;
}
} else {
OWSAssert(groupMetaMessage == TSGroupMessageUnspecified);
// Specifying a group meta message only makes sense for Group threads
_groupMetaMessage = TSGroupMessageUnspecified;
}
_isVoiceMessage = isVoiceMessage; _isVoiceMessage = isVoiceMessage;
_attachmentFilenameMap = [NSMutableDictionary new]; _attachmentFilenameMap = [NSMutableDictionary new];
@ -172,12 +182,11 @@ NSString *const kTSOutgoingMessageSentRecipientAll = @"kTSOutgoingMessageSentRec
- (BOOL)shouldBeSaved - (BOOL)shouldBeSaved
{ {
if (!(self.groupMetaMessage == TSGroupMessageDeliver || self.groupMetaMessage == TSGroupMessageNone)) { if (self.groupMetaMessage == TSGroupMessageDeliver || self.groupMetaMessage == TSGroupMessageUnspecified) {
DDLogDebug(@"%@ Skipping save for group meta message.", self.logTag); return YES;
return NO;
} }
return YES; return NO;
} }
- (void)saveWithTransaction:(YapDatabaseReadWriteTransaction *)transaction - (void)saveWithTransaction:(YapDatabaseReadWriteTransaction *)transaction
@ -186,6 +195,8 @@ NSString *const kTSOutgoingMessageSentRecipientAll = @"kTSOutgoingMessageSentRec
// There's no need to save this message, since it's not displayed to the user. // There's no need to save this message, since it's not displayed to the user.
// //
// Should we find a need to save this in the future, we need to exclude any non-serializable properties. // Should we find a need to save this in the future, we need to exclude any non-serializable properties.
DDLogDebug(@"%@ Skipping save for group meta message.", self.logTag);
return; return;
} }

2
SignalServiceKit/src/Messages/OWSOutgoingCallMessage.m
Unescape Escape View File

@ -29,7 +29,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
if (!self) { if (!self) {
return self; return self;

2
SignalServiceKit/src/Messages/OWSOutgoingNullMessage.m
Unescape Escape View File

@ -31,7 +31,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
if (!self) { if (!self) {
return self; return self;

2
SignalServiceKit/src/Messages/OWSProfileKeyMessage.m
Unescape Escape View File

@ -21,7 +21,7 @@ NS_ASSUME_NONNULL_BEGIN
expiresInSeconds:0 expiresInSeconds:0
expireStartedAt:0 expireStartedAt:0
isVoiceMessage:NO isVoiceMessage:NO
groupMetaMessage:TSGroupMessageNone groupMetaMessage:TSGroupMessageUnspecified
quotedMessage:nil]; quotedMessage:nil];
} }

Write Preview
Loading…
Cancel
Save