make the job permanent fail if missing required details

SessionMessagingKit/Jobs/Types/AttachmentDownloadJob.swift

@@ -25,7 +25,7 @@ public enum AttachmentDownloadJob: JobExecutor {
             let attachment: Attachment = Storage.shared
                 .read({ db in try Attachment.fetchOne(db, id: details.attachmentId) })
         else {
-            failure(job, JobRunnerError.missingRequiredDetails, false)
+            failure(job, JobRunnerError.missingRequiredDetails, true)
             return
         }
         

SessionMessagingKit/Jobs/Types/AttachmentUploadJob.swift

@@ -31,7 +31,7 @@ public enum AttachmentUploadJob: JobExecutor {
                 return (attachment, try OpenGroup.fetchOne(db, id: threadId))
             })
         else {
-            failure(job, JobRunnerError.missingRequiredDetails, false)
+            failure(job, JobRunnerError.missingRequiredDetails, true)
             return
         }
         

SessionMessagingKit/Jobs/Types/GroupLeavingJob.swift

@@ -24,7 +24,7 @@ public enum GroupLeavingJob: JobExecutor {
             let details: Details = try? JSONDecoder().decode(Details.self, from: detailsData),
             let interactionId: Int64 = job.interactionId
         else {
-            failure(job, JobRunnerError.missingRequiredDetails, false)
+            failure(job, JobRunnerError.missingRequiredDetails, true)
             return
         }
         

SessionMessagingKit/Jobs/Types/MessageReceiveJob.swift

@@ -21,7 +21,7 @@ public enum MessageReceiveJob: JobExecutor {
             let detailsData: Data = job.details,
             let details: Details = try? JSONDecoder().decode(Details.self, from: detailsData)
         else {
-            failure(job, JobRunnerError.missingRequiredDetails, false)
+            failure(job, JobRunnerError.missingRequiredDetails, true)
             return
         }
         

SessionMessagingKit/Jobs/Types/MessageSendJob.swift

@@ -23,7 +23,7 @@ public enum MessageSendJob: JobExecutor {
             let detailsData: Data = job.details,
             let details: Details = try? JSONDecoder().decode(Details.self, from: detailsData)
         else {
-            failure(job, JobRunnerError.missingRequiredDetails, false)
+            failure(job, JobRunnerError.missingRequiredDetails, true)
             return
         }
         
@@ -36,7 +36,7 @@ public enum MessageSendJob: JobExecutor {
                 let jobId: Int64 = job.id,
                 let interactionId: Int64 = job.interactionId
             else {
-                failure(job, JobRunnerError.missingRequiredDetails, false)
+                failure(job, JobRunnerError.missingRequiredDetails, true)
                 return
             }
             

SessionMessagingKit/Jobs/Types/NotifyPushServerJob.swift

@@ -21,7 +21,7 @@ public enum NotifyPushServerJob: JobExecutor {
             let detailsData: Data = job.details,
             let details: Details = try? JSONDecoder().decode(Details.self, from: detailsData)
         else {
-            failure(job, JobRunnerError.missingRequiredDetails, false)
+            failure(job, JobRunnerError.missingRequiredDetails, true)
             return
         }
         

SessionMessagingKit/Jobs/Types/SendReadReceiptsJob.swift

@@ -23,7 +23,7 @@ public enum SendReadReceiptsJob: JobExecutor {
             let detailsData: Data = job.details,
             let details: Details = try? JSONDecoder().decode(Details.self, from: detailsData)
         else {
-            failure(job, JobRunnerError.missingRequiredDetails, false)
+            failure(job, JobRunnerError.missingRequiredDetails, true)
             return
         }