Respond to CR.

pull/1/head
Matthew Chen 7 years ago
parent dfc39b4a1d
commit c15ddf85f8

@ -356,17 +356,17 @@ NSString *NSStringForOutgoingMessageRecipientState(OWSOutgoingMessageRecipientSt
- (void)dealloc - (void)dealloc
{ {
[self cleanUpTemporaryAttachmentsIfNecessary]; [self removeTemporaryAttachments];
} }
// Each message has the responsibility for eagerly cleaning up its attachments. // Each message has the responsibility for eagerly cleaning up its attachments.
// Normally this is done in [TSMessage removeWithTransaction], but that doesn't // Normally this is done in [TSMessage removeWithTransaction], but that doesn't
// apply for "transient", unsaved messages (i.e. shouldBeSaved == NO). These // apply for "transient", unsaved messages (i.e. shouldBeSaved == NO). These
// messages should clean up their attachments upon deallocation. // messages should clean up their attachments upon deallocation.
- (void)cleanUpTemporaryAttachmentsIfNecessary - (void)removeTemporaryAttachments
{ {
if (self.shouldBeSaved) { if (self.shouldBeSaved) {
// Message in not transient; no need to clean up attachments. // Message is not transient; no need to clean up attachments.
return; return;
} }
NSArray<NSString *> *_Nullable attachmentIds = self.attachmentIds; NSArray<NSString *> *_Nullable attachmentIds = self.attachmentIds;

Loading…
Cancel
Save