Respond to CR.

pull/1/head
Matthew Chen 7 years ago
parent c6132249e6
commit b75bc27d55

@ -4791,11 +4791,11 @@ typedef enum : NSUInteger {
]] ]]
forGroup:self.thread.uniqueId]; forGroup:self.thread.uniqueId];
// We need to impose the range restrictions on the mappings immediately to avoid
// doing a great deal of unnecessary work and causing a perf hotspot.
[self.uiDatabaseConnection readWithBlock:^(YapDatabaseReadTransaction *transaction) { [self.uiDatabaseConnection readWithBlock:^(YapDatabaseReadTransaction *transaction) {
[self.messageMappings updateWithTransaction:transaction]; [self.messageMappings updateWithTransaction:transaction];
}]; }];
// We need to impose the range restrictions on the mappings immediately to avoid
// doing a great deal of unnecessary work and causing a perf hotspot.
[self updateMessageMappingRangeOptions]; [self updateMessageMappingRangeOptions];
} }

@ -137,7 +137,7 @@ class MessageDetailViewController: OWSViewController, MediaGalleryDataSourceDele
view.addSubview(scrollView) view.addSubview(scrollView)
scrollView.autoPinWidthToSuperview(withMargin: 0) scrollView.autoPinWidthToSuperview(withMargin: 0)
if (scrollView.applyInsetsFix()) { if scrollView.applyInsetsFix() {
scrollView.autoPin(toTopLayoutGuideOf: self, withInset: 0) scrollView.autoPin(toTopLayoutGuideOf: self, withInset: 0)
} else { } else {
scrollView.autoPinEdge(toSuperviewEdge: .top) scrollView.autoPinEdge(toSuperviewEdge: .top)
@ -663,7 +663,7 @@ class MessageDetailViewController: OWSViewController, MediaGalleryDataSourceDele
if let audioAttachmentPlayer = self.audioAttachmentPlayer { if let audioAttachmentPlayer = self.audioAttachmentPlayer {
// Is this player associated with this media adapter? // Is this player associated with this media adapter?
if (audioAttachmentPlayer.owner as? ConversationViewItem == viewItem) { if audioAttachmentPlayer.owner as? ConversationViewItem == viewItem {
// Tap to pause & unpause. // Tap to pause & unpause.
audioAttachmentPlayer.togglePlayState() audioAttachmentPlayer.togglePlayState()
return return

Loading…
Cancel
Save