Respond to CR.

pull/2/head
Matthew Chen 5 years ago
parent 01d9993b9d
commit aad5533127

@ -648,7 +648,7 @@ class NotificationActionHandler {
// can be visible to the user immediately upon opening the app, rather than having to watch // can be visible to the user immediately upon opening the app, rather than having to watch
// it animate in from the homescreen. // it animate in from the homescreen.
let shouldAnimate = UIApplication.shared.applicationState == .active let shouldAnimate = UIApplication.shared.applicationState == .active
signalApp.presentConversationAndShowFirstUnreadMessage(forThreadId: threadId, animated: shouldAnimate) signalApp.presentConversationAndScrollToFirstUnreadMessage(forThreadId: threadId, animated: shouldAnimate)
return Promise.value(()) return Promise.value(())
} }

@ -46,7 +46,7 @@ NS_ASSUME_NONNULL_BEGIN
focusMessageId:(nullable NSString *)focusMessageId focusMessageId:(nullable NSString *)focusMessageId
animated:(BOOL)isAnimated; animated:(BOOL)isAnimated;
- (void)presentConversationAndShowFirstUnreadMessageForThreadId:(NSString *)threadId animated:(BOOL)isAnimated; - (void)presentConversationAndScrollToFirstUnreadMessageForThreadId:(NSString *)threadId animated:(BOOL)isAnimated;
#pragma mark - Methods #pragma mark - Methods

@ -122,7 +122,7 @@ NS_ASSUME_NONNULL_BEGIN
}); });
} }
- (void)presentConversationAndShowFirstUnreadMessageForThreadId:(NSString *)threadId animated:(BOOL)isAnimated - (void)presentConversationAndScrollToFirstUnreadMessageForThreadId:(NSString *)threadId animated:(BOOL)isAnimated
{ {
OWSAssertIsOnMainThread(); OWSAssertIsOnMainThread();
OWSAssertDebug(threadId.length > 0); OWSAssertDebug(threadId.length > 0);

Loading…
Cancel
Save