can delete text messages again

// FREEBIE
pull/1/head
sdkjfhsdkjhfsdlkjhfsdf 7 years ago
parent f5b9ae97ef
commit 82aeee301d

@ -492,12 +492,12 @@ NSString *NSStringForOWSMessageCellType(OWSMessageCellType cellType)
[[UIMenuItem alloc] initWithTitle:NSLocalizedString(@"EDIT_ITEM_MESSAGE_METADATA_ACTION", [[UIMenuItem alloc] initWithTitle:NSLocalizedString(@"EDIT_ITEM_MESSAGE_METADATA_ACTION",
@"Short name for edit menu item to show message metadata.") @"Short name for edit menu item to show message metadata.")
action:self.metadataActionSelector], action:self.metadataActionSelector],
// FIXME this is going to be confusing if the text/attachment look like separate entities. // FIXME: when deleting a caption, users will be surprised that it also deletes the attachment.
// we can re-enable this once it's clear that deleting the text would also delete the attachment. // We either need to implement a way to remove the caption separate from the attachment
// [[UIMenuItem alloc] initWithTitle:NSLocalizedString(@"EDIT_ITEM_DELETE_ACTION", // or make a design change which clarifies that the whole message is getting deleted.
// @"Short name for edit menu item to delete contents of media [[UIMenuItem alloc] initWithTitle:NSLocalizedString(@"EDIT_ITEM_DELETE_ACTION",
// message.") @"Short name for edit menu item to delete contents of media message.")
// action:self.deleteActionSelector], action:self.deleteActionSelector]
]; ];
} }
- (NSArray<UIMenuItem *> *)mediaMenuControllerItems - (NSArray<UIMenuItem *> *)mediaMenuControllerItems

Loading…
Cancel
Save