sync answer and end call message

Session/Calls/Call Management/SessionCallManager.swift

@@ -105,10 +105,11 @@ public final class SessionCallManager: NSObject {
         guard let call = currentCall else { return }
         if let reason = reason {
             self.provider.reportCall(with: call.callID, endedAt: nil, reason: reason)
-            if reason == .unanswered {
-                call.updateCallMessage(mode: .unanswered)
-            } else {
-                call.updateCallMessage(mode: .remote)
+            switch (reason) {
+            case .unanswered: call.updateCallMessage(mode: .unanswered)
+            case .declinedElsewhere: call.updateCallMessage(mode: .local)
+            case .answeredElsewhere: break
+            default: call.updateCallMessage(mode: .remote)
             }
         } else {
             call.updateCallMessage(mode: .local)

Session/Meta/AppDelegate.swift

@@ -17,7 +17,12 @@ extension AppDelegate {
             conversationVC.inputAccessoryView?.alpha = 0
         }
         presentingVC.present(callVC, animated: true, completion: nil)
+    }
     
+    @objc func dismissAllCallUI() {
+        if let currentBanner = IncomingCallBanner.current { currentBanner.dismiss() }
+        if let callVC = CurrentAppContext().frontmostViewController() as? CallVC { callVC.handleEndCallMessage() }
+        if let miniCallView = MiniCallView.current { miniCallView.dismiss() }
     }
     
     @objc func setUpCallHandling() {
@@ -72,6 +77,10 @@ extension AppDelegate {
         MessageReceiver.handleAnswerCallMessage = { message in
             DispatchQueue.main.async {
                 guard let call = AppEnvironment.shared.callManager.currentCall, message.uuid! == call.uuid else { return }
+                if message.sender! == getUserHexEncodedPublicKey() {
+                    self.dismissAllCallUI()
+                    AppEnvironment.shared.callManager.reportCurrentCallEnded(reason: .answeredElsewhere)
+                } else {
                     AppEnvironment.shared.callManager.invalidateTimeoutTimer()
                     call.hasStartedConnecting = true
                     let sdp = RTCSessionDescription(type: .answer, sdp: message.sdps![0])
@@ -80,16 +89,20 @@ extension AppDelegate {
                     callVC.handleAnswerMessage(message)
                 }
             }
+        }
         // End call messages
         MessageReceiver.handleEndCallMessage = { message in
             DispatchQueue.main.async {
-                if let currentBanner = IncomingCallBanner.current { currentBanner.dismiss() }
-                if let callVC = CurrentAppContext().frontmostViewController() as? CallVC { callVC.handleEndCallMessage() }
-                if let miniCallView = MiniCallView.current { miniCallView.dismiss() }
+                guard let call = AppEnvironment.shared.callManager.currentCall, message.uuid! == call.uuid else { return }
+                self.dismissAllCallUI()
+                if message.sender! == getUserHexEncodedPublicKey() {
+                    AppEnvironment.shared.callManager.reportCurrentCallEnded(reason: .declinedElsewhere)
+                } else {
                     AppEnvironment.shared.callManager.reportCurrentCallEnded(reason: .remoteEnded)
                 }
             }
         }
+    }
     
     // MARK: Configuration message
     @objc(syncConfigurationIfNeeded)

SessionMessagingKit/Messages/Control Messages/CallMessage.swift

@@ -9,6 +9,7 @@ public final class CallMessage : ControlMessage {
     public var sdps: [String]?
         
     public override var ttl: UInt64 { 2 * 60 * 1000 }
+    public override var isSelfSendValid: Bool { true }
     
     // NOTE: Multiple ICE candidates may be batched together for performance
     

SessionMessagingKit/Sending & Receiving/MessageSender.swift

@@ -135,8 +135,8 @@ public final class MessageSender : NSObject {
         // • a sync message
         // • a closed group control message of type `new`
         // • an unsend request
-        let isNewClosedGroupControlMessage = given(message as? ClosedGroupControlMessage) { if case .new = $0.kind { return true } else { return false } } ?? false
-        guard !isSelfSend || message is ConfigurationMessage || isSyncMessage || isNewClosedGroupControlMessage || message is UnsendRequest else {
+        // • a call message of type `answer` or `endCall`
+        guard !isSelfSend || isSyncMessage || shouldSyncMessage(message) else {
             storage.write(with: { transaction in
                 MessageSender.handleSuccessfulMessageSend(message, to: destination, using: transaction)
                 seal.fulfill(())
@@ -379,4 +379,23 @@ public final class MessageSender : NSObject {
         tsMessage.update(sendingError: error, transaction: transaction)
         MessageInvalidator.invalidate(tsMessage, with: transaction)
     }
+    
+    // MARK: Utils
+    private static func shouldSyncMessage(_ message: Message) -> Bool {
+        let isNewClosedGroupControlMessage = given(message as? ClosedGroupControlMessage) {
+            if case .new = $0.kind {
+                return true
+            } else {
+                return false
+            } } ?? false
+        let isCallControlMessage = given(message as? CallMessage) {
+            if case .answer = $0.kind {
+                return true
+            } else if case .endCall = $0.kind {
+                return true
+            } else {
+                return false
+            } } ?? false
+        return isNewClosedGroupControlMessage || isCallControlMessage || message is ConfigurationMessage || message is UnsendRequest
+    }
 }