Respond to CR.

pull/1/head
Matthew Chen 7 years ago
parent 888bf9256f
commit 81522e4a23

@ -1310,7 +1310,7 @@ NSString *const OWSMessageSenderRateLimitedException = @"RateLimitedException";
TSRequest *request = TSRequest *request =
[[TSRecipientPrekeyRequest alloc] initWithRecipient:identifier deviceId:[deviceNumber stringValue]]; [[TSRecipientPrekeyRequest alloc] initWithRecipient:identifier deviceId:[deviceNumber stringValue]];
[self.networkManager makeRequest:request [self.networkManager makeRequest:request
shouldCompleteOnMainQueue:NO completionQueue:dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0)
success:^(NSURLSessionDataTask *task, id responseObject) { success:^(NSURLSessionDataTask *task, id responseObject) {
bundle = [PreKeyBundle preKeyBundleFromDictionary:responseObject forDeviceNumber:deviceNumber]; bundle = [PreKeyBundle preKeyBundleFromDictionary:responseObject forDeviceNumber:deviceNumber];
dispatch_semaphore_signal(sema); dispatch_semaphore_signal(sema);

@ -41,9 +41,12 @@ typedef void (^TSNetworkManagerFailure)(NSURLSessionDataTask *task, NSError *err
failure:(TSNetworkManagerFailure)failure NS_SWIFT_NAME(makeRequest(_:success:failure:)); failure:(TSNetworkManagerFailure)failure NS_SWIFT_NAME(makeRequest(_:success:failure:));
- (void)makeRequest:(TSRequest *)request - (void)makeRequest:(TSRequest *)request
shouldCompleteOnMainQueue:(BOOL)shouldCompleteOnMainQueue completionQueue:(dispatch_queue_t)completionQueue
success:(TSNetworkManagerSuccess)success success:(TSNetworkManagerSuccess)success
failure:(TSNetworkManagerFailure)failure NS_SWIFT_NAME(makeRequest(_:shouldCompleteOnMainQueue:success:failure:)); failure:(TSNetworkManagerFailure)failure NS_SWIFT_NAME(makeRequest(_:shouldCompleteOnMainQueue
:success
:failure
:));
@end @end

@ -58,13 +58,13 @@ typedef void (^failureBlock)(NSURLSessionDataTask *task, NSError *error);
success:(TSNetworkManagerSuccess)success success:(TSNetworkManagerSuccess)success
failure:(TSNetworkManagerFailure)failure failure:(TSNetworkManagerFailure)failure
{ {
return [self makeRequest:request shouldCompleteOnMainQueue:YES success:success failure:failure]; return [self makeRequest:request completionQueue:dispatch_get_main_queue() success:success failure:failure];
} }
- (void)makeRequest:(TSRequest *)request - (void)makeRequest:(TSRequest *)request
shouldCompleteOnMainQueue:(BOOL)shouldCompleteOnMainQueue completionQueue:(dispatch_queue_t)completionQueue
success:(TSNetworkManagerSuccess)success success:(TSNetworkManagerSuccess)success
failure:(TSNetworkManagerFailure)failureBlock failure:(TSNetworkManagerFailure)failureBlock
{ {
OWSAssert(request); OWSAssert(request);
OWSAssert(success); OWSAssert(success);
@ -87,11 +87,7 @@ typedef void (^failureBlock)(NSURLSessionDataTask *task, NSError *error);
AFHTTPSessionManager *sessionManager = [OWSSignalService sharedInstance].signalServiceSessionManager; AFHTTPSessionManager *sessionManager = [OWSSignalService sharedInstance].signalServiceSessionManager;
// [OWSSignalService signalServiceSessionManager] always returns a new instance of // [OWSSignalService signalServiceSessionManager] always returns a new instance of
// session manager, so its safe to reconfigure it here. // session manager, so its safe to reconfigure it here.
if (shouldCompleteOnMainQueue) { sessionManager.completionQueue = completionQueue;
sessionManager.completionQueue = dispatch_get_main_queue();
} else {
sessionManager.completionQueue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);
}
if ([request isKindOfClass:[TSVerifyCodeRequest class]]) { if ([request isKindOfClass:[TSVerifyCodeRequest class]]) {
// We plant the Authorization parameter ourselves, no need to double add. // We plant the Authorization parameter ourselves, no need to double add.

Loading…
Cancel
Save