bail on scripts whenever an error is encountered

remove unused script
also use consistent bash

// FREEBIE

Signal/translations/bin/append-strings-from-file

@@ -1,37 +0,0 @@
-#!/usr/bin/env bash
-
-set -x
-
-function usage() {
-cat <<EOS
-Extracts string from target file and appends to Localizable.strings
-
-    $0 <filename.m>
-
-e.g.
-
-    $0 path/to/my/ClassName.m
-EOS
-}
-
-BIN_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-cd $BIN_DIR/..
-
-TARGET=$1
-if [[ -z $TARGET ]]
-then
-  echo "Can't proceed without target"
-  usage
-  exit 1
-fi
-
-if [[ ! -e $TARGET ]]
-then
-  echo "No file exists at ${TARGET}"
-  exit 1
-fi
-
-# pwd.
-OUTPUT_DIR=en.lproj/
-mkdir -p "${OUTPUT_DIR}"
-genstrings -a -o "${OUTPUT_DIR}" "${TARGET}"

Signal/translations/bin/auto-genstrings

@@ -1,4 +1,8 @@
-#!/bin/bash
+#!/usr/bin/env bash
+
+set -e
+set -x
+
 TARGETS="Signal/src ../SignalServiceKit/src"
 TMP="$(mktemp -d)"
 STRINGFILE="Signal/translations/en.lproj/Localizable.strings"

Signal/translations/bin/pull-translations

@@ -1,5 +1,8 @@
 #!/usr/bin/env bash
+
 set -x
+set -e
+
 BIN_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
 cd $BIN_DIR/..

Signal/translations/bin/push-translation-source

@@ -1,5 +1,8 @@
 #!/usr/bin/env bash
+
 set -x
+set -e
+
 BIN_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
 cd $BIN_DIR/..

Signal/translations/bin/sync-translations

@@ -1,5 +1,7 @@
 #!/usr/bin/env bash
 set -x
+set -e
+
 BIN_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
 cd $BIN_DIR/..