Merge pull request #679 from mpretty-cyro/fix/migration-crash

Fixed an issue which could cause the DB migration to fail for users with closed groups

SessionMessagingKit/Database/Models/Interaction.swift

@@ -348,10 +348,14 @@ public struct Interaction: Codable, Identifiable, Equatable, FetchableRecord, Mu
                         ).insert(db)
                         
                     case .closedGroup:
-                        guard
+                        let closedGroupMemberIds: Set<String> = (try? GroupMember
-                            let closedGroup: ClosedGroup = try? thread.closedGroup.fetchOne(db),
+                            .select(.profileId)
-                            let members: [GroupMember] = try? closedGroup.members.fetchAll(db)
+                            .filter(GroupMember.Columns.groupId == thread.id)
-                        else {
+                            .asRequest(of: String.self)
+                            .fetchSet(db))
+                            .defaulting(to: [])
+                        
+                        guard !closedGroupMemberIds.isEmpty else {
                             SNLog("Inserted an interaction but couldn't find it's associated thread members")
                             return
                         }
@@ -359,12 +363,12 @@ public struct Interaction: Codable, Identifiable, Equatable, FetchableRecord, Mu
                         // Exclude the current user when creating recipient states (as they will never
                         // receive the message resulting in the message getting flagged as failed)
                         let userPublicKey: String = getUserHexEncodedPublicKey(db)
-                        try members
+                        try closedGroupMemberIds
-                            .filter { member -> Bool in member.profileId != userPublicKey }
+                            .filter { memberId -> Bool in memberId != userPublicKey }
-                            .forEach { member in
+                            .forEach { memberId in
                                 try RecipientState(
                                     interactionId: interactionId,
-                                    recipientId: member.profileId,
+                                    recipientId: memberId,
                                     state: .sending
                                 ).insert(db)
                             }