Clean up backup code.

pull/1/head
Matthew Chen 7 years ago committed by Matthew Chen
parent 08149005b1
commit 70d14c84c4

@ -284,10 +284,6 @@ typedef NS_ENUM(NSInteger, CellState) { kArchiveState, kInboxState };
} }
[self updateBarButtonItems]; [self updateBarButtonItems];
dispatch_async(dispatch_get_main_queue(), ^{
[self settingsButtonPressed:nil];
});
} }
- (void)viewDidAppear:(BOOL)animated - (void)viewDidAppear:(BOOL)animated

@ -111,9 +111,7 @@ NS_ASSUME_NONNULL_BEGIN
{ {
OWSAssert(value); OWSAssert(value);
// TODO: This should eventually be the backup key stored in the Signal Service // TODO: Use actual key.
// and retrieved with the backup PIN. It will eventually be stored in
// the keychain.
[self.dbConnection setObject:value [self.dbConnection setObject:value
forKey:OWSBackup_BackupKeyKey forKey:OWSBackup_BackupKeyKey
inCollection:OWSPrimaryStorage_OWSBackupCollection]; inCollection:OWSPrimaryStorage_OWSBackupCollection];
@ -124,8 +122,7 @@ NS_ASSUME_NONNULL_BEGIN
NSData *_Nullable result = NSData *_Nullable result =
[self.dbConnection objectForKey:OWSBackup_BackupKeyKey inCollection:OWSPrimaryStorage_OWSBackupCollection]; [self.dbConnection objectForKey:OWSBackup_BackupKeyKey inCollection:OWSPrimaryStorage_OWSBackupCollection];
if (!result) { if (!result) {
// TODO: This is temporary measure until we have proper private key // TODO: Use actual key.
// storage in the service.
const NSUInteger kBackupPrivateKeyLength = 32; const NSUInteger kBackupPrivateKeyLength = 32;
result = [Randomness generateRandomBytes:kBackupPrivateKeyLength]; result = [Randomness generateRandomBytes:kBackupPrivateKeyLength];
[self setBackupPrivateKey:result]; [self setBackupPrivateKey:result];
@ -208,18 +205,16 @@ NS_ASSUME_NONNULL_BEGIN
NSDate *_Nullable lastExportSuccessDate = self.lastExportSuccessDate; NSDate *_Nullable lastExportSuccessDate = self.lastExportSuccessDate;
NSDate *_Nullable lastExportFailureDate = self.lastExportFailureDate; NSDate *_Nullable lastExportFailureDate = self.lastExportFailureDate;
// Wait N hours before retrying after a success. // Wait N hours before retrying after a success.
// const NSTimeInterval kRetryAfterSuccess = 24 * kHourInterval;
// TODO: Use actual values in production. // TODO: Remove.
// const NSTimeInterval kRetryAfterSuccess = 24 * kHourInterval; // const NSTimeInterval kRetryAfterSuccess = 0;
const NSTimeInterval kRetryAfterSuccess = 0;
if (lastExportSuccessDate && fabs(lastExportSuccessDate.timeIntervalSinceNow) < kRetryAfterSuccess) { if (lastExportSuccessDate && fabs(lastExportSuccessDate.timeIntervalSinceNow) < kRetryAfterSuccess) {
return NO; return NO;
} }
// Wait N hours before retrying after a failure. // Wait N hours before retrying after a failure.
// const NSTimeInterval kRetryAfterFailure = 6 * kHourInterval;
// TODO: Use actual values in production. // TODO: Remove.
// const NSTimeInterval kRetryAfterFailure = 6 * kHourInterval; // const NSTimeInterval kRetryAfterFailure = 0;
const NSTimeInterval kRetryAfterFailure = 0;
if (lastExportFailureDate && fabs(lastExportFailureDate.timeIntervalSinceNow) < kRetryAfterFailure) { if (lastExportFailureDate && fabs(lastExportFailureDate.timeIntervalSinceNow) < kRetryAfterFailure) {
return NO; return NO;
} }

@ -15,8 +15,7 @@ typedef void (^OWSBackupJobCompletion)(NSError *_Nullable error);
@protocol OWSBackupJobDelegate <NSObject> @protocol OWSBackupJobDelegate <NSObject>
// TODO: This should eventually be the backup key stored in the Signal Service // TODO: Use actual key.
// and retrieved with the backup PIN.
- (nullable NSData *)backupKey; - (nullable NSData *)backupKey;
// Either backupJobDidSucceed:... or backupJobDidFail:... will // Either backupJobDidSucceed:... or backupJobDidFail:... will

Loading…
Cancel
Save