Respond to CR.

pull/1/head
Matthew Chen 8 years ago
parent a5c7bdb987
commit 6831412e44

@ -87,7 +87,7 @@ NS_ASSUME_NONNULL_BEGIN
// Prevent the shape layer from animating changes. // Prevent the shape layer from animating changes.
[CATransaction begin]; [CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions]; [CATransaction setDisableActions:YES];
// Don't fill the shape layer; we just want a stroke around the border. // Don't fill the shape layer; we just want a stroke around the border.
self.shapeLayer.fillColor = [UIColor clearColor].CGColor; self.shapeLayer.fillColor = [UIColor clearColor].CGColor;
@ -114,7 +114,7 @@ NS_ASSUME_NONNULL_BEGIN
// Prevent the shape layer from animating changes. // Prevent the shape layer from animating changes.
[CATransaction begin]; [CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions]; [CATransaction setDisableActions:YES];
self.shapeLayer.strokeColor = self.strokeColor.CGColor; self.shapeLayer.strokeColor = self.strokeColor.CGColor;
self.shapeLayer.lineWidth = self.strokeThickness; self.shapeLayer.lineWidth = self.strokeThickness;

@ -133,7 +133,7 @@ const CGFloat kBubbleTextVInset = 10.f;
// Prevent the shape layer from animating changes. // Prevent the shape layer from animating changes.
[CATransaction begin]; [CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions]; [CATransaction setDisableActions:YES];
self.shapeLayer.fillColor = bubbleColor.CGColor; self.shapeLayer.fillColor = bubbleColor.CGColor;
@ -153,7 +153,7 @@ const CGFloat kBubbleTextVInset = 10.f;
// Prevent the shape layer from animating changes. // Prevent the shape layer from animating changes.
[CATransaction begin]; [CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions]; [CATransaction setDisableActions:YES];
self.shapeLayer.fillColor = self.bubbleColor.CGColor; self.shapeLayer.fillColor = self.bubbleColor.CGColor;
self.shapeLayer.path = bezierPath.CGPath; self.shapeLayer.path = bezierPath.CGPath;

@ -75,7 +75,7 @@ import SignalServiceKit
// Prevent the shape layer from animating changes. // Prevent the shape layer from animating changes.
CATransaction.begin() CATransaction.begin()
CATransaction.setValue(kCFBooleanTrue, forKey: kCATransactionDisableActions) CATransaction.setDisableActions(true)
let horizontalBarPath = UIBezierPath() let horizontalBarPath = UIBezierPath()
let horizontalBarHeightFraction = CGFloat(0.25) let horizontalBarHeightFraction = CGFloat(0.25)

@ -86,7 +86,7 @@ NS_ASSUME_NONNULL_BEGIN
// Prevent the shape layer from animating changes. // Prevent the shape layer from animating changes.
[CATransaction begin]; [CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions]; [CATransaction setDisableActions:YES];
for (ConfigureShapeLayerBlock configureShapeLayerBlock in self.configureShapeLayerBlocks) { for (ConfigureShapeLayerBlock configureShapeLayerBlock in self.configureShapeLayerBlocks) {
CAShapeLayer *shapeLayer = [CAShapeLayer new]; CAShapeLayer *shapeLayer = [CAShapeLayer new];

@ -45,7 +45,7 @@ NS_ASSUME_NONNULL_BEGIN
// Prevent the shape layer from animating changes. // Prevent the shape layer from animating changes.
[CATransaction begin]; [CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions]; [CATransaction setDisableActions:YES];
self.borderLayer = [CAShapeLayer new]; self.borderLayer = [CAShapeLayer new];
self.borderLayer.fillColor = self.color.CGColor; self.borderLayer.fillColor = self.color.CGColor;
@ -87,7 +87,7 @@ NS_ASSUME_NONNULL_BEGIN
{ {
// Prevent the shape layer from animating changes. // Prevent the shape layer from animating changes.
[CATransaction begin]; [CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions]; [CATransaction setDisableActions:YES];
CGFloat kBorderThickness = self.bounds.size.height * 0.1f; CGFloat kBorderThickness = self.bounds.size.height * 0.1f;
CGFloat kOuterRadius = self.bounds.size.height * 0.25f; CGFloat kOuterRadius = self.bounds.size.height * 0.25f;

Loading…
Cancel
Save