Updated the code to use the localised copy for the deprecation UI

Session/Conversations/ConversationVC+Interaction.swift

@@ -2735,8 +2735,8 @@ extension ConversationVC {
         let closedGroupName: String? = self.viewModel.threadData.closedGroupName
         let confirmationModal: ConfirmationModal = ConfirmationModal(
             info: ConfirmationModal.Info(
-                title: "Recreate Group",//.localized(),
+                title: "recreateGroup".localized(),
-                body: .text("Chat history will not be transferred to the new group. You can still view all chat history in your old group."/*.localized()*/),
+                body: .text("legacyGroupChatHistory".localized()),
                 confirmTitle: "theContinue".localized(),
                 confirmStyle: .danger,
                 cancelStyle: .alert_text

Session/Conversations/ConversationViewModel.swift

@@ -69,10 +69,10 @@ public class ConversationViewModel: OWSAudioPlayerDelegate, NavigatableStateHold
         let localizationKey: String
         
         switch (dependencies[feature: .legacyGroupsDeprecated], threadData.currentUserIsClosedGroupAdmin == true) {
-            case (false, false): localizationKey = "groupLegacyBanner"
+            case (false, false): localizationKey = "legacyGroupBeforeDeprecationMember"
-            case (false, true): localizationKey = "groupLegacyBanner"
+            case (false, true): localizationKey = "legacyGroupBeforeDeprecationAdmin"
-            case (true, false): localizationKey = "groupLegacyBanner"
+            case (true, false): localizationKey = "legacyGroupAfterDeprecationMember"
-            case (true, true): localizationKey = "groupLegacyBanner"
+            case (true, true): localizationKey = "legacyGroupAfterDeprecationAdmin"
         }
         
         // FIXME: Strings should be updated in Crowdin to include the {icon}

SessionShareExtension/ThreadPickerVC.swift

@@ -65,7 +65,9 @@ final class ThreadPickerVC: UIViewController, UITableViewDataSource, UITableView
     private lazy var noAccountErrorLabel: UILabel = {
         let result: UILabel = UILabel()
         result.font = .systemFont(ofSize: Values.mediumFontSize)
-        result.text = "Oops! Looks like you don't have a \(Constants.app_name) account yet.\n\nYou'll need to create one in the \(Constants.app_name) app before you can share."//.localized()
+        result.text = "shareExtensionNoAccountError"
+            .put(key: "app_name", value: Constants.app_name)
+            .localized()
         result.textAlignment = .center
         result.themeTextColor = .textPrimary
         result.numberOfLines = 0

SessionUtilitiesKit/Database/Storage.swift

@@ -898,9 +898,6 @@ public extension Publisher where Failure == Error {
 // MARK: - CallInfo
 
 private extension Storage {
-    // MARK: - CallInfo
-
-    private extension Storage {
     class CallInfo {
         enum Behaviour {
             case syncRead
@@ -948,7 +945,6 @@ private extension Storage {
             self.behaviour = behaviour
         }
     }
-    }
 }
 
 // MARK: - TransactionTimer