Simplify the scroll down button layout.

pull/2/head
Matthew Chen 6 years ago
parent 0e87d2e5b3
commit 42871bb6a6

@ -2595,7 +2595,6 @@ typedef enum : NSUInteger {
{ {
CGFloat inset = -(self.collectionView.contentInset.bottom + self.bottomLayoutGuide.length); CGFloat inset = -(self.collectionView.contentInset.bottom + self.bottomLayoutGuide.length);
self.scrollDownButtonButtomConstraint.constant = inset; self.scrollDownButtonButtomConstraint.constant = inset;
[self.scrollDownButton setNeedsLayout];
} }
- (void)setHasUnreadMessages:(BOOL)hasUnreadMessages - (void)setHasUnreadMessages:(BOOL)hasUnreadMessages
@ -3886,15 +3885,7 @@ typedef enum : NSUInteger {
// RADAR: #36297652 // RADAR: #36297652
[self updateScrollDownButtonLayout]; [self updateScrollDownButtonLayout];
// HACK: I've made the assumption that we are already in the context of an animation, in which case the [self.view layoutSubviews];
// above should be sufficient to smoothly move the scrollDown button in step with the keyboard presentation
// animation. Yet, setting the constraint doesn't animate the movement of the button - it "jumps" to it's final
// position. So here we manually lay out the scroll down button frame (seemingly redundantly), which allows it
// to be smoothly animated.
CGRect newButtonFrame = self.scrollDownButton.frame;
newButtonFrame.origin.y = self.scrollDownButton.superview.height
- (newInsets.bottom + self.scrollDownButton.height + self.bottomLayoutGuide.length);
self.scrollDownButton.frame = newButtonFrame;
// Adjust content offset to prevent the presented keyboard from obscuring content. // Adjust content offset to prevent the presented keyboard from obscuring content.
if (!self.viewHasEverAppeared) { if (!self.viewHasEverAppeared) {
@ -5164,6 +5155,7 @@ typedef enum : NSUInteger {
// Scroll button layout depends on input toolbar size. // Scroll button layout depends on input toolbar size.
[self updateScrollDownButtonLayout]; [self updateScrollDownButtonLayout];
[self.view setNeedsLayout];
} }
@end @end

Loading…
Cancel
Save