CR: Don't just build, but present, alert controller

// FREEBIE

Signal/src/ViewControllers/ContactsViewHelper.h

@@ -46,9 +46,9 @@ NS_ASSUME_NONNULL_BEGIN
 
 @property (nonatomic, readonly) NSArray<NSString *> *blockedPhoneNumbers;
 
-// Suitable to display when the user tries to perform an action which is not possible due to the user having
+// Suitable when the user tries to perform an action which is not possible due to the user having
 // previously denied contact access.
-@property (nonatomic, readonly) UIAlertController *missingContactAccessAlertController;
+- (void)presentMissingContactAccessAlertControllerFromViewController:(UIViewController *)viewController;
 
 - (instancetype)init NS_UNAVAILABLE;
 

Signal/src/ViewControllers/ContactsViewHelper.m

@@ -297,7 +297,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 #pragma mark - Editing
 
-- (UIAlertController *)missingContactAccessAlertController
+- (void)presentMissingContactAccessAlertControllerFromViewController:(UIViewController *)viewController
 {
     UIAlertController *alertController = [UIAlertController
         alertControllerWithTitle:NSLocalizedString(@"EDIT_CONTACT_WITHOUT_CONTACTS_PERMISSION_ALERT_TITLE", comment
@@ -323,7 +323,7 @@ NS_ASSUME_NONNULL_BEGIN
                                                           [[UIApplication sharedApplication] openSystemSettings];
                                                       }]];
 
-    return alertController;
+    [viewController presentViewController:alertController animated:YES completion:nil];
 }
 
 - (void)presentContactViewControllerForRecipientId:(NSString *)recipientId
@@ -351,7 +351,7 @@ NS_ASSUME_NONNULL_BEGIN
     }
 
     if (!self.contactsManager.isSystemContactsAuthorized) {
-        [fromViewController presentViewController:self.missingContactAccessAlertController animated:YES completion:nil];
+        [self presentMissingContactAccessAlertControllerFromViewController:fromViewController];
         return;
     }
 

Signal/src/ViewControllers/OWSConversationSettingsTableViewController.m

@@ -770,9 +770,7 @@ NS_ASSUME_NONNULL_BEGIN
     }
 
     if (!self.contactsManager.isSystemContactsAuthorized) {
-        [self presentViewController:self.contactsViewHelper.missingContactAccessAlertController
+        [self.contactsViewHelper presentMissingContactAccessAlertControllerFromViewController:self];
-                           animated:YES
-                         completion:nil];
         return;
     }