Respond to CR.

// FREEBIE
pull/1/head
Matthew Chen 9 years ago
parent 0018d0040b
commit 193d9421ce

@ -2182,8 +2182,8 @@ typedef enum : NSUInteger {
NSURL *referenceURL = [info valueForKey:UIImagePickerControllerReferenceURL]; NSURL *referenceURL = [info valueForKey:UIImagePickerControllerReferenceURL];
if (!referenceURL) { if (!referenceURL) {
DDLogError(@"Could not retrieve reference URL for picked asset"); DDLogVerbose(@"Could not retrieve reference URL for picked asset");
OWSAssert(0); [self imagePickerController:picker didFinishPickingMediaWithInfo:info filename:nil];
return; return;
} }
@ -2357,24 +2357,25 @@ typedef enum : NSUInteger {
exportSession.outputURL = compressedVideoUrl; exportSession.outputURL = compressedVideoUrl;
[exportSession exportAsynchronouslyWithCompletionHandler:^{ [exportSession exportAsynchronouslyWithCompletionHandler:^{
NSData *videoData = [NSData dataWithContentsOfURL:compressedVideoUrl]; NSData *videoData = [NSData dataWithContentsOfURL:compressedVideoUrl];
SignalAttachment *attachment = dispatch_async(dispatch_get_main_queue(), ^{
[SignalAttachment videoAttachmentWithData:videoData dataUTI:(NSString *)kUTTypeMPEG4 filename:filename]; SignalAttachment *attachment =
if (!attachment || [SignalAttachment videoAttachmentWithData:videoData dataUTI:(NSString *)kUTTypeMPEG4 filename:filename];
[attachment hasError]) { if (!attachment || [attachment hasError]) {
DDLogWarn(@"%@ %s Invalid attachment: %@.", DDLogWarn(@"%@ %s Invalid attachment: %@.",
self.tag, self.tag,
__PRETTY_FUNCTION__, __PRETTY_FUNCTION__,
attachment ? [attachment errorName] : @"Missing data"); attachment ? [attachment errorName] : @"Missing data");
[self showErrorAlertForAttachment:attachment]; [self showErrorAlertForAttachment:attachment];
} else { } else {
[self tryToSendAttachmentIfApproved:attachment]; [self tryToSendAttachmentIfApproved:attachment];
} }
NSError *error; NSError *error;
[[NSFileManager defaultManager] removeItemAtURL:compressedVideoUrl error:&error]; [[NSFileManager defaultManager] removeItemAtURL:compressedVideoUrl error:&error];
if (error) { if (error) {
DDLogWarn(@"Failed to remove cached video file: %@", error.debugDescription); DDLogWarn(@"Failed to remove cached video file: %@", error.debugDescription);
} }
});
}]; }];
} }

@ -317,6 +317,7 @@ static NSString *const kUnwindToMessagesViewSegue = @"UnwindToMessagesViewSegue"
if (model.groupImage) { if (model.groupImage) {
[self.messageSender sendAttachmentData:UIImagePNGRepresentation(model.groupImage) [self.messageSender sendAttachmentData:UIImagePNGRepresentation(model.groupImage)
contentType:OWSMimeTypeImagePng contentType:OWSMimeTypeImagePng
filename:nil
inMessage:message inMessage:message
success:popToThread success:popToThread
failure:removeThreadWithError]; failure:removeThreadWithError];

@ -302,7 +302,7 @@ class SignalAttachment: NSObject {
assertionFailure() assertionFailure()
return nil return nil
} }
return genericAttachment(data : data, dataUTI : dataUTI) return genericAttachment(data : data, dataUTI : dataUTI, filename: nil)
} }
// This method should only be called for dataUTIs that // This method should only be called for dataUTIs that

Loading…
Cancel
Save