Only show contact nag if we've denied contact access

// FREEBIE

Signal/src/ViewControllers/HomeViewController.m

@@ -550,7 +550,7 @@ typedef NS_ENUM(NSInteger, CellState) { kArchiveState, kInboxState };
 
 - (BOOL)shouldShowMissingContactsPermissionView
 {
-    if ([TSContactThread numberOfKeysInCollection] == 0) {
+    if (!self.contactsManager.systemContactsHaveBeenRequestedAtLeastOnce) {
         return NO;
     }
 

Signal/src/contact/OWSContactsManager.h

@@ -61,6 +61,7 @@ extern NSString *const OWSContactsManagerSignalAccountsDidChangeNotification;
 
 // Must call `requestSystemContactsOnce` before accessing this method
 @property (nonatomic, readonly) BOOL isSystemContactsAuthorized;
+@property (nonatomic, readonly) BOOL systemContactsHaveBeenRequestedAtLeastOnce;
 
 @property (nonatomic, readonly) BOOL supportsContactEditing;
 

Signal/src/contact/OWSContactsManager.m

@@ -108,6 +108,11 @@ NSString *const kTSStorageManager_lastKnownContactRecipientIds = @"lastKnownCont
     return self.systemContactsFetcher.isAuthorized;
 }
 
+- (BOOL)systemContactsHaveBeenRequestedAtLeastOnce
+{
+    return self.systemContactsFetcher.systemContactsHaveBeenRequestedAtLeastOnce;
+}
+
 - (BOOL)supportsContactEditing
 {
     return self.systemContactsFetcher.supportsContactEditing;

Signal/src/contact/SystemContactsFetcher.swift

@@ -342,7 +342,7 @@ class SystemContactsFetcher: NSObject {
         return self.authorizationStatus == .authorized
     }
 
-    private var systemContactsHaveBeenRequestedAtLeastOnce = false
+    private(set) var systemContactsHaveBeenRequestedAtLeastOnce = false
     private var hasSetupObservation = false
 
     override init() {