Commit Graph

3441 Commits (0c06fff47b7bbefc4169767ddcf0fff83d3b5daa)
 

Author SHA1 Message Date
Daniel Gasienica 0c06fff47b Wire up `Message` / `Attachment` migration functions on startup
Makes `migrationContext` obsolete.
7 years ago
Daniel Gasienica 867f73b80a Use double quotes for identifiers in error messages 7 years ago
Daniel Gasienica 06e7bca276 Use new `stringToArrayBuffer` function 7 years ago
Daniel Gasienica 70cdd2b350 Add `stringToArrayBuffer` utility
This way we can avoid an extra dependency.
7 years ago
Daniel Gasienica 232e906650 Remove `tmp` as dev dependency 7 years ago
Daniel Gasienica 2ad0fd7db6 Use Lodash `omit` instead of `delete` 7 years ago
Daniel Gasienica ef2be2cf5f Make `MessageView::onUnload` synchronous
Our tests rely on that.
7 years ago
Daniel Gasienica add5d4ab0b Prevent macOS Spotlight indexing of attachments folder
See: https://apple.stackexchange.com/a/92785
7 years ago
Daniel Gasienica b3251a8de2 Prevent potential NPE 7 years ago
Daniel Gasienica 9d25aa4e43 Delete attachment files on disk upon message delete 7 years ago
Daniel Gasienica 279b3f81c7 Add `Attachment.deleteData` 7 years ago
Daniel Gasienica 10afcf1bb0 Add `Attachments.deleteData` 7 years ago
Daniel Gasienica 9b636a1885 Add test for `Attachments.readData` 7 years ago
Daniel Gasienica f6f0359a61 Use `assert.deepEqual` instead of Lodash `isEqual` 7 years ago
Daniel Gasienica 833a203559 Remove Vim modeline 7 years ago
Daniel Gasienica aba261122f 🎨 Use `camelCase` for mutable variable 7 years ago
Daniel Gasienica e1c1b1aa72 Load attachment data before rendering
Prevent double rendering of attachments by multiple entries into
`MessageView::render` using promises.
7 years ago
Daniel Gasienica 97e3b49a36 Whitelist `js/views/message_view.js` for ESLint 7 years ago
Daniel Gasienica b5721c2594 Remove Vim modeline 7 years ago
Daniel Gasienica f031ac3126 Remove duplicate ESLint ignore entry 7 years ago
Daniel Gasienica 38e2468b2e Set `schemaVersion` in `handleMessage` 7 years ago
Daniel Gasienica e3dbeba963 Initialize schema version during `Message` construction 7 years ago
Daniel Gasienica 9a540d6d18 Load attachment data before sending message 7 years ago
Daniel Gasienica 1c8123ff1a Move `writeAttachmentData` into `Attachments`
Encapsulates all attachment operations that require Node.js / Electron APIs,
e.g. file system access.
7 years ago
Daniel Gasienica 19a70ad8b8 Add `to-arraybuffer` dependency
Used for converting Node.js buffers to `ArrayBuffer`.
7 years ago
Daniel Gasienica 32911002d4 Verify `makeAttachmentPointer` and `encryptAttachment` arguments
The underlying `crypto.subtle.encrypt` API requires it.
7 years ago
Daniel Gasienica 8218e308cd Improve identifier names 7 years ago
Daniel Gasienica 6355c54114 Return relative path from `writeAttachmentData`
This will make our app more robust to changes in location on the file system.
7 years ago
Daniel Gasienica 1262d1d696 Shorten prefix to 2 characters
Using 2 hex characters [0-9a-f] will give us 16 * 16 = 256 root folders which
seems more manageable than 4096 (16^3). Assuming a user has 10,000 attachments,
they should roughly distribute at ~40 per folder with prefix length 2 rather
than ~2.5 per folder with a prefix of 3.
7 years ago
Daniel Gasienica 2cd3d5ac16 Add `Message` schema version 3 7 years ago
Daniel Gasienica e0428355be Wire up `writeAttachment` 7 years ago
Daniel Gasienica aa82a2a5fb Add `context` to `Message.upgradeSchema`
Allows us to pass in Electron/Node.js specific functions. This allows better
unit testing in Mocha where we don’t have access to Electron APIs.
7 years ago
Daniel Gasienica ebe2a769c9 Add `Attachment.migrateDataToFileSystem` 7 years ago
Daniel Gasienica 0fc2868f0e Remove `tempy` dependency
We already use `tmp`.
7 years ago
Daniel Gasienica 8a94ca5c42 🎨 Use `Buffer.from` 7 years ago
Daniel Gasienica 1283c77518 Switch from hashed to random attachment file names
Using hashes, we get the benefit of deduplication but if a user receives two
messages with the same attachment, deleting one would delete it for both since
they are only stored once. To avoid the complexity of tracking number of
references, we simply generate random file names similar to iMessage on MacOS
(?) and Signal Android.
7 years ago
Daniel Gasienica d9de6dacba Add `writeAttachmentData` module 7 years ago
Daniel Gasienica 14f58281bc Add `string-to-array-buffer` as dev dependency
Used for testing attachment data migration.
7 years ago
Daniel Gasienica 925ddbd7db Add `tempy` as dev dependency
Useful for creating random temporary directories for testing.
7 years ago
Daniel Gasienica 14422652c6 Add `fs-extra` as direct dependency
Allows us to use `fs` with promises. Turns out it’s already a
transitive dependency.
7 years ago
Navdeep Singh 1a117e3f78 Fix #2125 Prevent multiple settings modals 7 years ago
Vincent d520ba3b38 Mention correct branch to rebase off of 7 years ago
Vincent 5b5903c70e Fix link to Signal update location
Fixes #2043.
7 years ago
Vincent e0d0aa520e Fix typo contribution guide 7 years ago
Daniel Gasienica 79d9f36070
Request translation changes via Transifex (#2157)
Some of our users submit direct PRs against our translations. This update to our PR template is meant to encourage them to contribute translations via Transifex.

Prompted by this user PR: https://github.com/signalapp/Signal-Desktop/pull/2156
7 years ago
Daniel Gasienica 7d264354be Request translation changes to be made via Transifex 7 years ago
Scott Nonnenberg 0d105fc190
1.7.0-beta.2
Fixed: White block at bottom of conversation panel in iOS theme
(#2144 and #2153)

Fixed: Would attempt to rotate signed prekey every five seconds,
forever, after app discovers it is unlinked
(1c6d91b59c)

Dev:
  - Introduce IndexedDB index on `messages` store tracking
    `schemaVersion` (#2128)
  - Preparation for encrypted backups
    (cea42bde7d)
  - Updates to structure of exported data - messages.zip, flat list of
    attachments (6d8f4b7b6e)
7 years ago
Scott Nonnenberg cea42bde7d
Encryption support for backup and restore
Also moved to the _ prefix in backup.js for all private methods exported
for testing.
7 years ago
Scott Nonnenberg 6d8f4b7b6e
Backup: zipped messages.json, flat attachments dir
Backup creates, in a target directory:
  - An attachments folder, with all attachments, each named for their
    parent message's id - a GUID. If there is more than one attachment
    in a given message,  each attachment beyond the first will end with
    '-N', zero-indexed.
  - A file named messages.zip. It contains exactly what went to disk in
    the original export code, but zipped up.

Export is now only 'light,' and in this new messages.zip format.

Import supports both the new format and the old format. If the target
directory has a messages.zip file, we'll treat it as the new format.

Next up: Encrypting attachments and the messages.zip!
7 years ago
Scott Nonnenberg 1c6d91b59c
Harden rotateSignedPrekey against nonexistent identity key
This is now what happens after Signal Desktop discovers that it is no
longer linked with a mobile device, since the identityh key is deleted.
7 years ago