move the emptyContentEditable hack to componentWillUnmount

pull/712/head
Audric Ackermann 5 years ago
parent 98be71680d
commit f613f27ee3

@ -549,8 +549,6 @@ export class RegistrationTabs extends React.Component<{}, State> {
displayName: '', displayName: '',
signUpMode: SignUpMode.Default, signUpMode: SignUpMode.Default,
}); });
//FIXME ugly hack to empty the content editable div used on enter session ID
window.Session.emptyContentEditableDivs();
}} }}
buttonType={buttonType} buttonType={buttonType}
buttonColor={buttonColor} buttonColor={buttonColor}

@ -1,29 +1,31 @@
import React from 'react'; import React from 'react';
interface Props { interface Props {
placeholder: string; placeholder: string;
editable?: boolean; editable?: boolean;
onChange?: any; onChange?: any;
} }
export class SessionIdEditable extends React.PureComponent<Props> { export class SessionIdEditable extends React.PureComponent<Props> {
public componentWillUnmount() {
//FIXME ugly hack to empty the content editable div used on enter session ID
window.Session.emptyContentEditableDivs();
}
public render() { public render() {
const { placeholder, editable, onChange } = this.props; const { placeholder, editable, onChange } = this.props;
return ( return (
<div <div
className="session-id-editable" className="session-id-editable"
placeholder={placeholder} placeholder={placeholder}
contentEditable={editable} contentEditable={editable}
onInput={(e: any) => { onInput={(e: any) => {
if (editable) { if (editable) {
onChange(e); onChange(e);
} }
}} }}
/> />
); );
} }
} }

Loading…
Cancel
Save