move the emptyContentEditable hack to componentWillUnmount

pull/712/head
Audric Ackermann 5 years ago
parent 98be71680d
commit f613f27ee3

@ -549,8 +549,6 @@ export class RegistrationTabs extends React.Component<{}, State> {
displayName: '',
signUpMode: SignUpMode.Default,
});
//FIXME ugly hack to empty the content editable div used on enter session ID
window.Session.emptyContentEditableDivs();
}}
buttonType={buttonType}
buttonColor={buttonColor}

@ -1,29 +1,31 @@
import React from 'react';
interface Props {
placeholder: string;
editable?: boolean;
onChange?: any;
placeholder: string;
editable?: boolean;
onChange?: any;
}
export class SessionIdEditable extends React.PureComponent<Props> {
public componentWillUnmount() {
//FIXME ugly hack to empty the content editable div used on enter session ID
window.Session.emptyContentEditableDivs();
}
public render() {
const { placeholder, editable, onChange } = this.props;
public render() {
const { placeholder, editable, onChange } = this.props;
return (
<div
className="session-id-editable"
placeholder={placeholder}
contentEditable={editable}
onInput={(e: any) => {
if (editable) {
onChange(e);
}
}}
/>
);
}
return (
<div
className="session-id-editable"
placeholder={placeholder}
contentEditable={editable}
onInput={(e: any) => {
if (editable) {
onChange(e);
}
}}
/>
);
}
}

Loading…
Cancel
Save