Added blocking/unblocking from friend request.

Fixed incoming messages being deleted.

app/sql.js

@@ -1302,7 +1302,9 @@ async function getMessageBySender({ source, sourceDevice, sent_at }) {
 
 async function getAllUnsentMessages() {
   const rows = await db.all(`
-    SELECT json FROM messages WHERE NOT sent
+    SELECT json FROM messages WHERE
+      type IN ('outgoing', 'friend-request') AND
+      NOT sent
     ORDER BY sent_at DESC;
   `);
   return map(rows, row => jsonToObject(row.json));

js/background.js

@@ -338,6 +338,11 @@
           'expirationStartTimestamp'
         );
 
+        // Make sure we only target outgoing messages
+        if (message.isFriendRequest() && message.get('direction') === 'incoming') {
+          return;
+        }
+
         if (message.hasErrors()) {
           return;
         }

js/blocked_number_controller.js

@@ -63,10 +63,16 @@
 
         return null;
       },
+      unblockAll() {
+        const all = blockedNumbers.models;
+        all.forEach(number => {
+          storage.removeBlockedNumber(number);
+          blockedNumbers.remove(number);
+        })
+      },
       isBlocked(number) {
         return storage.isBlocked(number);
       },
-
     };
   })();
   

js/models/messages.js

@@ -331,15 +331,27 @@
         window.Whisper.events.trigger('deleteConversation', conversation);
       };
 
+      const onBlockUser = () => {
+        conversation.block();
+        this.trigger('change');
+      };
+
+      const onUnblockUser = () => {
+        conversation.unblock();
+        this.trigger('change');
+      };
+
       return {
         text: this.createNonBreakingLastSeparator(this.get('body')),
         status: this.getMessagePropStatus(),
         direction,
         friendStatus,
+        isBlocked: conversation.isBlocked(),
         onAccept,
         onDecline,
         onDeleteConversation,
-        onRetrySend: () => this.retrySend(),
+        onBlockUser,
+        onUnblockUser,
       }
     },
     findContact(phoneNumber) {

js/views/settings_view.js

@@ -150,6 +150,7 @@
         mediaPermissionsDescription: i18n('mediaPermissionsDescription'),
         spellCheckHeader: i18n('spellCheck'),
         spellCheckDescription: i18n('spellCheckDescription'),
+        blockedHeader: 'Blocked Users',
       };
     },
     onClose() {

settings.html

@@ -109,6 +109,10 @@
         <p>{{ clearDataExplanation }}</p>
       </div>
     </div>
+    <hr>
+    <div class='blocked-user-setting'>
+      <h3>{{ blockedHeader }}</h3>
+    </div>
   </div>
 </script>
 <script type='text/javascript' src='js/components.js'></script>

ts/components/conversation/FriendRequest.tsx

@@ -10,10 +10,13 @@ interface Props {
   status: string;
   friendStatus: 'pending' | 'accepted' | 'declined';
   i18n: Localizer;
+  isBlocked: boolean;
   onAccept: () => void;
   onDecline: () => void;
   onDeleteConversation: () => void;
   onRetrySend: () => void;
+  onBlockUser: () => void;
+  onUnblockUser: () => void;
 }
 
 export class FriendRequest extends React.Component<Props> {
@@ -50,7 +53,7 @@ export class FriendRequest extends React.Component<Props> {
   }
 
   public renderButtons() {
-      const { friendStatus, direction, status, onAccept, onDecline, onDeleteConversation, onRetrySend } = this.props;
+      const { i18n, friendStatus, direction, status, onAccept, onDecline, onDeleteConversation, onRetrySend, isBlocked, onBlockUser, onUnblockUser } = this.props;
 
       if (direction === 'incoming') {
         if (friendStatus === 'pending') {
@@ -67,6 +70,8 @@ export class FriendRequest extends React.Component<Props> {
               </div>
           );
         } else if (friendStatus === 'declined') {
+          const blockTitle = isBlocked ? i18n('unblockUser') : i18n('blockUser');
+          const blockHandler = isBlocked ? onUnblockUser : onBlockUser;
           return (
             <div
               className={classNames(
@@ -76,6 +81,7 @@ export class FriendRequest extends React.Component<Props> {
               )}
             >
               <button onClick={onDeleteConversation}>Delete Conversation</button>
+              <button onClick={blockHandler}>{blockTitle}</button>
             </div>
           );
         }