fix: more comment cleanup

pull/2971/head
William Grant 2 years ago
parent 1d7380a254
commit a459bff86c

@ -1022,9 +1022,6 @@ export class MessageModel extends Backbone.Model<MessageAttributes> {
throw new Error('Cannot trigger syncMessage with unknown convo.');
}
// window.log.debug(
// `WIP: sendSyncMessage: running checkForExpireUpdateInContentMessage for ${this.id}`
// );
const expireUpdate = await checkForExpireUpdateInContentMessage(content, conversation, true);
const syncMessage = buildSyncMessage(

@ -80,7 +80,7 @@ function getSharedAttributesForPublicMessage({
isPublic: true,
conversationId,
messageHash: '', // we do not care of a messageHash for an opengroup message. we have serverId for that
// Note Community messages do not have an expiration
// NOTE Community messages do support disappearing messages
expirationStartTimestamp: undefined,
};
}

@ -136,10 +136,10 @@ export enum MessageDirection {
any = '%',
}
export interface PropsForDataExtractionNotification extends DataExtractionNotificationMsg {
export type PropsForDataExtractionNotification = DataExtractionNotificationMsg & {
name: string;
messageId: string;
}
};
export type PropsForMessageRequestResponse = MessageRequestResponseMsg & {
conversationId?: string;

@ -1,14 +1,12 @@
/* eslint-disable max-len */
/*
When doing migrations that related to libsession we cannot share useful functions between migrations because the typings for libsession can change between versions.
When doing migrations that relate to libsession we cannot share useful functions between migrations because the typings for libsession can change between versions.
To fix this, we now put these "helper" functions in a migration number specific file that can be trusted to have the correct typings and values for that version of libsession.
In order for this to work, any properties on an object type exported from libsession need to be optional. This is because we cannot guarantee that the value will exist on the object in the version of libsession that we are migrating from.
Any helper functions that are exported from a helper file must have run checkTargetMigration(version, targetVersion); on the first line to confirm that the helper function is being reference within the correct migration. It will throw an error otherwise.
Any helper functions that are exported from a helper file must run checkTargetMigration(version, targetVersion); on the first line to confirm that the helper function is being referenced within the correct migration. It will throw an error otherwise.
*/
/* eslint-enable max-len */

Loading…
Cancel
Save