@ -1,8 +1,7 @@
/* global _: false */ /* global _: false */
/* global Backbone: false */ /* global Backbone: false */
/* global BlockedNumberController: false */
/* global ConversationController: false */ /* global ConversationController: false */
/* global i18n: false */
/* global libsignal: false */ /* global libsignal: false */
/* global storage: false */ /* global storage: false */
/* global textsecure: false */ /* global textsecure: false */
@ -11,7 +10,7 @@
/* eslint-disable more/no-then */ /* eslint-disable more/no-then */
// eslint-disable-next-line func-names
// eslint-disable-next-line func-names
( function ( ) { ( function ( ) {
'use strict' ;
'use strict' ;
window . Whisper = window . Whisper || { } ;
window . Whisper = window . Whisper || { } ;
@ -251,7 +250,7 @@
}
}
} ,
} ,
// This goes through all our message history and finds a friend request
// This goes through all our message history and finds a friend request
// But this is not a concurrent operation and thus ` updatePendingFriendRequests` is used
// But this is not a concurrent operation and thus updatePendingFriendRequests is used
async hasPendingFriendRequests ( ) {
async hasPendingFriendRequests ( ) {
// Go through the messages and check for any pending friend requests
// Go through the messages and check for any pending friend requests
const messages = await window . Signal . Data . getMessagesByConversation (
const messages = await window . Signal . Data . getMessagesByConversation (
@ -261,27 +260,29 @@
MessageCollection : Whisper . MessageCollection ,
MessageCollection : Whisper . MessageCollection ,
}
}
) ;
) ;
const pendingFriendRequest =
for ( const message of messages . models ) {
messages . models . find ( message =>
if ( message . isFriendRequest ( ) && message . attributes . friendStatus === 'pending' ) return true ;
message . isFriendRequest ( ) &&
}
message . attributes . friendStatus === 'pending'
) ;
return false ;
return pendingFriendRequest !== undefined ;
} ,
} ,
async getPendingFriendRequests ( direction ) {
async getPendingFriendRequests ( direction ) {
// Theoretically all ouur messages could be friend requests, thus we have to unfortunately go through each one :(
// Theoretically all our messages could be friend requests,
// thus we have to unfortunately go through each one :(
const messages = await window . Signal . Data . getMessagesByConversation (
const messages = await window . Signal . Data . getMessagesByConversation (
this . id ,
this . id ,
{
{
type : 'friend-request' ,
type : 'friend-request' ,
MessageCollection : Whisper . MessageCollection ,
MessageCollection : Whisper . MessageCollection ,
}
}
) ;
) ;
// Get the messages that are matching the direction and the friendStatus
// Get the messages that are matching the direction and the friendStatus
return messages . models . filter ( m => {
return messages . models . filter ( m =>
return ( m . attributes . direction === direction && m . attributes . friendStatus === 'pending' )
m . attributes . direction === direction &&
} ) ;
m . attributes . friendStatus === 'pending'
) ;
} ,
} ,
getPropsForListItem ( ) {
getPropsForListItem ( ) {
const result = {
const result = {
@ -364,7 +365,7 @@
if ( ! this . isPrivate ( ) ) {
if ( ! this . isPrivate ( ) ) {
throw new Error (
throw new Error (
'You cannot verify a group conversation. ' +
'You cannot verify a group conversation. ' +
'You must verify individual contacts.'
'You must verify individual contacts.'
) ;
) ;
}
}
@ -482,7 +483,9 @@
} ,
} ,
async onFriendRequestAccepted ( { updateUnread } ) {
async onFriendRequestAccepted ( { updateUnread } ) {
// Make sure we don't keep incrementing the unread count
// Make sure we don't keep incrementing the unread count
const unreadCount = this . isKeyExchangeCompleted ( ) || ! updateUnread ? { } : { unreadCount : this . get ( 'unreadCount' ) + 1 } ;
const unreadCount = ! updateUnread || this . isKeyExchangeCompleted ( )
? { }
: { unreadCount : this . get ( 'unreadCount' ) + 1 } ;
this . set ( {
this . set ( {
friendRequestStatus : null ,
friendRequestStatus : null ,
keyExchangeCompleted : true ,
keyExchangeCompleted : true ,
@ -541,7 +544,7 @@
friendRequestStatus . allowSending = false ;
friendRequestStatus . allowSending = false ;
const delayMs = 60 * 60 * 1000 * friendRequestLockDuration ;
const delayMs = 60 * 60 * 1000 * friendRequestLockDuration ;
friendRequestStatus . unlockTimestamp = Date . now ( ) + delayMs ;
friendRequestStatus . unlockTimestamp = Date . now ( ) + delayMs ;
// Update the text input state
// Update the text input state
this . updateTextInputState ( ) ;
this . updateTextInputState ( ) ;
@ -593,7 +596,7 @@
if ( ! this . isPrivate ( ) ) {
if ( ! this . isPrivate ( ) ) {
throw new Error (
throw new Error (
'You cannot set a group conversation as trusted. ' +
'You cannot set a group conversation as trusted. ' +
'You must set individual contacts as trusted.'
'You must set individual contacts as trusted.'
) ;
) ;
}
}
@ -751,17 +754,16 @@
// This is to ensure that one user cannot spam us with multiple friend requests
// This is to ensure that one user cannot spam us with multiple friend requests
if ( _options . direction === 'incoming' ) {
if ( _options . direction === 'incoming' ) {
const requests = await this . getPendingFriendRequests ( 'incoming' ) ;
const requests = await this . getPendingFriendRequests ( 'incoming' ) ;
for ( const request of requests ) {
// Delete the old message if it's pending
// Delete the old message if it's pending
await Promise . all ( requests . map ( request => this . _removeMessage ( request . id ) ) ) ;
await this . _removeMessage ( request . id ) ;
}
// Trigger an update if we removed messages
// Trigger an update if we removed messages
if ( requests . length > 0 )
if ( requests . length > 0 )
this . trigger ( 'change' ) ;
this . trigger ( 'change' ) ;
}
}
// Add the new message
// Add the new message
// eslint-disable-next-line camelcase
const received _at = _options . received _at || Date . now ( ) ;
const received _at = _options . received _at || Date . now ( ) ;
const message = {
const message = {
conversationId : this . id ,
conversationId : this . id ,
@ -783,11 +785,11 @@
Message : Whisper . Message ,
Message : Whisper . Message ,
} ) ;
} ) ;
const whisperMessage = new Whisper . Message ( {
const whisperMessage = new Whisper . Message ( {
... message ,
... message ,
id ,
id ,
} ) ;
} ) ;
this . trigger ( 'newmessage' , whisperMessage ) ;
this . trigger ( 'newmessage' , whisperMessage ) ;
this . notify ( whisperMessage ) ;
this . notify ( whisperMessage ) ;
} ,
} ,
@ -991,9 +993,9 @@
fileName : fileName || null ,
fileName : fileName || null ,
thumbnail : thumbnail
thumbnail : thumbnail
? {
? {
... ( await loadAttachmentData ( thumbnail ) ) ,
... ( await loadAttachmentData ( thumbnail ) ) ,
objectUrl : getAbsoluteAttachmentPath ( thumbnail . path ) ,
objectUrl : getAbsoluteAttachmentPath ( thumbnail . path ) ,
}
}
: null ,
: null ,
} ;
} ;
} )
} )
@ -1020,7 +1022,7 @@
'with timestamp' ,
'with timestamp' ,
now
now
) ;
) ;
let messageWithSchema = null ;
let messageWithSchema = null ;
// If we have exchanged keys then let the user send the message normally
// If we have exchanged keys then let the user send the message normally
@ -1037,26 +1039,31 @@
recipients ,
recipients ,
} ) ;
} ) ;
} else {
} else {
// We also need to make sure we don't send a new friend request if we already have an existing one
// We also need to make sure we don't send a new friend request
const incomingRequests = await this . getPendingFriendRequests ( 'incoming' ) ;
// if we already have an existing one
if ( incomingRequests . length > 0 ) return ;
const incomingRequests = await this . getPendingFriendRequests ( 'incoming' ) ;
if ( incomingRequests . length > 0 ) return null ;
// Otherwise check if we have sent a friend request
// Otherwise check if we have sent a friend request
const outgoingRequests = await this . getPendingFriendRequests ( 'outgoing' ) ;
const outgoingRequests = await this . getPendingFriendRequests ( 'outgoing' ) ;
if ( outgoingRequests . length > 0 ) {
if ( outgoingRequests . length > 0 ) {
// Check if the requests have errored, if so then remove them and send the new request if possible
// Check if the requests have errored, if so then remove them
const friendRequestSent = false ;
// and send the new request if possible
for ( const outgoing of outgoingRequests ) {
let friendRequestSent = false ;
const promises = [ ] ;
outgoingRequests . forEach ( outgoing => {
if ( outgoing . hasErrors ( ) ) {
if ( outgoing . hasErrors ( ) ) {
await this . _removeMessage ( outgoing . id ) ;
promises . push ( this . _removeMessage ( outgoing . id ) ) ;
} else {
} else {
// No errors = we have sent over the friend request
// No errors = we have sent over the friend request
friendRequestSent = true ;
friendRequestSent = true ;
}
}
}
} ) ;
await Promise . all ( promises ) ;
// If the requests didn't error then don't add a new friend request because one of them was sent successfully
// If the requests didn't error then don't add a new friend request
if ( friendRequestSent ) return ;
// because one of them was sent successfully
if ( friendRequestSent ) return null ;
}
}
// Send the friend request!
// Send the friend request!
@ -1127,8 +1134,8 @@
const options = this . getSendOptions ( ) ;
const options = this . getSendOptions ( ) ;
// Add the message sending on another queue so that our UI doesn't get blocked
// Add the message sending on another queue so that our UI doesn't get blocked
this . queueMessageSend ( async ( ) => {
this . queueMessageSend ( async ( ) =>
return message . send (
message . send (
this . wrapSend (
this . wrapSend (
sendFunction (
sendFunction (
destination ,
destination ,
@ -1141,8 +1148,8 @@
options
options
)
)
)
)
) ;
)
} );
;
return true ;
return true ;
} ) ;
} ) ;
@ -1161,12 +1168,11 @@
this . trigger ( 'disable:input' , true ) ;
this . trigger ( 'disable:input' , true ) ;
this . trigger ( 'change:placeholder' , 'disabled' ) ;
this . trigger ( 'change:placeholder' , 'disabled' ) ;
return ;
return ;
} else {
// Tell the user to introduce themselves
this . trigger ( 'disable:input' , false ) ;
this . trigger ( 'change:placeholder' , 'friend-request' ) ;
return ;
}
}
// Tell the user to introduce themselves
this . trigger ( 'disable:input' , false ) ;
this . trigger ( 'change:placeholder' , 'friend-request' ) ;
return ;
}
}
this . trigger ( 'disable:input' , false ) ;
this . trigger ( 'disable:input' , false ) ;
this . trigger ( 'change:placeholder' , 'chat' ) ;
this . trigger ( 'change:placeholder' , 'chat' ) ;
@ -1316,8 +1322,8 @@
accessKey && sealedSender === SEALED _SENDER . ENABLED
accessKey && sealedSender === SEALED _SENDER . ENABLED
? accessKey
? accessKey
: window . Signal . Crypto . arrayBufferToBase64 (
: window . Signal . Crypto . arrayBufferToBase64 (
window . Signal . Crypto . getRandomBytes ( 16 )
window . Signal . Crypto . getRandomBytes ( 16 )
) ,
) ,
} ,
} ,
} ;
} ;
} ,
} ,
@ -1596,7 +1602,7 @@
} else {
} else {
window . log . warn (
window . log . warn (
'Marked a message as read in the database, but ' +
'Marked a message as read in the database, but ' +
'it was not in messageCollection.'
'it was not in messageCollection.'
) ;
) ;
}
}
@ -2117,8 +2123,10 @@
// Notification for friend request received
// Notification for friend request received
async notifyFriendRequest ( source , type ) {
async notifyFriendRequest ( source , type ) {
// Data validation
// Data validation
if ( ! source ) return Promise . reject ( 'Invalid source' ) ;
if ( ! source )
if ( ! [ 'accepted' , 'requested' ] . includes ( type ) ) return Promise . reject ( 'Type must be accepted or requested.' ) ;
throw new Error ( 'Invalid source' ) ;
if ( ! [ 'accepted' , 'requested' ] . includes ( type ) )
throw new Error ( 'Type must be accepted or requested.' ) ;
// Call the notification on the right conversation
// Call the notification on the right conversation
let conversation = this ;
let conversation = this ;
@ -2128,29 +2136,33 @@
source ,
source ,
'private'
'private'
) ;
) ;
window . log . info ( ` Notify called on a different conversation. expected: ${ this . id } . actual: ${ conversation . id } ` ) ;
window . log . info ( ` Notify called on a different conversation.
Expected : $ { this . id } . Actual : $ { conversation . id } ` );
} catch ( e ) {
} catch ( e ) {
return Promise . reject ( 'Failed to fetch conversation ') ;
throw new Error ( 'Failed to fetch conversation. ') ;
}
}
}
}
const isTypeAccepted = type === 'accepted' ;
const isTypeAccepted = type === 'accepted' ;
const title = isTypeAccepted ? 'friendRequestAcceptedNotificationTitle' : 'friendRequestNotificationTitle' ;
const title = isTypeAccepted
const message = isTypeAccepted ? 'friendRequestAcceptedNotificationMessage' : 'friendRequestNotificationMessage' ;
? 'friendRequestAcceptedNotificationTitle'
: 'friendRequestNotificationTitle' ;
conversation . getNotificationIcon ( ) . then ( iconUrl => {
const message = isTypeAccepted
window . log . info ( 'Add notification for friend request updated' , {
? 'friendRequestAcceptedNotificationMessage'
conversationId : conversation . idForLogging ( ) ,
: 'friendRequestNotificationMessage' ;
} ) ;
Whisper . Notifications . add ( {
const iconUrl = await conversation . getNotificationIcon ( ) ;
conversationId : conversation . id ,
window . log . info ( 'Add notification for friend request updated' , {
iconUrl ,
conversationId : conversation . idForLogging ( ) ,
isExpiringMessage : false ,
} ) ;
message : i18n ( message , conversation . getTitle ( ) ) ,
Whisper . Notifications . add ( {
messageSentAt : Date . now ( ) ,
conversationId : conversation . id ,
title : i18n ( title ) ,
iconUrl ,
} ) ;
isExpiringMessage : false ,
} ) ;
message : i18n ( message , conversation . getTitle ( ) ) ,
messageSentAt : Date . now ( ) ,
title : i18n ( title ) ,
} ) ;
} ,
} ,
} ) ;
} ) ;
Mikunj
6 years ago