fix: use switch instead of chained ifs

in setExpirationStartTimestamp
pull/2971/head
William Grant 2 years ago
parent 730641a14d
commit a2908cf24b

@ -174,35 +174,40 @@ export function setExpirationStartTimestamp(
expirationStartTimestamp = Math.min(expirationStartTimestamp, timestamp); expirationStartTimestamp = Math.min(expirationStartTimestamp, timestamp);
} }
// TODO legacy messages support will be removed in a future release switch (mode) {
if (mode === 'deleteAfterRead') { case 'deleteAfterRead':
window.log.debug( window.log.debug(
`WIP: [setExpirationStartTimestamp] We set the start timestamp for a delete after read message to ${new Date( `WIP: [setExpirationStartTimestamp] We set the start timestamp for a delete after read message to ${new Date(
expirationStartTimestamp expirationStartTimestamp
).toLocaleTimeString()}` ).toLocaleTimeString()}`
); );
} else if (mode === 'deleteAfterSend') { break;
window.log.debug( case 'deleteAfterSend':
`WIP: [setExpirationStartTimestamp] We set the start timestamp for a delete after send message to ${new Date( window.log.debug(
expirationStartTimestamp `WIP: [setExpirationStartTimestamp] We set the start timestamp for a delete after send message to ${new Date(
).toLocaleTimeString()}` expirationStartTimestamp
); ).toLocaleTimeString()}`
} else if (mode === 'legacy') { );
window.log.debug( break;
`WIP: [setExpirationStartTimestamp] We set the start timestamp for a legacy message to ${new Date( // TODO legacy messages support will be removed in a future release
expirationStartTimestamp case 'legacy':
).toLocaleTimeString()}` window.log.debug(
); `WIP: [setExpirationStartTimestamp] We set the start timestamp for a legacy message to ${new Date(
} else if (mode === 'off') { expirationStartTimestamp
window.log.debug( ).toLocaleTimeString()}`
'WIP: [setExpirationStartTimestamp] Disappearing message mode has been turned off. We can safely ignore this.' );
); break;
expirationStartTimestamp = undefined; case 'off':
} else { window.log.debug(
window.log.debug( 'WIP: [setExpirationStartTimestamp] Disappearing message mode has been turned off. We can safely ignore this.'
`WIP: [setExpirationStartTimestamp] Invalid disappearing message mode "${mode}" set. Ignoring` );
); expirationStartTimestamp = undefined;
expirationStartTimestamp = undefined; break;
default:
window.log.debug(
`WIP: [setExpirationStartTimestamp] Invalid disappearing message mode "${mode}" set. Ignoring`
);
expirationStartTimestamp = undefined;
} }
return expirationStartTimestamp; return expirationStartTimestamp;

Loading…
Cancel
Save