A bit of cleanup after some early code review

FREEBIE
pull/749/head
Scott Nonnenberg 8 years ago
parent 2955c36b3e
commit 9204188aa3

@ -120,7 +120,6 @@
model: this.model model: this.model
}); });
this.titleView.render(); this.titleView.render();
this.titleView.render();
this.view = new Whisper.MessageListView({ this.view = new Whisper.MessageListView({
collection: this.model.messageCollection, collection: this.model.messageCollection,
@ -573,7 +572,7 @@
var view = new Whisper.GroupMemberList({ var view = new Whisper.GroupMemberList({
model: members, model: members,
// we pass this in to allow nexted panels // we pass this in to allow nested panels
listenBack: this.listenBack.bind(this) listenBack: this.listenBack.bind(this)
}); });

@ -5,11 +5,7 @@
'use strict'; 'use strict';
window.Whisper = window.Whisper || {}; window.Whisper = window.Whisper || {};
// This needs to make each member link to their verification view - except for yourself // TODO: take a title string which could replace the 'members' header
// Do we update the display of each user to add Verified to their name if verified?
// What about the case where we're brought here because there are multiple users in the no-longer-verified state?
// We probably want to display some sort of helper text in that case at the least
// Or do we show only the problematic users in that case?
Whisper.GroupMemberList = Whisper.View.extend({ Whisper.GroupMemberList = Whisper.View.extend({
className: 'group-member-list panel', className: 'group-member-list panel',
templateName: 'group-member-list', templateName: 'group-member-list',

@ -336,7 +336,6 @@ $avatar-size: 44px;
} }
.banner { .banner {
// maybe make the top offset smaller here, or smaller in the iOS theme?
// what's the right color? // what's the right color?
background-color: orange; background-color: orange;
color: black; color: black;

Loading…
Cancel
Save