fix: keep updating dumps even if user config feature is off

ts/components/dialog/EditProfileDialog.tsx

@@ -357,9 +357,9 @@ async function commitProfileEdits(newName: string, scaledAvatarUrl: string | nul
 
   // might be good to not trigger a sync if the name did not change
   await conversation.commit();
+  await ConfigurationSync.queueNewJobIfNeeded();
 
   if (window.sessionFeatureFlags.useSharedUtilForUserConfig) {
-    await ConfigurationSync.queueNewJobIfNeeded();
     await setLastProfileUpdateTimestamp(Date.now());
   } else {
     await setLastProfileUpdateTimestamp(Date.now());

ts/interactions/conversationInteractions.ts

@@ -148,7 +148,6 @@ export async function declineConversationWithoutConfirm({
   if (blockContact) {
     await blockConvoById(conversationId);
   }
-  if (window.sessionFeatureFlags.useSharedUtilForUserConfig) {
   // when removing a message request, without blocking it, we actually have no need to store the conversation in the wrapper. So just remove the entry
 
   if (
@@ -157,7 +156,6 @@ export async function declineConversationWithoutConfirm({
   ) {
     await SessionUtilContact.removeContactFromWrapper(conversationToDecline.id);
   }
-  }
 
   if (syncToDevices) {
     await forceSyncConfigurationNowIfNeeded();
@@ -462,9 +460,9 @@ export async function uploadOurAvatar(newAvatarDecrypted?: ArrayBuffer) {
 
   if (newAvatarDecrypted) {
     await setLastProfileUpdateTimestamp(Date.now());
-    if (window.sessionFeatureFlags.useSharedUtilForUserConfig) {
     await ConfigurationSync.queueNewJobIfNeeded();
-    } else {
+
+    if (!window.sessionFeatureFlags.useSharedUtilForUserConfig) {
       await SyncUtils.forceSyncConfigurationNowIfNeeded(true);
     }
   } else {

ts/receiver/configMessage.ts

@@ -736,7 +736,7 @@ async function handleGroupsAndContactsFromConfigMessageLegacy(
     await handleClosedGroupsFromConfigLegacy(configMessage.closedGroups, envelope);
   }
 
-  handleOpenGroupsFromConfig(configMessage.openGroups);
+  handleOpenGroupsFromConfigLegacy(configMessage.openGroups);
 
   if (configMessage.contacts?.length) {
     await Promise.all(
@@ -749,7 +749,7 @@ async function handleGroupsAndContactsFromConfigMessageLegacy(
  * Trigger a join for all open groups we are not already in.
  * @param openGroups string array of open group urls
  */
-const handleOpenGroupsFromConfig = (openGroups: Array<string>) => {
+const handleOpenGroupsFromConfigLegacy = (openGroups: Array<string>) => {
   if (window.sessionFeatureFlags.useSharedUtilForUserConfig && Registration.isDone()) {
     return;
   }

ts/session/utils/job_runners/jobs/ConfigurationSyncJob.ts

@@ -280,9 +280,6 @@ class ConfigurationSyncJob extends PersistedJob<ConfigurationSyncPersistedData>
  * A ConfigurationSyncJob can only be added if there is none of the same type queued already.
  */
 async function queueNewJobIfNeeded() {
-  if (!window.sessionFeatureFlags.useSharedUtilForUserConfig) {
-    return;
-  }
   if (
     !lastRunConfigSyncJobTimestamp ||
     lastRunConfigSyncJobTimestamp < Date.now() - defaultMsBetweenRetries

ts/session/utils/sync/syncUtils.ts

@@ -44,6 +44,8 @@ const writeLastSyncTimestampToDb = async (timestamp: number) =>
  * Conditionally Syncs user configuration with other devices linked.
  */
 export const syncConfigurationIfNeeded = async () => {
+  await ConfigurationSync.queueNewJobIfNeeded();
+
   if (!window.sessionFeatureFlags.useSharedUtilForUserConfig) {
     const lastSyncedTimestamp = (await getLastSyncTimestampFromDb()) || 0;
     const now = Date.now();
@@ -70,8 +72,6 @@ export const syncConfigurationIfNeeded = async () => {
       return;
     }
     await writeLastSyncTimestampToDb(now);
-  } else {
-    await ConfigurationSync.queueNewJobIfNeeded();
   }
 };
 
@@ -83,23 +83,24 @@ export const forceSyncConfigurationNowIfNeeded = async (waitForMessageSent = fal
       resolve(false);
     }, 20000);
 
-    if (window.sessionFeatureFlags.useSharedUtilForUserConfig) {
+    // the ConfigurationSync also handles dumping in to the DB if we do not need to push the data, but the dumping needs to be done even before the feature flag is true.
     void ConfigurationSync.queueNewJobIfNeeded().catch(e => {
       window.log.warn(
-          'forceSyncConfigurationNowIfNeeded scheduling of jobs failed with',
+        'forceSyncConfigurationNowIfNeeded scheduling of jobs ConfigurationSync.queueNewJobIfNeeded failed with: ',
         e.message
       );
     });
+    if (window.sessionFeatureFlags.useSharedUtilForUserConfig) {
       if (waitForMessageSent) {
         window.Whisper.events.once(ConfigurationSyncJobDone, () => {
           resolve(true);
+          return;
         });
       } else {
         resolve(true);
-      }
-
         return;
       }
+    }
 
     void getCurrentConfigurationMessage(allConvos)
       .then(configMessage => {