tiny changes on the unsend logic

ts/interactions/conversationInteractions.ts

@@ -607,14 +607,14 @@ export async function deleteMessagesById(
             await doDeleteMessagesById(selectedMessages, conversation, true);
             // explicity close modal for this case.
             window.inboxStore?.dispatch(updateConfirmModal(null));
-          } else {
+            return;
+          }
           if (window.lokiFeatureFlags?.useUnsendRequests) {
             showDeletionTypeModal();
           } else {
             await doDeleteMessagesById(selectedMessages, conversation, false);
             window.inboxStore?.dispatch(updateConfirmModal(null));
           }
-          }
         },
         closeAfterInput: false,
       })

ts/models/conversation.ts

@@ -845,10 +845,10 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
     return true;
   }
 
-  public async unsendMessages(messages: Array<MessageModel>, onlyDeleteForSender: boolean = false) {
+  public async unsendMessages(messages: Array<MessageModel>) {
     const results = await Promise.all(
       messages.map(async message => {
-        return this.unsendMessage(message, onlyDeleteForSender);
+        return this.unsendMessage(message, false);
       })
     );
     return _.every(results);
@@ -863,9 +863,7 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
     onlyDeleteForSender: boolean = false
   ): Promise<boolean> {
     if (!message.get('messageHash')) {
-      window?.log?.error(
+      window?.log?.error(`message ${message.id}, cannot find hash: ${message.get('messageHash')}`);
-        `message with id ${message.get('id')} cannot find hash: ${message.get('messageHash')}`
-      );
       return false;
     }
     const ownPrimaryDevicePubkey = UserUtils.getOurPubKeyFromCache();
@@ -880,6 +878,7 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
     //#region building request
     const author = message.get('source');
 
+    // call getPropsForMessage here so we get the received_at or sent_at timestamp in timestamp
     const timestamp = message.getPropsForMessage().timestamp;
     if (!timestamp) {
       window?.log?.error('cannot find timestamp - aborting unsend request');
@@ -898,7 +897,7 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
     // 1-1 Session
     if (!this.isGroup()) {
       // sending to recipient
-      getMessageQueue()
+      await getMessageQueue()
         .sendToPubKey(new PubKey(destinationId), unsendMessage)
         .catch(window?.log?.error);
       return this.deleteMessage(message);
@@ -906,7 +905,7 @@ export class ConversationModel extends Backbone.Model<ConversationAttributes> {
 
     // closed groups
     if (this.isClosedGroup() && this.id) {
-      getMessageQueue()
+      await getMessageQueue()
         .sendToGroup(unsendMessage, undefined, PubKey.cast(this.id))
         .catch(window?.log?.error);
       // not calling deleteMessage as it'll be called by the unsend handler when it's received